prometheus

Commit Graph

Author	SHA1	Message	Date
Julius Volz	d3b6e61487	Put binop fill modifiers behind a feature flag Signed-off-by: Julius Volz <julius.volz@gmail.com>	5 months ago
Julius Volz	af3277f832	PromQL: Add `fill*()` binop modifiers to provide default values for missing series Signed-off-by: Julius Volz <julius.volz@gmail.com>	5 months ago
Ben Kochie	e14795bbf4	Remove copyright date from headers (#17785 ) Remove copyright dates from various files as part of [PROM-50]. [PROM-50]: https://github.com/prometheus/proposals/blob/main/proposals/0050-remove-copyright-dates.md Signed-off-by: SuperQ <superq@gmail.com>	6 months ago
aviralgarg05	119e75d78b	promqltest: Properly distinguish explicit counter_reset_hint specification This commit addresses the PR feedback for issue #17615. The previous implementation could not distinguish between: - No counter reset hint specified (meaning "don't care") - counter_reset_hint:unknown explicitly specified (meaning "verify it's unknown") Changes: - Added CounterResetHintSet field to parser.SequenceValue to track whether counter_reset_hint was explicitly specified in the test file - Modified buildHistogramFromMap to set this flag when the hint is present in the descriptor map - Updated newHistogramSequenceValue helper and histogramsSeries functions to propagate the flag through histogram series creation - Updated yacc grammar to use the new helper function - Modified compareNativeHistogram to accept the flag and only compare hints when explicitly specified This allows tests to: 1. Not specify a hint (no comparison, backward compatible) 2. Explicitly specify counter_reset_hint:unknown (verify it's unknown) 3. Explicitly specify counter_reset_hint:gauge/reset/not_reset (verify match) Fixes #17615 Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>	6 months ago
ADITYA TIWARI	3a82dcc6c5	promql/parser: simplify BinaryExpr label formatting Signed-off-by: ADITYA TIWARI <adityatiwari342005@gmail.com>	6 months ago
Aditya Tiwari	301b9eff44	Update comments to clarify label formatting method Signed-off-by: Aditya Tiwari <142050150+ADITYATIWARI342005@users.noreply.github.com>	6 months ago
ADITYA TIWARI	2e4f5e8cfc	promql/parser: consolidate label quoting logic refactors binary expression formatting to reuse writeLabels() instead of maintaining separate joinLabels() function. adds comprehensive UTF-8 label tests for all expression types Signed-off-by: ADITYA TIWARI <adityatiwari342005@gmail.com>	6 months ago
ADITYA TIWARI	5b299ef99e	fix/promql/parser: Fix utf-8 label quoting in format_query endpoint Signed-off-by: ADITYA TIWARI <adityatiwari342005@gmail.com>	6 months ago
Julien Pivotto	d0b122a711	PromQL: duration expression: add range() Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	7 months ago
Julien Pivotto	a5671a002f	API: Add a /api/v1/features endpoint Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	7 months ago
dongjiang	3239723098	Update golangci-lint and add modernize check (#17640 ) * add modernize check Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix golangci lint Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com>	7 months ago
Julius Volz	39e11f50b2	Fix serialization for empty `ignoring()` in combination with `group_x()` Currently both the backend and frontend printers/formatters/serializers incorrectly transform the following expression: ``` up * ignoring() group_left(__name__) node_boot_time_seconds ``` ...into: ``` up * node_boot_time_seconds ``` ...which yields a different result (including the metric name in the result vs. no metric name). We need to keep empty `ignoring()` modifiers if there is a grouping modifier present. Signed-off-by: Julius Volz <julius.volz@gmail.com>	7 months ago
Ben Kochie	204249fcb5	Update golangci-lint (#17478 ) * Update golangci-lint to v2.6.0 * Fixup various linting issues. * Fixup deprecations. * Add exception for `labels.MetricName` deprecation. Signed-off-by: SuperQ <superq@gmail.com>	8 months ago
Ben Kochie	48956f60d7	Update modernize (#17471 ) Apply additional Go modernize tool improvements. Signed-off-by: SuperQ <superq@gmail.com>	8 months ago
Linas Medžiūnas	b2e7938e25	[BUGFIX] PromQL: avoid panic parsing malformed info call (#17379 ) Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	8 months ago
Julius Volz	88b009f8a0	Disable extended range selector modifiers again after test run Signed-off-by: Julius Volz <julius.volz@gmail.com>	8 months ago
Julius Volz	a1000efe55	Fix formatting of range vector selectors with smoothed/anchored modifier The modifiers were already printed as part of the VectorSelector, so for: `foo[5m] anchored` ...the output was: `foo anchored[5m] anchored` Similar to how it was already done for `@` and `offset`, I now removed these modifiers in the copy of the vector selector that is used to print the matrix selector. I also removed some unused code that restored the copy of the vector selector after overwriting its fields. AFAICS there was no use in doing that, since it was a copy already that would just be thrown away after printing, and the original selector wasn't affected. I also removed an erroneous comment in `atOffset()` where no actual copying took place and no fields were overwritten. Signed-off-by: Julius Volz <julius.volz@gmail.com>	8 months ago
Julien Pivotto	0fa1e00dad	promql: allow 'anchored' and 'smoothed' as metric and label names Add ANCHORED and SMOOTHED keywords to the maybe_label and metric_identifier rules in the parser grammar, allowing them to be used as metric names and label names, similar to other keywords like 'offset', 'step', and 'bool'. This fixes an issue where expressions like `anchored{job="test"}` and `sum by (smoothed) (some_metric)` would fail to parse. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	8 months ago
Julien Pivotto	8d4876f944	promql/parser: Add string representation for AT token Add the "@" string representation for the AT token in ItemTypeStr map to ensure proper token-to-string conversion. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	8 months ago
Linas Medžiūnas	44df626620	promql (histograms): reconcile mismatched NHCB bounds (#17278 ) Fixes #17255. The implementation happens mostly in the Add and Sub method, but the reconciliation works for all relevant operations. For example, you can now `rate` over a range wherein the custom bucket boundaries are changing. Any custom bucket reconciliation is flagged with an info-level annotation. --------- Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com> Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>	8 months ago
Julius Volz	9d7d544be1	Disable extended range selector modifiers again after test run Signed-off-by: Julius Volz <julius.volz@gmail.com>	8 months ago
Julius Volz	b7c3a2194f	Fix formatting of range vector selectors with smoothed/anchored modifier The modifiers were already printed as part of the VectorSelector, so for: `foo[5m] anchored` ...the output was: `foo anchored[5m] anchored` Similar to how it was already done for `@` and `offset`, I now removed these modifiers in the copy of the vector selector that is used to print the matrix selector. I also removed some unused code that restored the copy of the vector selector after overwriting its fields. AFAICS there was no use in doing that, since it was a copy already that would just be thrown away after printing, and the original selector wasn't affected. I also removed an erroneous comment in `atOffset()` where no actual copying took place and no fields were overwritten. Signed-off-by: Julius Volz <julius.volz@gmail.com>	8 months ago
Julien Pivotto	99c926b810	promql: allow 'anchored' and 'smoothed' as metric and label names Add ANCHORED and SMOOTHED keywords to the maybe_label and metric_identifier rules in the parser grammar, allowing them to be used as metric names and label names, similar to other keywords like 'offset', 'step', and 'bool'. This fixes an issue where expressions like `anchored{job="test"}` and `sum by (smoothed) (some_metric)` would fail to parse. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	8 months ago
Bryan Boreham	1c58399160	PromQL: Speed up parsing of variadic functions (#17316 ) * PromQL: Add benchmark case with variadic function Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * PromQL: Speed up parsing of variadic functions Defer formatting of an error message until we hit an error. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> --------- Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
beorn7	51e0982c91	promql(histograms): Fix counter reset hint handling when aggregating Fixes #17308. As explained adding the warn-annotation about conflicting counter reset hints doesn't happen consistently. Furthermore, because of incremental mean calculation being used so far (which includes subtraction), avg calculation always created gauge histograms. The fix is to make Sub behave like Add WRT counter reset handling, and then set the result of a subtraction to gauge explicitly in actual PromQL subtraction (rather than using Sub for something else, like incremental mean calculation). Also, track the presence of a CounterReset hint and a NotCounterReset hint separately for the entirety of aggregated histograms and create the warn-annotation based on that. As a minor fix, this commit also consistently creates the warn annotation in aggregation to be about "aggregation" rather than "subtraction" or "addition", because the latter are just internal operations within the aggregation, which is not of interest for the user. Signed-off-by: beorn7 <beorn@grafana.com>	9 months ago
Julien	4199c2f45a	Add anchored and smoothed to vector selectors. (#16457 ) * Add anchored and smoothed to vector selectors. This adds "anchored" and "smoothed" keywords that can be used following a matrix selector. "Anchored" selects the last point before the range (or the first one after the range) and adds it at the boundary of the matrix selector. "Smoothed" applies linear interpolation at the edges using the points around the edges. In the absence of a point before or after the edge, the first or the last point is added to the edge, without interpolation. Exemple usage * `increase(caddy_http_requests_total[5m] anchored)` (equivalent of caddy_http_requests_total - caddy_http_requests_total offset 5m but takes counter reset into consideration) * `rate(caddy_http_requests_total[step()] smoothed)` Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com> * Update docs/feature_flags.md Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> Signed-off-by: Julien <291750+roidelapluie@users.noreply.github.com> * Smoothed/Anchored rate: Add more tests Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com> * Anchored/Smoothed modifier: error out with histograms Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com> --------- Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com> Signed-off-by: Julien <291750+roidelapluie@users.noreply.github.com> Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>	9 months ago
Craig Ringer	1ce84d8e2f	feat(promql): add first_over_time and ts_of_first_over_time Add a first_over_time function, and corresponding ts_of_first_over_time function. Both are behind the experimental functions feature flag. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>	10 months ago
beorn7	747c5ee2b1	Apply analyzer "modernize" to the whole codebase See https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize for details. This ran into a few issues (arguably bugs in the modernize tool), which I will fix in the next commit, so that we have transparency what was done automatically. Beyond those hiccups, I believe all the changes applied are legitimate. Even where there might be no tangible direct gain, I would argue it's still better to use the "modern" way to avoid micro discussions in tiny style PRs later. Signed-off-by: beorn7 <beorn@grafana.com>	10 months ago
Bryan Boreham	153cdb2b0b	[PERF] PromQL: Replace Fprintf %f with AppendFloat The combination of `AvailableBuffer`` followed by `Write` is optimised inside `bytes.Buffer`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	b8d2d505f5	[PERF] PromQL: Replace some Sprintf with bytes.Buffer Goes faster due to reduced memory allocation. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	49d9261693	[PERF] PromQL: Replace some simple Sprintf with string concat This goes faster because there is no runtime format parsing. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	e44ee2f182	[TESTS] PromQL: Add BenchmarkExprString Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	66fbea97bb	[TESTS] Check expr with function call in TestExprString Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Julius Hinze	77b5c3f217	Histograms: set annotation when adding or subtracting histograms that have `not_reset` and `reset` hints. Signed-off-by: Julius Hinze <julius.hinze@grafana.com>	10 months ago
Arve Knudsen	0a40df33fb	Make metric/label name validation scheme explicit (#16928 ) * Parameterize metric/label name validation scheme Parameterized metric/label name validation scheme --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Julius Hinze <julius.hinze@grafana.com>	10 months ago
Lukasz Mierzwa	7e22d2e5c0	Refactor TestParseExpressions to be more explicit about errors Right now TestParseExpressions tests if a query returns an error but it only does a fuzzy check on returned errors. The error returned by the parser is ParseErrors, which is a slice of ParseErr structs. The Error() method on ParseErrors will return an error string based on the first error in that slice. This hides other returned errors so we can end up with bogus errors being returned but won't ever find this via this test. This change makes the test compare returned error (which is always ParseErrors type) with expected ParseErrors slice. The extra benefit of this is that current tests mostly ignore error positional range and only test for correct error message. Now errors must return expected positional information. There are a few cases uncovered where the positional informatio of errors seems wrong, added FIXME for these lines. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	10 months ago
Lukasz Mierzwa	7b308dc7fe	Add a note about PositionRange values Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	11 months ago
George Krajcsovits	2aaeefe8e1	fix(parser): wrong end position aggregate expression (#17031 ) * fix(parser): wrong end position aggregate expression Fixes: https://github.com/prometheus/prometheus/issues/16053 The position range of nested aggregate expression was wrong, for the expression "(sum(foo))" the position of "sum(foo)" should be 1-9, but the parser could not decide the end of the expression on pos 9, instead it read ahead to pos 10 and then emitted the aggregate. But we only kept the last closing position (10) and wrote that into the aggregate. The reason for this is that the parser cannot know from "(sum(foo)" alone if the aggregate is finished. It could be finished as in "(sum(foo))" but equally it could continue with group modifier as "(sum(foo) by (bar))". Previous fix in #16041 tried to keep track of parenthesis, but that is complicated because the error happens after closing two parenthesis. That fix introduced new bugs. This fix now addresses the issue directly. Since we have to step outside the parser state machine anyway, we can just add an algorithm to detect and fix the issue. That's Lexer.findPrevRightParen(). Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	11 months ago
Julius Hinze	5855d973b0	model: set native histogram GaugeType hint when subtracting or multiplying/dividing with negative factors Signed-off-by: Julius Hinze <julius.hinze@grafana.com>	11 months ago
George Krajcsovits	457a2381f9	fix(parser): revert pr 16041 and 16754 (#16996 ) * fix(parser): revert pr 16041 and 16754 Fix for https://github.com/prometheus/prometheus/issues/16053 turned out to be too complicated and lead to more errors than it solved. See https://github.com/prometheus/prometheus/pull/16875. * add TODOs to wrong end positions * restore test and fix initialization bug Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	11 months ago
Matthieu MOREL	0484a6d547	chore: enable-all rule from govet Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	11 months ago
Matthieu MOREL	cef219c31c	chore: enable unused-receiver rule from revive Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	11 months ago
Bryan Boreham	75b72c2e42	Apply review feedback Make the order of aggregate parts the same as before. Make error message match. Fix up benchmark for changes elsewhere. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	12 months ago
Bryan Boreham	e4789cf89f	[PERF] PromQL: Reduce allocations when walking syntax tree Currently it allocates at least once on every recursion, and since `append` gives no extra space for 1 or 2 elements, will allocate several times for even modestly complex expressions. Instead, allocate space for 4 elements to begin, and defer adding another until we need it. Add a note that `path` may get overwritten; this was true previously. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	12 months ago
Bryan Boreham	ceac4d2418	[PERF] PromQL: Walk syntax tree using iterator Saves memory allocations. This is called a few times from the PromQL Engine. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	12 months ago
Julien Pivotto	984c8de0da	PromQL: Fix printing +min() Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	12 months ago
Julien Pivotto	3af0bdee68	PromQL: min/max/step: add more tests Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	12 months ago
Julien Pivotto	ee7d5158a7	Add step(), min(a,b) and max(a,b) in promql duration expressions step() is a new keyword introduced to represent the query step width in duration expressions. min(a,b) and max(a,b) return the min and max from two duration expressions. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	12 months ago
Simon Pasquier	71217a6e43	fix: prevent invalid array access in aggregate expression This commit fixes the evaluation of invalid expressions like `sum(rate(`. Before that, it would trigger a panic in the PromQL engine because it tried to access an index which is out of range. The bug was probably introduced by `06d0b063ea`. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	1 year ago
Julien Pivotto	6d56e77e0e	promql: Fix unary operator precedence in duration expressions Split unary operator handling in duration expressions into two specific cases to fix precedence conflicts: - Handle unary operators with number literals directly - Handle unary operators with parenthesized expressions separately This prevents unary minus from incorrectly binding to subsequent operators in expressions like `foo offset -1^1`, ensuring it parses as `(foo offset -1) ^ 1` rather than `foo offset (-1^1)`. Fixes #16711 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	1 year ago

1 2 3 4 5

228 Commits (00a7faa2e3cbef625faff9236cdabd877243f35b)