prometheus

Commit Graph

Author	SHA1	Message	Date
Arve Knudsen	00a7faa2e3	tsdb: fix division by zero in stale series compaction (#17952 ) Guard the stale series ratio calculation by checking numSeries > 0 before computing the ratio. This prevents division by zero when the head has no series. Fixes #17949 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Arve Knudsen	dc34b90f93	otlptranslator: fix silently swallowed error in addSumNumberDataPoints (#17954 ) The createAttributes error was incorrectly returning nil instead of err, causing errors to be silently discarded. This could lead to silent data loss for sum metrics during OTLP ingestion. Fixes #17953 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Callum Styan	97e7ef802c	remote write: simplify readability of timeseries filtering by using the slices package (#14318 ) * simplify readability of timeseries filtering by using the slices package Signed-off-by: Callum Styan <callumstyan@gmail.com> * ensure that BenchmarkBuildTimeSeries doesn't account for the building of the actual proto in the benchmark results, we only care about the buildTimeSeries call Signed-off-by: Callum Styan <callumstyan@gmail.com> --------- Signed-off-by: Callum Styan <callumstyan@gmail.com>	5 months ago
Bartlomiej Plotka	2597a12080	st: Add a hidden 'st-storage' feature flag for PROM-60 (#17907 ) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 months ago
George Krajcsovits	8047b05b3c	chore(codeowners): promote matt-gp external github user to owner of AWS SD (#17946 ) Branch protection means they cannot merge PRs to main/release branches. Branch protection means they cannot approve things outside their area for PRs to main/release branches. Also add sysadmind (Joe) as ower of aws, to make sure he gets notified. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
Julius Volz	5399eb9526	Merge pull request #17947 from zenador/docs-promql-info-func-ignore-info-metrics docs: promql: Update docs about ignoring info metrics	5 months ago
Jeanette Tan	df31bfd59d	Update docs about ignoring info metrics Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Arve Knudsen	ade3f08eca	notifier: fix flaky TestHangingNotifier race condition (#17934 ) * notifier: fix flaky TestHangingNotifier race condition Make deterministic through `synctest.Test()`. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Julius Volz	304dcdf695	Merge pull request #17832 from minyeong981/ui/typings-global-jquery-moment refactor(ui): Remove explicit any from globals	5 months ago
Julius Volz	eba102b26d	Merge pull request #17854 from rahulrairai59/patch-1 build: update react-router to v7.12.0 to fix CVE-2026-21884	5 months ago
George Krajcsovits	7a1cda057a	chore(maintainers): remove Nico from remote write maintainers (#17945 ) We discussed IRL.Nico no longer has time to contribute. This also syncs the file with CODEOWNERS. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
Ganesh Vernekar	8721871cf7	docs: Document the stale_series_compaction_threshold config file option (#17928 ) Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com> Signed-off-by: Björn Rabenstein <beorn@grafana.com> Co-authored-by: Björn Rabenstein <beorn@grafana.com>	5 months ago
Arve Knudsen	2262ae2542	PR template: add a concrete release notes example (#17721 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Björn Rabenstein	f390163d33	Merge pull request #17735 from aknuds1/arve/trim-string-by-bytes fix(promql): prevent panic in trimStringByBytes on invalid UTF-8	5 months ago
Björn Rabenstein	15030d6f19	Merge pull request #17738 from aknuds1/arve/leveled-compactor enhancement(tsdb): add test for `LeveledCompactor.Plan` stopping after excluding block	5 months ago
Björn Rabenstein	ba662882cb	Merge pull request #17927 from prometheus/codesome/stale-series-config-test Add test case for loading stale_series_compaction_threshold config	5 months ago
Bartlomiej Plotka	aa0f00efdf	tests(teststorage, api_test): Fix leaking readers; kill fake exemplar storage (#17906 ) * tests(teststorage): Fix leaking readers; use TSDB exemplar storage instead of fake Signed-off-by: bwplotka <bwplotka@gmail.com> * switched to v1 exemplar flow for now Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
George Krajcsovits	d25c8476e7	chore(sd-ownership): add default-maintainers as default code owner (#17940 ) * chore(sd-ownership): add default-maintainers as default code owner In accordance with dev summit decision. At the same time I've set up auto assignment for code review, meaning that not everybody will get notified for all PRs. If there's already a maintainer assigned, you don't get notified. Otherwise the assignment is round-robin, 1 at a time. Also you can opt out. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Remove code owner without write access Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
Arve Knudsen	a5f86c3fb6	cmd/prometheus: fix flaky TestQueryLog race condition (#17933 ) Add waitForQueryLog helper that polls for query log entries to appear before asserting, rather than reading the file immediately after making a query. This fixes a race condition where the query log wasn't flushed to disk before the test read the file. The helper uses a 5 second timeout with 100ms polling intervals, which is generous enough to handle slow CI environments while keeping the test responsive. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Aditya Prakash	5e66c9305f	scrape: clarify test channel name in manager_test (#17929 ) Signed-off-by: Nova <adityaprakash1357908@gmail.com>	5 months ago
Ganesh Vernekar	68b7aaaf15	Add test case for loading stale_series_compaction_threshold config Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	5 months ago
Ganesh Vernekar	9eb78735cf	Merge pull request #16929 from prometheus/codesome/stale-series-compaction tsdb: Early compaction of stale series Closes #13616 Based on https://github.com/prometheus/proposals/pull/55 Stale series tracking was added in #16925. This PR compacts the stale series into its own block before the normal compaction hits. Here is how the settings: stale_series_compaction_threshold: As soon as the ratio of stale series in the head block crosses StaleSeriesImmediateCompactionThreshold, TSDB performs a stale series compaction and puts all the stale series into a block and removed it from the head, but it does not remove it from the WAL. (technically this condition is checked every minute and not exactly immediate) Additional details WAL replay: after a stale series compaction, tombstones are added with (MinInt64, MaxInt64) for all these stale series. During WAL replay we add a special condition where when we find such tombstone, it immediately removes the series from the memory instead of storing the tombstone. This is required so that we don't spike up memory during WAL replay and also don't keep the compacted stale series in the memory. Head block truncation ignores this block via the added metadata, similar to out-of-order blocks.	5 months ago
Arve Knudsen	2332962c4b	otlptranslator: filter __name__ from OTLP attributes to prevent duplicates (#17917 ) * otlptranslator: filter __name__ from OTLP attributes to prevent duplicates OTLP metrics can have a __name__ attribute which, when combined with the metric name passed via extras, creates duplicate __name__ labels. This commit implements filtering out of any __name__ metric attribute from OTLP. Also rename TestCreateAttributes to TestPrometheusConverter_createAttributes for consistency, and add test cases for __name__, __type__, and __unit__ OTLP metric attributes. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Arve Knudsen	c8ff2d739b	enhancement(tsdb): add test for LeveledCompactor stopping after excluding block Add a test for `LeveledCompactor.Plan()` stopping after a block matches the `BlockExcludeFilter`, as a sub-test `TestLeveledCompactor/Plan/BlockExcludeFilter stops iteration`. Also moving `TestLeveledCompactor_plan` to a sub-test of `TestLeveledCompactor`, for consistency. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Arve Knudsen	65f8482335	fix(promql): prevent panic in trimStringByBytes on invalid UTF-8 Add bounds check to prevent index out of range panic when trimStringByBytes receives a string containing only UTF-8 continuation bytes (0x80-0xBF). Previously, the loop would decrement size below 0 when no valid rune start byte was found, causing a panic. A malicious query string with only continuation bytes could crash the Prometheus server via the ActiveQueryTracker before the query was parsed or validated. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Ganesh Vernekar	3e4a094dbb	Add stale_series_compaction_threshold config file option Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	5 months ago
Ganesh Vernekar	4f3de8da29	tsdb: Add unit tests for stale series compaction Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	5 months ago
Ganesh Vernekar	43dc23afe7	tsdb: Clear stale series from the Head during WAL replay Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	5 months ago
Ganesh Vernekar	43e69388df	tsdb: Add stale series compaction support in the DB Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	5 months ago
Ganesh Vernekar	9b444b57af	tsdb: Add StaleHead and GC for stale series in the Head block Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	5 months ago
Bartlomiej Plotka	bec70227f1	feat(scrape)[PART5b]: Add AppenderV2 support to scrape.NewManager constructor (#17872 ) * feat(scrape)[PART5b]: Add AppenderV2 support to scrape.NewManager optionally to V1 Signed-off-by: bwplotka <bwplotka@gmail.com> * Update scrape/manager.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * fixes after rebase Signed-off-by: bwplotka <bwplotka@gmail.com> * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Bartlomiej Plotka	0d116b0994	tests(teststorage): Close Storage in the helper (#17902 ) Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
Siavash Safi	2437977bff	fix(notify): apply config sendloop cleanup fix (#17915 ) These bugs were discovered accidentally with code analysis: - https://app.devin.ai/review/prometheus/prometheus/pull/16355 Upon further inspection and performing more analysis, 3 potential bugs were found: 1. sendloops could continue running if corresponding AM changed position in the config 2. multiple configs with the same hash would share sendloops resulting in sets without sendloops 3. sendloops could continue running if the config hash was changed - `TestApplyConfigSendLoopsNotStoppedOnKeyChange`: Verifies sendLoops work when keys swap (no fix needed) - `TestApplyConfigDuplicateHashSharesSendLoops`: Verifies sendLoops are independent with duplicate hashes (bug fixed) - `TestApplyConfigHashChangeLeaksSendLoops`: Verifies sendLoops are cleaned up when hash changes (bug fixed) Signed-off-by: Siavash Safi <siavash@cloudflare.com>	5 months ago
Ben Kochie	2a890d6fcf	Bump promci action (#17912 ) Update promci to pick up `latest` tag fix. Fixes: https://github.com/prometheus/prometheus/issues/16238 Signed-off-by: SuperQ <superq@gmail.com>	5 months ago
Ben Kochie	9b549fa118	Update Go yaml v3 library (#17913 ) Replace archived `gopkg.in/yaml.v3` with supported `go.yaml.in/yaml/v3`. Fixes: https://github.com/prometheus/prometheus/issues/16415 Signed-off-by: SuperQ <superq@gmail.com>	5 months ago
zenador	9a49316c59	promql: info function: fix unit test for ignoring info metrics themselves (#17911 ) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Björn Rabenstein	82fec75982	Merge pull request #17626 from aviralgarg05/fix-promqltest-counter-reset-hint-comparison promqltest: Add optional counter reset hint comparison for native histograms	5 months ago
Siavash Safi	d9ccd70ac1	fix(notify): flaky tests (#17899 ) Add a helper function to set up AlertmanagerSets. Fix all flaky tests. Signed-off-by: Siavash Safi <siavash@cloudflare.com>	5 months ago
Julien	8e6b097560	Merge pull request #17892 from roidelapluie/roidelapluie/pushver Makefile.common: Push major version tags to registry	5 months ago
Matt	39e524088c	Fix(discovery/aws): Create Copies of Default Config (#17769 ) Signed-off-by: matt-gp <small_minority@hotmail.com>	5 months ago
George Krajcsovits	21fb899c32	fix(teststorage/appender.go): TODO and Sample staleness check (#17905 ) * fix(teststorage/appender.go): TODO and Sample staleness check Allow different order of consecutive stale samples between the expected and actual array for RequireEqual and RequireNotEqual by trying to swap the expected side until it matches. Also fix the definition of stale sample in the test, it's not only float, but defined for native histograms as well. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * add unit tests Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
Bartlomiej Plotka	04a3ef75f2	chore: remove testutil.T which is no longer needed since Go 1.13 (#17903 ) testutil.T was needed before https://go.dev/doc/go1.13#testingpkgtesting Now it's inconsistent and confusing, so let's kill it. Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
Bartlomiej Plotka	664b255699	Merge pull request #17867 from prometheus/bwplotka/a2-scrape-1 refactor(appenderV2)[PART5a]: add AppendableV2 support to scrape loop + tests	5 months ago
zenador	e3b6eee437	promql: info function: fix series without identifying labels not being returned (#17898 ) * promql: info function: fix series without identifying labels not being returned --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Bartlomiej Plotka	c021f316ba	Merge pull request #17897 from roidelapluie/roidelapluie/gowork Align go.work version with go.mod files	5 months ago
Julien Pivotto	6b3867e8d4	Align go.work version with go.mod files Update go.work from go 1.24.9 to go 1.24.0 to match the version specified in all go.mod files across the project Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	5 months ago
Bryan Boreham	d83e11926d	Merge pull request #17795 from chuanye-gao/fix/ready-stopping-header-test web: fix /-/ready stopping header and add tests	5 months ago
Bartlomiej Plotka	bc55334845	Merge pull request #17881 from bboreham/scrape-benchmark [TESTS] Scraping: Reset appender in BenchmarkScrapeLoopAppend	5 months ago
Julien	2193782b1d	Merge pull request #17826 from roidelapluie/roidelapluie/goworkversion scripts: use git ls-files and check go.work files in version check	5 months ago
Julien	d63e418d78	Merge pull request #17896 from roidelapluie/roidelapluie/fixdistroless Fix ARG scoping in Dockerfile.distroless	5 months ago

1 2 3 4 5 ...

16832 Commits (00a7faa2e3cbef625faff9236cdabd877243f35b) All Branches Search

16832 Commits (00a7faa2e3cbef625faff9236cdabd877243f35b)

All Branches