prometheus

Commit Graph

Author	SHA1	Message	Date
Bartlomiej Plotka	aa0f00efdf	tests(teststorage, api_test): Fix leaking readers; kill fake exemplar storage (#17906 ) * tests(teststorage): Fix leaking readers; use TSDB exemplar storage instead of fake Signed-off-by: bwplotka <bwplotka@gmail.com> * switched to v1 exemplar flow for now Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
Bartlomiej Plotka	0d116b0994	tests(teststorage): Close Storage in the helper (#17902 ) Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
George Krajcsovits	21fb899c32	fix(teststorage/appender.go): TODO and Sample staleness check (#17905 ) * fix(teststorage/appender.go): TODO and Sample staleness check Allow different order of consecutive stale samples between the expected and actual array for RequireEqual and RequireNotEqual by trying to swap the expected side until it matches. Also fix the definition of stale sample in the test, it's not only float, but defined for native histograms as well. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * add unit tests Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
Bartlomiej Plotka	04a3ef75f2	chore: remove testutil.T which is no longer needed since Go 1.13 (#17903 ) testutil.T was needed before https://go.dev/doc/go1.13#testingpkgtesting Now it's inconsistent and confusing, so let's kill it. Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
Bartlomiej Plotka	664b255699	Merge pull request #17867 from prometheus/bwplotka/a2-scrape-1 refactor(appenderV2)[PART5a]: add AppendableV2 support to scrape loop + tests	5 months ago
Julien Pivotto	66bb47ade6	fuzzing: fix artifact path and experimental parser flags Fix two issues in fuzzing infrastructure: - Correct artifact upload path from promql/testdata/fuzz to util/fuzzing/testdata/fuzz to match where Go stores crash artifacts - Fix GetCorpusForFuzzParseExpr to preserve original parser flag values instead of always resetting them to false, which was disabling experimental features before actual fuzzing ran Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	5 months ago
bwplotka	f61a83bcd6	fix: appenderV2 mock exemplar appendErr injection before appending it Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
bwplotka	1d3c6210f3	add extra fanout test Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
Julius Volz	d3b6e61487	Put binop fill modifiers behind a feature flag Signed-off-by: Julius Volz <julius.volz@gmail.com>	5 months ago
Bartlomiej Plotka	3374d2e56f	feat(teststorage)[PART4a]: Add AppendableV2 support for mock Appendable (#17834 ) * feat(teststorage)[PART4a]: Add AppendableV2 support for mock Appendable Signed-off-by: bwplotka <bwplotka@gmail.com> * fix: adjusted AppenderV1 flow for reliability Found in https://github.com/prometheus/prometheus/pull/17838 and by Krajo comment Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> * fix broken appV2 commit and rollback; added tests Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	5 months ago
Julien Pivotto	de0a864b5c	Fuzzing: Move to go fuzzing Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	5 months ago
Ritik Shukla	f9242d4707	util: enhance test coverage for strutil package - Added comprehensive edge case tests for SanitizeLabelName (10 cases) - Added comprehensive edge case tests for SanitizeFullLabelName (15 cases) - Added more test cases for link generation functions (4 additional cases) - Fixed unicode test case: corrected expected underscores from 7 to 5 - Fixed digits test case: corrected expected output from '_____' to '_2345' - Converted tests to table-driven format with named subtests - Achieved 100% code coverage for the package Signed-off-by: Ritik Shukla <ritikshukla@Ritiks-MacBook-Air.local>	5 months ago
Julius Hinze	22463b1e9f	tsdb: add support for OOO exemplars in CircularExemplarStorage (#17469 ) * tsdb: add support for OOO exemplars in CircularExemplarStorage Doubly linked exemplar storage resize. Split exemplar buffer resize into shrink and grow functions. Skip duplicate OOO exemplars, re-initialize emptied index after deleting its last exemplar. Signed-off-by: Julius Hinze <julius.hinze@grafana.com>	6 months ago
Ben Kochie	e14795bbf4	Remove copyright date from headers (#17785 ) Remove copyright dates from various files as part of [PROM-50]. [PROM-50]: https://github.com/prometheus/proposals/blob/main/proposals/0050-remove-copyright-dates.md Signed-off-by: SuperQ <superq@gmail.com>	6 months ago
Bartlomiej Plotka	17e06dbab5	refactor(scrape)[PART2]: simplified scrapeLoop constructors & tests; add teststorage.Appendable mock (#17631 ) * refactor(scrape): simplified scrapeLoop constructors & tests; add teststorage.Appender mock Signed-off-by: bwplotka <bwplotka@gmail.com> debug * refactor(scrape): simplified newLoop even more Signed-off-by: bwplotka <bwplotka@gmail.com> * refactor(scrape): rename sl -> app, slApp -> app Signed-off-by: bwplotka <bwplotka@gmail.com> * fix TestScrapeLoopRun flakiness Signed-off-by: bwplotka <bwplotka@gmail.com> * fix lint Signed-off-by: bwplotka <bwplotka@gmail.com> * kill unused listSeriesSet code Signed-off-by: bwplotka <bwplotka@gmail.com> * fix closing to not panic Signed-off-by: bwplotka <bwplotka@gmail.com> * added extra benchmark for scrapeAndReport Signed-off-by: bwplotka <bwplotka@gmail.com> * added extra benchmark for restartLoops Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed last comments Signed-off-by: bwplotka <bwplotka@gmail.com> * fix TestConcurrentAppender_ReturnsErrAppender naming Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed small comments Signed-off-by: bwplotka <bwplotka@gmail.com> * refactor(scrape): ensure scrape config is reloaded; added test Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	6 months ago
Joshua Rogers	a155ad55a3	httputil: add Vary: Accept-Encoding and fix compression headers (#17466 ) - Emit `Vary: Accept-Encoding` in newCompressedResponseWriter so shared caches key responses by content-coding. This prevents cache poisoning and undecodable bytes when a compressed variant is cached and later served to a client that didn't advertise support. (RFC 9110 §12.5.5 "Vary"; RFC 9111 §4.1 cache key & Vary) - When selecting gzip/deflate, set `Content-Encoding` and delete any existing `Content-Length` so Go's net/http can frame the message correctly (chunked for HTTP/1.1; implicit for HTTP/2+). This avoids stale length mismatches and related proxy/client issues. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>	6 months ago
Julien Pivotto	a5671a002f	API: Add a /api/v1/features endpoint Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	7 months ago
Clark McCauley	9d508a4888	util: add +Inf bucket in MetricFamiliesToWriteRequest when not present (#15864 ) * Add +Inf bucket in MetricFamiliesToWriteRequest if not present Signed-off-by: Clark McCauley <clarkmccauley@gmail.com>	7 months ago
Ben Kochie	204249fcb5	Update golangci-lint (#17478 ) * Update golangci-lint to v2.6.0 * Fixup various linting issues. * Fixup deprecations. * Add exception for `labels.MetricName` deprecation. Signed-off-by: SuperQ <superq@gmail.com>	8 months ago
Ben Kochie	48956f60d7	Update modernize (#17471 ) Apply additional Go modernize tool improvements. Signed-off-by: SuperQ <superq@gmail.com>	8 months ago
Linas Medžiūnas	44df626620	promql (histograms): reconcile mismatched NHCB bounds (#17278 ) Fixes #17255. The implementation happens mostly in the Add and Sub method, but the reconciliation works for all relevant operations. For example, you can now `rate` over a range wherein the custom bucket boundaries are changing. Any custom bucket reconciliation is flagged with an info-level annotation. --------- Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com> Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>	8 months ago
beorn7	ad7d1aed99	Phase out native histogram feature flag The detailed plan for this is laid out in https://github.com/prometheus/prometheus/issues/16572 . This commit adds a global and local scrape config option `scrape_native_histograms`, which has to be set to true to ingest native histograms. To ease the transition, the feature flag is changed to simply set the default of `scrape_native_histograms` to true. Further implications: - The default scrape protocols now depend on the `scrape_native_histograms` setting. - Everywhere else, histograms are now "on by default". Documentation beyond the one for the feature flag and the scrape config are deliberately left out. See https://github.com/prometheus/prometheus/pull/17232 for that. Signed-off-by: beorn7 <beorn@grafana.com>	8 months ago
György Krajcsovits	d11ee103ac	perf(tsdb): reuse map of sample types to speed up head appender While investigating +10% CPU in v3.7 release, found that ~5% is from expanding the types map. Try reuse. Also fix a linter error. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	9 months ago
György Krajcsovits	c26a5390aa	perf(tsdb): reuse map of sample types to speed up head appender While investigating +10% CPU in v3.7 release, found that ~5% is from expanding the types map. Try reuse. Also fix a linter error. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	9 months ago
Jan Fajerski	c9e0e36701	Add comments clarifying why promql.Querylogger exists (#17231 ) And why we only have one implementation in this code base. Fixes: https://github.com/prometheus/prometheus/issues/15869 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	9 months ago
machine424	365409d3be	chore: allow seamless use of testing/synctest for >=go1.24 Signed-off-by: machine424 <ayoubmrini424@gmail.com>	9 months ago
beorn7	2628320292	promql: Fix when to emit a `HistogramCounterResetCollisionWarning` So far, we emitted a `HistogramCounterResetCollisionWarning` when encountering conflicting counter resets in the calculation of (i)rate and friends. We even tested for that. However, in the rate calculation, we are not interested in those collisions. They are actually expected. On the other hand, we did not warn about those collisions when doing a `sum` aggregation, where such a warning would be appropriate. This commit removes the warning in the former case and adds it in the latter. Sadly, we cannot really test this as we still remove the counter reset hint for the first sample in a chunk. (And that's the only sample where we could get a `NotCounterReset` hint.) Signed-off-by: beorn7 <beorn@grafana.com>	10 months ago
Owen Williams	6ee965c255	common: Update to prom/common v0.66.0, fix TextParser creation (#17139 ) TextParser as of prom/common v0.66.0 requires an explicit validation scheme. Signed-off-by: Owen Williams <owen.williams@grafana.com>	10 months ago
beorn7	747c5ee2b1	Apply analyzer "modernize" to the whole codebase See https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize for details. This ran into a few issues (arguably bugs in the modernize tool), which I will fix in the next commit, so that we have transparency what was done automatically. Beyond those hiccups, I believe all the changes applied are legitimate. Even where there might be no tangible direct gain, I would argue it's still better to use the "modern" way to avoid micro discussions in tiny style PRs later. Signed-off-by: beorn7 <beorn@grafana.com>	10 months ago
Julius Hinze	cdf7208478	annotations: histogram counter reset warning includes operation Signed-off-by: Julius Hinze <julius.hinze@grafana.com>	10 months ago
Julius Hinze	77b5c3f217	Histograms: set annotation when adding or subtracting histograms that have `not_reset` and `reset` hints. Signed-off-by: Julius Hinze <julius.hinze@grafana.com>	10 months ago
Arve Knudsen	0a40df33fb	Make metric/label name validation scheme explicit (#16928 ) * Parameterize metric/label name validation scheme Parameterized metric/label name validation scheme --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Julius Hinze <julius.hinze@grafana.com>	10 months ago
Neeraj Gartia	2c0de4e7c2	Fix `histogram_quantile` annotation in range query when delayed name removal is disabled (#16794 ) Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	10 months ago
Matthieu MOREL	cef219c31c	chore: enable unused-receiver rule from revive Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	11 months ago
Carrie Edwards	44b0fbba1e	No info annotation for rate/increase when type is histogram (#16915 ) Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>	11 months ago
George Krajcsovits	5b7ff92d95	fix(promql): histogram_quantile and histogram_fraction NaN observed in native histogram (#16724 ) * fix(promql): histogram_quantile NaN observed in native histogram Fixes: #16578 See the issue for detailed explanation. When a histogram had only NaN observations and no normal observations, we returned 0 from the quantile, which is completely wrong. If there were normal observations but we went over them, we returned the upper bound of the existing buckets, however that contradicts expectations on histogram_fraction. Now we return NaN if the quantile is calculated to be over all normal observations, falling into NaNs (in a virtual +Inf bucket). We also return info level annotations if we see any NaN observations. The annotation calls out if we returned NaN or even if we took the virtual +Inf bucket into account. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * fix(promql): histogram_fraction NaN observed in native histogram Fixes: #16580 According to the specification we should not take NaN observations into account when calculating the fraction. This commit fixes that and adds an info level annotation to let the user know about this. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	1 year ago
Arthur Silva Sens	8d0a747237	PROM-39: Provide PromQL info annotations when rate()/increase() over series without `__type__`="counter" label (#16632 ) * Provide PromQL info annotations when rate()/increase() over series without counter label Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> * Address comments Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Innokentii Konstantinov	cd5bd11bd8	Export QuerySamples StartTimestamp and Interval to enable custom statistics implementations to populate these fields as needed. Signed-off-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com>	1 year ago
Julius Volz	13564c03ef	Standardize doc page title handling See https://groups.google.com/g/prometheus-developers/c/cwL3cM66Em8 Signed-off-by: Julius Volz <julius.volz@gmail.com>	1 year ago
jub0bs	4bc8df0f54	util/httputil: Always add Vary header in SetCORS Closes #15406 Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>	1 year ago
Arve Knudsen	e7e3ab2824	Fix linting issues found by golangci-lint v2.0.2 (#16368 ) * Fix linting issues found by golangci-lint v2.0.2 --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arthur Silva Sens	95f49dd84b	Bump prometheus/common to v0.63.0 (#16210 ) * Bump prometheus/common to v0.63.0 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> * nolint usage of deprecated model.NameValidationScheme Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Bartlomiej Plotka	7a7bc65237	Add util/compression package to consolidate snappy/zstd use in Prometheus. (#16156 ) # Conflicts: # tsdb/db_test.go Apply suggestions from code review tmp Addressed comments. Update util/compression/buffers.go Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Matthieu MOREL	c7d4b53ec1	chore: enable unused-parameter from revive Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
jub0bs	329ec6831a	util/httputil: reduce heap allocations in newCompressedResponseWriter (#16001 ) * util/httputil: Benchmark newCompressedResponseWriter This benchmark illustrates that newCompressedResponseWriter incurs a prohibitive amount of heap allocations when handling a request containing a malicious Accept-Encoding header.¬ Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com> * util/httputil: Improve newCompressedResponseWriter This change dramatically reduces the heap allocations (in bytes) incurred when handling a request containing a malicious Accept-Encoding header. Below are some benchmark results; for conciseness, I've omitted the name of the benchmark function (BenchmarkNewCompressionHandler_MaliciousAcceptEncoding): ``` goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/util/httputil cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz │ old │ new │ │ sec/op │ sec/op vs base │ 18.60m ± 2% 13.54m ± 3% -27.17% (p=0.000 n=10) │ old │ new │ │ B/op │ B/op vs base │ 16785442.50 ± 0% 32.00 ± 0% -100.00% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10) ``` Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com> --------- Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>	1 year ago
Neeraj Gartia	8be416a67c	[FIX] PromQL: Updates annotation for bin op between incompatible histograms (#15895 ) PromQL: Updates annotation for bin op between incompatible histograms --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
crystalstall	616914abe2	Signed-off-by: crystalstall <crystalruby@qq.com> refactor: using slices.Contains to simplify the code Signed-off-by: crystalstall <crystalruby@qq.com>	1 year ago
Neeraj Gartia	0e99ca3e8c	[BUGFIX] PromQL: Fix `deriv`, `predict_linear` and `double_exponential_smoothing` with histograms (#15686 ) PromQL: Fix deriv, predict_linear and double_exponential_smoothing with histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 years ago
Joel Beckmeyer	bad1c75514	fix alignment of atomic uint64 on 32-bit Signed-off-by: Joel Beckmeyer <joel@beckmeyer.us>	2 years ago
TJ Hoplock	437362a7a7	fix(deduper): use ptr to sync.RWMutex, fix panic during concurrent use Resolves: #15559 As accurately noted in the issue description, the map is shared among child loggers that get created when `WithAttr()`/`WithGroup()` are called on the underlying handler, which happens via `log.With()` and `log.WithGroup()` respectively. The RW mutex was a value in the previous implementation that used go-kit/log, and I should've updated it to use a pointer when I converted the deduper. Also adds a test. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2 years ago

1 2 3 4 5 ...

329 Commits (00a7faa2e3cbef625faff9236cdabd877243f35b)