prometheus

Commit Graph

Author	SHA1	Message	Date
Charles Korn	2dd07fbb1b	notifier: optionally drain queued notifications before shutting down (#14290 ) * Add draining of queued notifications to `notifier.Manager` Signed-off-by: Charles Korn <charles.korn@grafana.com> * Update docs Signed-off-by: Charles Korn <charles.korn@grafana.com> * Address PR feedback Signed-off-by: Charles Korn <charles.korn@grafana.com> * Add more logging Signed-off-by: Charles Korn <charles.korn@grafana.com> * Address offline feedback: remove timeout Signed-off-by: Charles Korn <charles.korn@grafana.com> * Ensure stopping takes priority over further processing, make tests more robust Signed-off-by: Charles Korn <charles.korn@grafana.com> * Make channel unbuffered Signed-off-by: Charles Korn <charles.korn@grafana.com> * Update docs Signed-off-by: Charles Korn <charles.korn@grafana.com> * Fix race in test Signed-off-by: Charles Korn <charles.korn@grafana.com> * Remove unnecessary context Signed-off-by: Charles Korn <charles.korn@grafana.com> * Make Stop safe to call multiple times Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	2 years ago
Bryan Boreham	f24ce00320	Merge pull request #13434 from bboreham/elide-queriers storage: don't wrap single querier in merge-queriers	2 years ago
Arve Knudsen	1abeebacb8	Merge pull request #14340 from aknuds1/arve/fix-lint Upgrade to golangci-lint v1.59.1, fix errors	2 years ago
Daniel Mellado	1b5f65002a	Bump go-retryablehttp to fix basic auth creds leak This PR updates go-retryablehttp to version 0.7.7, even if it's used as an indirect import. Versions previous to that can didn't sanitize urls, discussed at HDCSEC-2024-12 [1] [1] https://discuss.hashicorp.com/t/hcsec-2024-12-go-retryablehttp-can-leak-basic-auth-credentials-to-log-files/68027 Signed-off-by: Daniel Mellado <dmellado@redhat.com>	2 years ago
Jan-Otto Kröpke	99355443c7	remote write handler: reject samples with future timestamps (#14304 ) * fix(remote_write): reject samples with future timestamps * increase check to +10 minutes to allow for clock drift --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	348f7f8d0c	Merge pull request #14341 from charleskorn/charleskorn/cleanup-pending-read Fix issue where pending OOO read can be left dangling if creating querier fails	2 years ago
Ben Ye	246b7c6a5c	TSDB: Change block populator to accept postings index function (#14213 ) Signed-off-by: Ben Ye <benye@amazon.com>	2 years ago
Ben Ye	5585a3c7e5	tsdb: expose hook to customize block querier (#14114 ) * expose hook for block querier Signed-off-by: Ben Ye <benye@amazon.com> * update comment Signed-off-by: Ben Ye <benye@amazon.com> * use defined type Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>	2 years ago
Charles Korn	2c5e88748e	Fix issue where pending OOO read can be left dangling if creating querier fails Signed-off-by: Charles Korn <charles.korn@grafana.com>	2 years ago
Arve Knudsen	0395b04419	golangci-lint: Upgrade to v1.59.1 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2 years ago
Arve Knudsen	d902116b41	Fix various linting errors Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2 years ago
Bryan Boreham	6030407d25	Merge branch 'main' into elide-queriers Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	b6aba4ff14	Merge pull request #14074 from bboreham/kahan-sum-sum [ENHANCEMENT] PromQL: use Kahan summation for sum()	2 years ago
Martin Chodur	00b110c65c	Fix data corruption in remote write if max_sample_age is applied (#14078 ) * fix: try to reproduce the bug from https://github.com/prometheus/prometheus/issues/13979 in a test case Signed-off-by: David Vavra <sevenood@gmail.com> * fix: data corruption in remote write if max_sample_age is applied Signed-off-by: David Vavra <sevenood@gmail.com> * add benchmark for buildTimeSeries which does the filtering Signed-off-by: Callum Styan <callumstyan@gmail.com> --------- Signed-off-by: David Vavra <sevenood@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: David Vavra <sevenood@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	2 years ago
Piotr	d78253319d	queue_manager: add histogram info to error logs (#14326 ) Signed-off-by: Piotr Gwizdala <17101802+thampiotr@users.noreply.github.com>	2 years ago
Łukasz Mierzwa	dbd29df5df	Fix @goyacc invocation (#14324 ) goyacc is installed using 'install-goyacc' and ends up in GOPATH/bin. GOPATH isn't usually part of standard PATH, so when make tries to run goyacc it fails, unless PATH includes GOPATH/bin. Other Go tools, like golangci-lint, are also installed via go install into GOPATH/bin but they run correctly because make invocations for them use FIRST_GOPATH viriable to use full path. Call goyacc using FIRST_GOPATH/bin as well so it works without GOPATH being included in PATH. Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>	2 years ago
akunszt	2aaf99dd0a	discovery: aws: expose Primary IPv6 addresses as label, partially fixes #7406 (#14156 ) * discovery: aws: expose Primary IPv6 addresses as label Add __meta_ec2_primary_ipv6_addresses label. This label contains the Primary IPv6 address for every ENI attached to the EC2 instance. It is ordered by the DeviceIndex and the missing elements (interface without Primary IPv6 address) are kept in the list. --------- Signed-off-by: Arpad Kunszt <akunszt@hiya.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>	2 years ago
George Krajcsovits	c25d6d8ac6	Merge pull request #14316 from pracucci/export-labelsToLabelsProto Export remote.LabelsToLabelsProto() and remote.LabelProtosToLabels()	2 years ago
Marco Pracucci	b6dc9c1817	Merge branch 'main' into export-labelsToLabelsProto	2 years ago
machine424	f9ca6c4ae6	chore: add an alert based on the metric prometheus_sd_kubernetes_failures_total that was introcued in https://github.com/prometheus/prometheus/pull/13554 The same motivation for adding the metric applies: To avoid silent SD failures, as existing logs may not be regularly checked and can be missed. Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>	2 years ago
Marco Pracucci	35564c0cb0	Export remote.LabelsToLabelsProto() and remote.LabelProtosToLabels() Signed-off-by: Marco Pracucci <marco@pracucci.com>	2 years ago
Bryan Boreham	5c417684f8	Merge pull request #14296 from colega/fix-matcher-string-with-empty-label-name Fix `Matcher.String()` with empty label name	2 years ago
Bryan Boreham	6685cbc234	Merge branch 'main' into fix-matcher-string-with-empty-label-name	2 years ago
Arve Knudsen	f45b0fd9ef	Merge pull request #14311 from aknuds1/arve/loggercheck golangci-lint: Enable loggercheck linter	2 years ago
Bryan Boreham	84602bbace	Merge branch 'main' into fix-matcher-string-with-empty-label-name	2 years ago
Bryan Boreham	5a1886d247	Merge branch 'main' into arve/loggercheck	2 years ago
George Krajcsovits	9a8b6c52ca	Merge pull request #14313 from prometheus/merge-2.53-to-main Merge 2.53 to main	2 years ago
György Krajcsovits	fcabffb999	Merge branch 'release-2.53' into merge-2.53-to-main	2 years ago
machine424	70beda092a	fix(notifier): take alertmanagerSet.mtx before checking alertmanagerSet.ams in sendAll Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2 years ago
machine424	690de487e2	chore(notifier): Split 'Run()' into two goroutines: one to receive target updates and trigger reloads and the other one to send notifications. This is done to prevent the latter operation from blocking/starving the former, as previously, the `tsets` channel was consumed by the same goroutine that consumes and feeds the buffered `n.more` channel, the `tsets` channel was less likely to be ready as it's unbuffered and only fed every `SDManager.updatert` seconds. See https://github.com/prometheus/prometheus/issues/13676 and https://github.com/prometheus/prometheus/issues/8768 The synchronization with the sendLoop goroutine is managed through the n.mtx mutex. This uses a similar approach than scrape manager's `efbd6e41c5/scrape/manager.go (L115-L117)` The old TestHangingNotifier was replaced by the new one to more closely reflect reality. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2 years ago
machine424	94d28cd6cf	chore(notifier): add a reproducer for https://github.com/prometheus/prometheus/issues/13676 to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in https://github.com/prometheus/prometheus/pull/10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Ethan Hunter <ehunter@hudson-trading.com>	2 years ago
anarcat	545d31f184	docs: clarify backup requirements for storage (#14297 ) * clarify backup requirements for storage After reading this (again) recently, I was under the impression that our backup strategy ("just throw Bacula at it") was just not good enough and that our backups were inconsistent. I filed [an issue internally][41627] about this because of that concern. But reading a conversation with @SuperQ on IRC, I came under the impression that only the WAL files would be lost. This is an attempt at documenting this more clearly. [41627]: https://gitlab.torproject.org/tpo/tpa/team/-/issues/41627 --------- Signed-off-by: anarcat <anarcat@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com>	2 years ago
Arve Knudsen	be975bf8d7	golangci-lint: Enable loggercheck linter Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2 years ago
Björn Rabenstein	b6ef745016	Merge pull request #14305 from charleskorn/charleskorn/convert-range-query-tests promql: Convert more test cases to test scripting language	2 years ago
Björn Rabenstein	d968408f51	Merge branch 'main' into charleskorn/convert-range-query-tests	2 years ago
George Krajcsovits	4c35b9250a	Merge pull request #14303 from prometheus/prepare-2.53.0-release Prepare 2.53.0 release	2 years ago
Rens Groothuijsen	1c3f322f78	docs: mention implicitly watched directories in documentation (#14019 ) * docs: mention implicitly watched directories in documentation Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> * Add mention of atomic file renaming Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> --------- Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Co-authored-by: Björn Rabenstein <beorn@grafana.com>	2 years ago
George Krajcsovits	29d3e48267	Update CHANGELOG.md Co-authored-by: Julien <291750+roidelapluie@users.noreply.github.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	2 years ago
Oleg Zaytsev	fd1a89b7c8	Pass affected labels to `MemPostings.Delete()` (#14307 ) * Pass affected labels to MemPostings.Delete As suggested by @bboreham, we can track the labels of the deleted series and avoid iterating through all the label/value combinations. This looks much faster on the MemPostings.Delete call. We don't have a benchmark on stripeSeries.gc() where we'll pay the price of iterating the labels of each one of the deleted series. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
Oleg Zaytsev	4f78cc809c	Refactor `toNormalisedLower`: shorter and slightly faster. (#14299 ) Refactor toNormalisedLower: shorter and slightly faster Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
Julien	6572b1fe63	Merge pull request #14306 from pracucci/export-tolabelmatchers Export remote.ToLabelMatchers()	2 years ago
Marco Pracucci	0fbf4a2529	Export remote.ToLabelMatchers() Signed-off-by: Marco Pracucci <marco@pracucci.com>	2 years ago
Charles Korn	aeec30f082	Convert `TestTimestampFunction_StepsMoreOftenThanSamples` Signed-off-by: Charles Korn <charles.korn@grafana.com>	2 years ago
Charles Korn	987fa5c6a2	Convert range query test cases to test scripting language Signed-off-by: Charles Korn <charles.korn@grafana.com>	2 years ago
George Krajcsovits	5efc8dd27b	Merge pull request #14302 from yeya24/fix-check-ctx-cancel-count fix check context cancellation not incrementing count	2 years ago
Ben Ye	0e6fca8e76	add unit test Signed-off-by: Ben Ye <benye@amazon.com>	2 years ago
György Krajcsovits	e121d07388	Prepare release 2.53.0 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2 years ago
Ben Ye	e7db2e30a4	fix check context cancellation not incrementing count Signed-off-by: Ben Ye <benye@amazon.com>	2 years ago
Oleg Zaytsev	4c1e71fa0b	Reduce the flakiness of TestAsyncRuleEvaluation (#14300 ) * Reduce the flakiness of TestAsyncRuleEvaluation This tests sleeps for 15 millisecond per rule group, and then comprares the entire execution time to be smaller than a multiple of that delay. The ruleCount is 6, so it assumes that the test will come to the assertions in less than 90ms. Meanwhile, the Github's Windows runner: - ...Huh, oh? What? How much time? milliwhat? Sorry I don't speak that. TL;DR, this increases the delay to 250 millisecond. This won't prevent the test from being flaky, but will reduce the flakiness by several orders of magnitude and hopefully won't be an issue anymore. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Make tests parallel Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
Oleg Zaytsev	03cf6141d4	Fix Matcher.String() with empty label name When the label name is empty, which can happen now with quoted label name, it should be quoted when printed as a string again. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago

1 2 3 4 5 ...

13078 Commits (2dd07fbb1bfe8ebeca8ea11f4623e0f5faed2236) All Branches Search

13078 Commits (2dd07fbb1bfe8ebeca8ea11f4623e0f5faed2236)

All Branches