prometheus

Commit Graph

Author	SHA1	Message	Date
Lukasz Mierzwa	7d55ee8cc8	Try fixing potential deadlocks in discovery Manager.ApplyConfig() uses multiple locks: - Provider.mu - Manager.targetsMtx Manager.cleaner() uses the same locks but in the opposite order: - First it locks Manager.targetsMtx - The it locks Provider.mu I've seen a few strange cases of Prometheus hanging up on shutdown and never compliting that shutdown. From a few traces I was given it appears that while Prometheus is still running only discovery.Manager and notifier.Manager are running running. From that trace it also seems like they are stuck on a lock from two functions: - cleaner waits on a RLock() - ApplyConfig waits on a Lock() I cannot reproduce it but I suspect this is a race between locks. Imagine this scenario: - Manager.ApplyConfig() is called - Manager.ApplyConfig locks Provider.mu.Lock() - at the same time cleaner() is called on the same Provider instance and it calls Manager.targetsMtx.Lock() - Manager.ApplyConfig() now calls Manager.targetsMtx.Lock() but that lock is already held by cleaner() function so ApplyConfig() hangs there - at the same time cleaner() now wants to lock Provider.mu.Rlock() but that lock is already held by Manager.ApplyConfig() - we end up with both functions locking each other out without any way to break that lock Re-order lock calls to try to avoid this scenario. I tried writing a test case for it but couldn't hit this issue. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	1 year ago
Neeraj Gartia	8b0d33e5b2	promql: support variable scalar parameter in aggregations in range queries (#16404 ) This fixes the regression introduced in https://github.com/prometheus/prometheus/issues/15971 while preserving the performance improvements. Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Neeraj Gartia	591242901a	promql: Refactor some functions to make them more DRY (#16532 ) Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
hardlydearly	ba4b058b7a	refactor: use slices.Contains to simplify code Signed-off-by: hardlydearly <799511800@qq.com>	1 year ago
Julien	59874fd89c	Merge pull request #16478 from KofClubs/range-vector-1001ms promql: function selector sometimes misses a sample on dense samples	1 year ago
George Krajcsovits	f0471ff74b	Merge pull request #16552 from charleskorn/charleskorn/fix-16551 promql: don't emit a value from `histogram_fraction` or `histogram_quantile` if classic and native histograms are present at the same timestamp	1 year ago
dongjiang	2bf6f4c9dc	update fix configuration.md Signed-off-by: dongjiang <dongjiang1989@126.com>	1 year ago
Andre Branchizio	b07b552139	[PERF] TSDB: Pass down label value limit into implementation (#16158 ) * allow limiting label values calls Signed-off-by: Andre Branchizio <andrejbranch@gmail.com>	1 year ago
machine424	ca70ed4fed	test(cmd): add test for GOGC setting As suggested in https://github.com/prometheus/prometheus/pull/14176#issuecomment-2150308054 Signed-off-by: machine424 <ayoubmrini424@gmail.com>	1 year ago
Dimitar Dimitrov	7e49b91d9a	tsdb/errors.MultiError: support errors.As (#16544 ) * tsdb/errors.MultiError: implement Unwrap the multierror was hiding some errors in Mimir. I also added unit tests because I had them handy from a similar change I and yuri did in XXX and some time ago --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Björn Rabenstein	1d847f70c9	Merge pull request #16556 from NeerajGartia21/promql/promql-test-bug [FIX] Promql-test: Fix error message for new eval syntax when `expect` line does not match with regex	1 year ago
George Krajcsovits	2726a18ae3	Merge pull request #16452 from chardch/global-always-scrape-classic-hist Add global config option for always_scrape_classic_histograms	1 year ago
machine424	b59b76639f	chore(scripts/sync_repo_files): add link to source script Signed-off-by: machine424 <ayoubmrini424@gmail.com>	1 year ago
Neeraj Gartia	a177376d72	fix promql-test error message and readme Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
chardch	a1c157aaef	Add global config option for always_scrape_classic_histograms Addresses https://github.com/prometheus/prometheus/issues/16371 This will help with migrating to native histograms with `convert_classic_histograms_to_nhcb` since users may still need to keep the classic histograms during a migration Signed-off-by: chardch <otwordsne@gmail.com>	1 year ago
Charles Korn	2c0f02a702	promql: don't emit a value from `histogram_fraction` or `histogram_quantile` if classic and native histograms are present at the same timestamp Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
dependabot[bot]	c3ce1f1927	chore(deps): bump actions/setup-node from 4.3.0 to 4.4.0 (#16533 ) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](`cdca7365b2...49933ea528`) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 year ago
github-actions[bot]	fc805c1cbd	Merge pull request #16539 from prometheus/dependabot/go_modules/google.golang.org/api-0.231.0 chore(deps): bump google.golang.org/api from 0.230.0 to 0.231.0	1 year ago
github-actions[bot]	504a130722	Merge pull request #16535 from prometheus/dependabot/github_actions/github/codeql-action-3.28.16 chore(deps): bump github/codeql-action from 3.28.13 to 3.28.16	1 year ago
github-actions[bot]	3be2820f8a	Merge pull request #16540 from prometheus/dependabot/go_modules/github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor-0.125.0 chore(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor from 0.124.1 to 0.125.0	1 year ago
github-actions[bot]	f75b08c82b	Merge pull request #16538 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.145.0 chore(deps): bump github.com/digitalocean/godo from 1.144.0 to 1.145.0	1 year ago
github-actions[bot]	1c8da4902f	Merge pull request #16536 from prometheus/dependabot/go_modules/github.com/ionos-cloud/sdk-go/v6-6.3.4 chore(deps): bump github.com/ionos-cloud/sdk-go/v6 from 6.3.3 to 6.3.4	1 year ago
Matthieu MOREL	9d7a37ae18	Bump golangci-lint to v2.1.5 (#16545 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
dependabot[bot]	4685756c8b	chore(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor Bumps [github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib) from 0.124.1 to 0.125.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector-contrib/compare/v0.124.1...v0.125.0) --- updated-dependencies: - dependency-name: github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor dependency-version: 0.125.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	1 year ago
github-actions[bot]	ddb128ecee	Merge pull request #16537 from prometheus/dependabot/go_modules/go-opentelemetry-io-4acf04087c chore(deps): bump the go-opentelemetry-io group across 2 directories with 5 updates	1 year ago
Arve Knudsen	e7e3ab2824	Fix linting issues found by golangci-lint v2.0.2 (#16368 ) * Fix linting issues found by golangci-lint v2.0.2 --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Bryan Boreham	2e9ab9cc62	Merge pull request #16436 from prymitive/slicelabels Use stringlabels by default	1 year ago
Bryan Boreham	ca416c580c	Merge branch 'main' into slicelabels Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
machine424	1a190d3693	chore(cmd): Add info log for automemlimit config Signed-off-by: machine424 <ayoubmrini424@gmail.com>	1 year ago
dependabot[bot]	ae21743906	chore(deps): bump google.golang.org/api from 0.230.0 to 0.231.0 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.230.0 to 0.231.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.230.0...v0.231.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.231.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	1 year ago
dependabot[bot]	874fce920d	chore(deps): bump github.com/digitalocean/godo from 1.144.0 to 1.145.0 Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo) from 1.144.0 to 1.145.0. - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](https://github.com/digitalocean/godo/compare/v1.144.0...v1.145.0) --- updated-dependencies: - dependency-name: github.com/digitalocean/godo dependency-version: 1.145.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	1 year ago
dependabot[bot]	13b07cc145	chore(deps): bump the go-opentelemetry-io group across 2 directories with 5 updates Bumps the go-opentelemetry-io group with 4 updates in the / directory: [go.opentelemetry.io/collector/component](https://github.com/open-telemetry/opentelemetry-collector), [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector), [go.opentelemetry.io/collector/processor](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector). Bumps the go-opentelemetry-io group with 2 updates in the /documentation/examples/remote_storage directory: [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector). Updates `go.opentelemetry.io/collector/component` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/consumer` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/pdata` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/processor` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/semconv` from 0.124.0 to 0.125.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.124.0...v0.125.0) Updates `go.opentelemetry.io/collector/pdata` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/semconv` from 0.124.0 to 0.125.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.124.0...v0.125.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/collector/component dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/consumer dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/pdata dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/processor dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/semconv dependency-version: 0.125.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/pdata dependency-version: 1.31.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/semconv dependency-version: 0.125.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: go-opentelemetry-io ... Signed-off-by: dependabot[bot] <support@github.com>	1 year ago
dependabot[bot]	8058785528	chore(deps): bump github.com/ionos-cloud/sdk-go/v6 from 6.3.3 to 6.3.4 Bumps [github.com/ionos-cloud/sdk-go/v6](https://github.com/ionos-cloud/sdk-go) from 6.3.3 to 6.3.4. - [Release notes](https://github.com/ionos-cloud/sdk-go/releases) - [Changelog](https://github.com/ionos-cloud/sdk-go/blob/master/docs/CHANGELOG.md) - [Commits](https://github.com/ionos-cloud/sdk-go/compare/v6.3.3...v6.3.4) --- updated-dependencies: - dependency-name: github.com/ionos-cloud/sdk-go/v6 dependency-version: 6.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	1 year ago
dependabot[bot]	9dcc160049	chore(deps): bump github/codeql-action from 3.28.13 to 3.28.16 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.13 to 3.28.16. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](`1b549b9259...28deaeda66`) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	1 year ago
Graham Reed	b6aaea22fb	promtool: Optional fuzzy float64 comparison in rules unittests (#16395 ) Make fuzzy compare opt-in via fuzzy_compare boolean in each unittest file. Signed-off-by: Graham Reed <greed@hypervolt.co.uk>	1 year ago
Bryan Boreham	477b55b860	[BUGFIX] Top-level: Update GOGC before loading TSDB (#16491 ) We should use the configured value, or Prometheus' default of 75%, while initializing and loading the WAL. Since the Go default is 100%, most Prometheus users would experience higher memory usage before the value is configured. Also: move Go runtime params earlier in initialization. E.g. if a module starting up looks at GOMAXPROCS to size something, we need to have set it already. --------- Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Ayoub Mrini	0ce6022ef9	Merge pull request #16526 from n-peugnet/docs-clarify-time-options promtool: clarify the docs of --{min,max}-time options	1 year ago
Björn Rabenstein	f5171001d1	Merge pull request #16519 from bboreham/release-3-5-volunteer Volunteer Bryan Boreham as Shepherd for Release 3.5	1 year ago
Ayoub Mrini	a002826865	Merge pull request #16512 from hetznercloud/hetzner-label-selector discovery: add `label_selector` to hetzner service discovery	1 year ago
Bryan Boreham	b2c2146d7c	Labels: simpler/faster stringlabels encoding (#16069 ) Instead of using varint to encode the size of each label, use a single byte for size 0-254, or a flag value of 255 followed by the size in 3 bytes little-endian. This reduces the amount of code, and also the number of branches in commonly-executed code, so it runs faster. The maximum allowed label name or value length is now 2^24 or 16MB. Memory used by labels changes as follows: * Labels from 0 to 127 bytes length: same * From 128 to 254: 1 byte less * From 255 to 16383: 2 bytes more * From 16384 to 2MB: 1 byte more * From 2MB to 16MB: same Labels: panic on string too long. Slightly more user-friendly than encoding bad data and finding out when we decode. Clarify that Labels.Bytes() encoding can change --------- Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Nicolas Peugnet	4eca0942f2	Clarify the docs of promtool --{min,max}-time options State explicitely what kind of timestamps are expected for the --min-time and --max-time options of promtool tsdb commands. This is especially important for the dump-openmetrics command as users could otherwise mistakenly think it would be in seconds, like the OpenMetrics timestamps themselves. Signed-off-by: Nicolas Peugnet <nicolas.peugnet@lip6.fr>	1 year ago
Jonas Lammler	08982b177f	Add `label_selector` to hetzner service discovery Allows to filter the servers when sending the listing request to the API. This feature is only available when using the `role=hcloud`. See https://docs.hetzner.cloud/#label-selector for details on how to use the label selector. Signed-off-by: Jonas Lammler <jonas.lammler@hetzner-cloud.de>	1 year ago
Bryan Boreham	3877f5829e	Volunteer Bryan Boreham as Shepherd for Release 3.5 Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Jan-Otto Kröpke	7789ef27c8	Upgraded npm dependencies pre 3.4.0-rc.0 (#16493 )	1 year ago
Jan-Otto Kröpke	46f1389ce7	[BUILD] Remove Go toolchain line in internal/tools (#16516 )	1 year ago
github-actions[bot]	2626e0f6cb	Merge pull request #16508 from prometheus/dependabot/go_modules/documentation/examples/remote_storage/github.com/prometheus/client_golang-1.22.0 chore(deps): bump github.com/prometheus/client_golang from 1.21.1 to 1.22.0 in /documentation/examples/remote_storage	1 year ago
github-actions[bot]	c0f717a862	Merge pull request #16505 from prometheus/dependabot/go_modules/google.golang.org/grpc-1.72.0 chore(deps): bump google.golang.org/grpc from 1.71.1 to 1.72.0	1 year ago
github-actions[bot]	82553772f2	Merge pull request #16502 from prometheus/dependabot/go_modules/google.golang.org/api-0.230.0 chore(deps): bump google.golang.org/api from 0.229.0 to 0.230.0	1 year ago
github-actions[bot]	ea945cccb4	Merge pull request #16499 from prometheus/dependabot/go_modules/github.com/prometheus/client_golang-1.22.0 chore(deps): bump github.com/prometheus/client_golang from 1.21.1 to 1.22.0	1 year ago
github-actions[bot]	89cacd8878	Merge pull request #16507 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.144.0 chore(deps): bump github.com/digitalocean/godo from 1.142.0 to 1.144.0	1 year ago

1 2 3 4 5 ...

15637 Commits (7d55ee8cc8f6ee81935c28ecc2de75a7293100ff) All Branches Search

15637 Commits (7d55ee8cc8f6ee81935c28ecc2de75a7293100ff)

All Branches