prometheus

Commit Graph

Author	SHA1	Message	Date
Bartlomiej Plotka	d10d3df345	Merge pull request #17679 from bboreham/remove-labelvaluefor [CHORE] TSDB: Remove unused LabelValueFor function	3 days ago
Bryan Boreham	41665a4a55	[CHORE] TSDB: Remove unused LabelValueFor function The last use of this was removed 4 years ago. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 days ago
Rushabh Mehta	c2b86775b6	scrape: Fix potential goroutine leak in scrapeAndReport (#17554 ) * [scrape] Fix potential goroutine leak in scrape loop Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com> * Use correct error var Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com> * Add regression test Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com> --------- Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com>	3 days ago
Bryan Boreham	583bc01cc9	Refactor: TSDB: small improvement to Postings (#17661 ) * [TESTS] TSDB: Check that ListPostings are sorted `newListPostings` is a convenient place to do this; move it into the test file because it's not needed for anything else. Also simplify the existing `SliceIsSorted` check. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * [COMMENTS] TSDB: Document that Postings are ordered. The description of `Seek()` implies they are, but it's better to be explicit. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * [REFACTOR] Unexport ListPostings type It's only used within the one package, and it would be surprising if some downstream code did rely on this type, given all of its members are unexported. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> --------- Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	4 days ago
Hélia Barroso	952efe77ad	Merge pull request #17667 from heliapb/fix/changelog fix: add correct pr in unified AWS SD in prometheus changelog	4 days ago
Bartlomiej Plotka	285e6891ec	Merge pull request #17663 from prometheus/bwplotka-patch-7 docs: Add krajorama as TSDB maintainer	4 days ago
Julius Volz	19b794579b	Merge pull request #17668 from prometheus/fix-cmpop-many-to-one-tracking PromQL: Fix insufficient cardinality checking for filter ops	5 days ago
Julius Volz	4cad87cae8	PromQL: Fix insufficient cardinality checking for filter ops Generally, binary operations between two vectors fail if there is a many-to-one or one-to-many matching situation between series within a match group and no `group_left()` or `group_right()` modifier is present. For filter ops this is also generally the case, but there can be situations where multiple series on one side can match a single series on the other side, but only 0 or 1 of those multiple series remains after the filter operator has been applied. In this case, the PromQL engine does not produce a matching error, since it only tracks series matching for those series that survive the filtering. IMO this is incorrect behavior (which can also erratically make a query sometimes fail and sometimes succeed, depending on current sample values), and we should always produce an error if there is a match error prior to applying the filter op. This PR ensures that we do the cardinality / match tracking independently of the result of the filter operation. Signed-off-by: Julius Volz <julius.volz@gmail.com>	5 days ago
Julien	f73aba34cd	Merge pull request #17427 from roidelapluie/roidelapluie/ffapi API: Add a /api/v1/features endpoint	5 days ago
Julien Pivotto	a5671a002f	API: Add a /api/v1/features endpoint Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	6 days ago
Julien	e77dd5bec2	Merge pull request #17647 from roidelapluie/roidelapluie/resource-limit-fix web/api: Add maximum limit validation to TSDB status endpoint	6 days ago
Julien Pivotto	5b26619565	web/api: Add maximum limit validation to TSDB status endpoint Add a maximum limit of 10,000 to the TSDB status endpoint to prevent resource exhaustion from excessively large limit values, as we preallocate []Stat for up to the limit: `make([]Stat, 0, length)`. Note that the endpoint acquires a cardinality mutex during stats calculation, so this can not be run in parallel. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	6 days ago
Bartlomiej Plotka	be419d80dc	Merge pull request #17629 from prometheus/bwplotka/a2-tsdb refactor(appenderV2)[PART1]: add AppenderV2 interface; add TSDB AppenderV2 implementation	6 days ago
Bartlomiej Plotka	a1fcac9078	maintainers: Add krajoma as TSDB maintainer This is to help with interface switch we are doing https://github.com/prometheus/prometheus/issues/17632 See https://cloud-native.slack.com/archives/C01AUBA4PFE/p1765277201832839?thread_ts=1765199584.855979&cid=C01AUBA4PFE Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	6 days ago
bwplotka	e7e45090e4	refactor(appenderV2): port TSDB non-head tests Signed-off-by: bwplotka <bwplotka@gmail.com>	6 days ago
bwplotka	0b70a07572	refactor(appenderV2): add TSDB AppenderV2 implementation Signed-off-by: bwplotka <bwplotka@gmail.com> tmp Signed-off-by: bwplotka <bwplotka@gmail.com>	6 days ago
bwplotka	a41e1144dd	refactor(appenderV2): 1:1 copy of db_test.go to db_append_v2_test.go (starting point) Signed-off-by: bwplotka <bwplotka@gmail.com>	6 days ago
bwplotka	efdfb8fed6	refactor(appenderV2): 1:1 copy of head append test files for v2 (starting point) Signed-off-by: bwplotka <bwplotka@gmail.com>	6 days ago
bwplotka	129650df9d	refactor(appenderV2): 1:1 copy of head_append.go -> head_append_v2.go (starting point) Signed-off-by: bwplotka <bwplotka@gmail.com>	6 days ago
bwplotka	04696703fe	refactor(appenderV2): add AppenderV2 interface Signed-off-by: bwplotka <bwplotka@gmail.com>	6 days ago
Julius Volz	a4ed100874	Merge pull request #17657 from intojhanurag/discovery/unregister-refresh-metrics discovery: Add ability to unregister refresh metrics in tests	6 days ago
intojhanurag	1ccc0fed81	Revert triton_test.go and kuma_test.go to main version Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	7 days ago
intojhanurag	ea072fd56a	Added cleanup closure in kuma test Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	7 days ago
intojhanurag	0251e888f9	Refactor Triton tests to simplify metrics cleanup using cleanup closure Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	7 days ago
intojhanurag	025628f272	unregistering RefreshMetrics instances Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	1 week ago
dongjiang	3239723098	Update golangci-lint and add modernize check (#17640 ) * add modernize check Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix golangci lint Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com>	1 week ago
Julien	0279e14d4a	Merge pull request #17636 from roidelapluie/roidelapluie/starttime Add start_timestamp field for unit tests	2 weeks ago
Julien Pivotto	4620c8ac71	Simplify StartTime assignment in unit test setup. Remove redundant IsZero check since promqltest.LazyLoader already handles zero StartTime by defaulting to Unix epoch. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2 weeks ago
Jan Fajerski	ac5bdd66d7	Merge pull request #17634 from jan--f/sync-release-3.8 Sync branch release-3.8	2 weeks ago
Julius Volz	22b3860e2a	Merge pull request #17643 from prometheus/fix-empty-ignoring-serialization Fix serialization for empty `ignoring()` in combination with `group_x()`	2 weeks ago
Julius Volz	39e11f50b2	Fix serialization for empty `ignoring()` in combination with `group_x()` Currently both the backend and frontend printers/formatters/serializers incorrectly transform the following expression: ``` up * ignoring() group_left(__name__) node_boot_time_seconds ``` ...into: ``` up * node_boot_time_seconds ``` ...which yields a different result (including the metric name in the result vs. no metric name). We need to keep empty `ignoring()` modifiers if there is a grouping modifier present. Signed-off-by: Julius Volz <julius.volz@gmail.com>	2 weeks ago
Julien Pivotto	1a853e23db	Add start_timestamp field for unit tests. This commit adds support for configuring a custom start timestamp for Prometheus unit tests, allowing tests to use realistic timestamps instead of starting at Unix epoch 0. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2 weeks ago
Bartlomiej Plotka	f6ca7145ca	refactor(tsdb): use one test newTestDB constructor (#17638 ) For tests only, we had various ways of opening DB. Reduced to one instead of: * Open * newTestDB * newTestDBOpts * openTestDB This so https://github.com/prometheus/prometheus/pull/17629 is smaller and bit easier. Also for test maintainability and consistency. Signed-off-by: bwplotka <bwplotka@gmail.com>	2 weeks ago
Gabriel Filion	9f0b52d73a	docs: Describe how time() is set to start at 0 in unit tests The return value of functions relating to the current time, e.g. time(), is set by promtool to start at timestamp 0 at the start of a test's evaluation. This has the very nice consequence that tests can run reliably without depending on when they are run. It does, however, mean that tests will give out results that can be unexpected by users. If this behaviour is documented, then users will be empowered to write tests for their rules that use time-dependent functions. (Closes: prometheus/docs#1464) Signed-off-by: Gabriel Filion <lelutin@torproject.org>	2 weeks ago
Julien	93edf912a7	Merge pull request #17630 from zjumathcode/main chore: Fix function name typo in createBatchSpan comment	2 weeks ago
Jan Fajerski	fae20b73ff	Merge branch 'release-3.8' into sync-release-3.8 Conflicts: storage/remote/write_handler.go storage/remote/write_handler_test.go Pick `main` Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2 weeks ago
Ben Edmunds	0e682a70a6	RW2: Allow custom scope in azuread (#17483 ) Signed-off-by: Ben Edmunds <sammybenblue2@gmail.com>	2 weeks ago
Łukasz Mierzwa	8a1086a128	feat: Add flag that blocks lvl 1 compactions until upload is confirmed in an external JSON file (#17435 ) * Delay compactions until Thanos uploads all blocks Using Thanos sidecar with Prometheus requires us to disable TSDB compactions on Prometheus side by setting --storage.tsdb.min-block-duration and --storage.tsdb.max-block-duration to the same value. See https://thanos.io/tip/components/sidecar.md. The main problem this avoids is that Prometheus might compact given block before Thanos uploads it, creating a gap in Thanos metrics. Thanos does not upload compacted blocks because that would upload the same sample multiple times. You can tell Thanos to upload compacted blocks but that is aimed at one time migrations. This patch creates a bridge between Thanos and Prometheus by allowing Prometheus to read the shipper file Thanos creates, where it tracks which blocks were already uploaded, and using that data delays compaction of blocks until they are marked as uploaded by Thanos. Thanks to this both services can coordinate with each other (in a way) and we can stop disabling compaction on Prometheus side when Thanos uploads are enabled. The reason to have this is that disabling compactions have very dramatic performance cost. Since most time series exist for longer than a single block duration (2h by default) large chunks of block index will reference the same series, so 10 * 2h blocks will each have an index that is usually fairly big and is almost the same for all 10 blocks. Compaction de-duplicates the index so merging 10 blocks together would leave us with a single index that is around the same size as each of these 10 2h blocks would have (plus some extra for series that only exists in some blocks, but not all). Every range query that iterates over all 10 blocks would then have to read each index and so we're doing 10x more work then if we had a single compacted block. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> * Rename structs and functions to make this more generic Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> * Address review comments Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> * Cache UploadMeta for 1 minute Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> --------- Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	2 weeks ago
Jan Fajerski	e44ed351cd	Merge pull request #17623 from jan--f/prep-rel-3.8.0 prepare release v3.8.0	2 weeks ago
zjumathcode	0ac2221a20	chore: Fix function name typo in createBatchSpan comment Signed-off-by: zjumathcode <pai314159@2980.com>	2 weeks ago
Jan Fajerski	73b1fda131	prepare release v3.8.0 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2 weeks ago
Nikos Angelopoulos	b0649e08c4	rules: replace error strings with sentinel errors for duplicate labelsets (#17620 ) Signed-off-by: Nikos Angelopoulos <nikolaos.angelopoulos@grafana.com>	2 weeks ago
Julius Volz	96d3d641e3	Merge pull request #17605 from ADITYATIWARI342005/fix/CompSugg [BUGFIX] UI :Suppress duration unit autocomplete when unit already present in query selector	2 weeks ago
Solomon Jacobs	abffb92847	drop GO111MODULE=on (#17520 ) This is ignored as of go 1.17, see e.g., for reference https://go.dev/blog/go116-module-changes Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>	2 weeks ago
harsh kumar	30be1483d1	instrumentation: add native histograms to complement high-traffic summaries (#17374 ) This adds the following native histograms (with a few classic buckets for backwards compatibility), while keeping the corresponding summaries (same name, just without `_histogram`): - `prometheus_sd_refresh_duration_histogram_seconds` - `prometheus_rule_evaluation_duration_histogram_seconds` - `prometheus_rule_group_duration_histogram_seconds` - `prometheus_target_sync_length_histogram_seconds` - `prometheus_target_interval_length_histogram_seconds` - `prometheus_engine_query_duration_histogram_seconds` Signed-off-by: Harsh <harshmastic@gmail.com> Signed-off-by: harsh kumar <135993950+hxrshxz@users.noreply.github.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	2 weeks ago
ADITYA TIWARI	49427cfcd2	Refactor duration regex and remove RegExp.escape polyfill Removed polyfill for RegExp.escape and updated duration regex. Signed-off-by: ADITYA TIWARI <142050150+ADITYATIWARI342005@users.noreply.github.com>	3 weeks ago
Andrew Hall	7bb95d548c	promql: Ensure that `rate`/`increase`/`delta` of histograms results in a gauge histogram. (#17608 ) Signed-off-by: Andrew Hall <andrew.hall@grafana.com>	3 weeks ago
Ayoub Mrini	e7999528fa	fix(test): make TestRemoteWrite_ReshardingWithoutDeadlock more reliable and re-enable it (#17490 ) Improve test stability by waiting for the relevant metrics to appear on /metrics before the first check on the desired shard count. Increase the scrape interval to avoid timeouts, as 100 ms may be insufficient for Prometheus to scrape itself in some environments (e.g., CI). Have Prometheus scrape itself multiple times to increase the volume of data sent and help fill the queue more quickly. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	3 weeks ago
ADITYA TIWARI	42418660d3	fix: lint errors in the files; move regex to one-line only Signed-off-by: ADITYA TIWARI <adityatiwari342005@gmail.com>	3 weeks ago
ADITYA TIWARI	4fa435fad2	feat: use RegExp.escape polyfill for robust PromQL duration regex; add compound duration test cases Signed-off-by: ADITYA TIWARI <adityatiwari342005@gmail.com>	3 weeks ago

1 2 3 4 5 ...

16563 Commits (d10d3df34522811f01a281680f4331234811d00d) All Branches Search

16563 Commits (d10d3df34522811f01a281680f4331234811d00d)

All Branches