Improves UI for ldap error messages

7 years ago · 1712368f6a
parent d7529bf6b5
commit 1712368f6a
3 changed files with 34 additions and 15 deletions
--- a/client/components/main/layouts.js
+++ b/client/components/main/layouts.js
@ -121,20 +121,35 @@ function authentication(instance, email, password) {
    return this.stop();
  }

-  const authenticationMethod = user ? 
-    user.authenticationMethod :
-    instance.data.defaultAuthenticationMethod.get();
+  const authenticationMethod = user
+    ? user.authenticationMethod
+    : instance.data.defaultAuthenticationMethod.get();

-  // Authentication with LDAP
-  if (authenticationMethod === 'ldap') {
+  switch (authenticationMethod) {
+    case 'ldap':
      // Use the ldap connection package
      Meteor.loginWithLDAP(email, password, function(error) {
-      if (!error) {
-        return FlowRouter.go('/');
-      }
-      return error;
+        if (!error) return FlowRouter.go('/');
+        displayError('error-ldap-login');
      });
+      break;
+
+    default:
+      displayError('error-undefined');
  }

  return this.stop();
 }
+
+function displayError(code) {
+  const translated = TAPi18n.__(code);
+
+  if (translated === code) {
+    return;
+  }
+
+  if(!$('.at-error').length) {
+    $('.at-pwd-form').before('<div class="at-error"><p></p></div>');
+  }
+  $('.at-error p').text(translated);
+}
--- a/i18n/en.i18n.json
+++ b/i18n/en.i18n.json
@ -620,5 +620,7 @@
    "layout": "Layout",
    "hide-logo": "Hide Logo",
    "add-custom-html-after-body-start": "Add Custom HTML after <body> start",
-    "add-custom-html-before-body-end": "Add Custom HTML before </body> end"
+    "add-custom-html-before-body-end": "Add Custom HTML before </body> end",
+    "error-undefined": "Something went wrong",
+    "error-ldap-login": "An error occurred while trying to login"
 }
--- a/i18n/fr.i18n.json
+++ b/i18n/fr.i18n.json
@ -619,5 +619,7 @@
    "layout": "Interface",
    "hide-logo": "Cacher le logo",
    "add-custom-html-after-body-start": "Add Custom HTML after <body> start",
-    "add-custom-html-before-body-end": "Add Custom HTML before </body> end"
+    "add-custom-html-before-body-end": "Add Custom HTML before </body> end",
+    "error-undefined": "Une erreur inconnue s'est produite",
+    "error-ldap-login": "Une erreur s'est produite lors de la tentative de connexion"
 }