Scrutinizer Auto-Fixes

This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

custompages/language.inc.php

@@ -28,7 +28,7 @@ function get_preferred_language($available_langs) {
     }
     krsort($langs, SORT_NUMERIC);
     // Choosing the best match
-    foreach($langs as $weight => $codes) {
+    foreach ($langs as $weight => $codes) {
 		foreach ($codes as $code) {
         	if (in_array($code, $available_langs)) {
             	return $code;

main/auth/ldap/login.php

@@ -31,7 +31,7 @@ if ($loginLdapSucces) {
 	$loginFailed = false;
 	$uidReset = true;
 	$_user['user_id'] = $uData['user_id'];
-	Session::write('_uid',$_uid);
+	Session::write('_uid', $_uid);
     // Jand: copied from event_login in events.lib.php to enable login statistics:
 	Event::event_login($uData['user_id']);
 } else {

main/document/document_slideshow.inc.php

@@ -71,7 +71,7 @@ $_SESSION['image_files_only'] = $image_files_only;
 function sort_files($table)
 {
     $tablename_direction = isset($_GET['tablename_direction']) ? Security::remove_XSS($_GET['tablename_direction']) : 'ASC';
-    $accepted_extensions = array('.jpg', '.jpeg', '.gif', '.png', '.bmp','.svg');
+    $accepted_extensions = array('.jpg', '.jpeg', '.gif', '.png', '.bmp', '.svg');
     $temp = array();
 
     foreach ($table as & $file_array) {

main/inc/lib/event_email_template.class.php

@@ -44,7 +44,7 @@ class EventEmailTemplate extends Model
 		// action links
 		$content = Display::actions(array(
                 array(
-                    'url' => 'event_type.php' ,
+                    'url' => 'event_type.php',
                     'content' => Display::return_icon(
                         'new_document.png',
                         get_lang('Add'),
@@ -132,7 +132,7 @@ class EventEmailTemplate extends Model
 
     public function get_count()
     {
-        $row = Database::select('count(*) as count', $this->table, array(),'first');
+        $row = Database::select('count(*) as count', $this->table, array(), 'first');
 
         return $row['count'];
     }

main/inc/lib/gradebook.lib.php

@@ -194,7 +194,7 @@ class Gradebook extends Model
         $selected_skills = self::get_skills_by_gradebook($gradebook_id);
         $clean_selected_skills = array();
         if (!empty($selected_skills)) {
-            foreach($selected_skills as $skill) {
+            foreach ($selected_skills as $skill) {
                 $clean_selected_skills[] = $skill['id'];
             }
         }

main/lp/scormItem.class.php

@@ -100,7 +100,7 @@ class scormItem extends learnpathItem
                                         }
                                         break;
                                     case 'item':
-                                        $oItem = new scormItem('manifest',$child);
+                                        $oItem = new scormItem('manifest', $child);
                                         if ($oItem->identifier != '') {
                                             $this->sub_items[$oItem->identifier] = $oItem;
                                         }
@@ -119,7 +119,7 @@ class scormItem extends learnpathItem
                         $attributes = $element->attributes;
                         //$keep_href = '';
                         foreach ($attributes as $attrib) {
-                            switch($attrib->name){
+                            switch ($attrib->name) {
                                 case 'identifier':
                                     $this->identifier = $attrib->value;
                                     break;
@@ -172,8 +172,8 @@ class scormItem extends learnpathItem
         );
         $abs_order++;
         $i = 1;
-        foreach($this->sub_items as $id => $dummy) {
-            $oSubitem =& $this->sub_items[$id];
+        foreach ($this->sub_items as $id => $dummy) {
+            $oSubitem = & $this->sub_items[$id];
             $oSubitem->get_flat_list($list, $abs_order, $i, $level + 1);
             $i++;
         }
@@ -188,7 +188,7 @@ class scormItem extends learnpathItem
         parent::save($from_outside, $prereqs_complete);
         // Under certain conditions, the scorm_contact should not be set, because no scorm signal was sent.
         $this->scorm_contact = true;
-        if (!$this->scorm_contact){
+        if (!$this->scorm_contact) {
             //error_log('New LP - was expecting SCORM message but none received', 0);
         }
     }

main/lp/scormMetadata.class.php

@@ -88,7 +88,7 @@ class scormMetadata
                      //$keep_href = '';
                      if (is_array($attributes)) {
                          foreach ($attributes as $attrib) {
-                             if (trim($attrib->value) != ''){
+                             if (trim($attrib->value) != '') {
                                  $this->attribs[$attrib->name] = $attrib->value;
                              }
                          }

main/lp/scormOrganization.class.php

@@ -98,7 +98,7 @@ class scormOrganization
         foreach ($this->items as $id => $dummy) {
             $abs_order = 0;
             // Passes the array as a pointer so it is modified in $list directly.
-            $this->items[$id]->get_flat_list($list,$abs_order, $i, 0);
+            $this->items[$id]->get_flat_list($list, $abs_order, $i, 0);
             $i++;
         }
 

main/lp/scormResource.class.php

@@ -69,7 +69,7 @@ class scormResource
                         }
                     }
                     //$keep_href = '';
-                    if ($element->hasAttributes()){ //in some cases we get here with an empty attributes array
+                    if ($element->hasAttributes()) { //in some cases we get here with an empty attributes array
                         // TODO: Find when and why we get such a case (empty array).
                         $attributes = $element->attributes;
                         foreach ($attributes as $attrib) {

plugin/add_cas_logout_button/index.php

@@ -14,7 +14,7 @@ if (!api_is_anonymous() &&
         $logout_label = api_htmlentities($plugin_info['settings']['add_cas_logout_button_cas_logout_label']);
     }
     // the comm
-    $logout_comment = api_htmlentities($plugin_info['settings']['add_cas_logout_button_cas_logout_comment']);;
+    $logout_comment = api_htmlentities($plugin_info['settings']['add_cas_logout_button_cas_logout_comment']); ;
     // URL of the image
     $logout_image_url = $plugin_info['settings']['add_cas_logout_button_cas_logout_image_url'];
 

plugin/add_shibboleth_login_button/index.php

@@ -11,7 +11,7 @@ if (api_is_anonymous()) {
         $button_label = api_htmlentities($plugin_info['settings']['add_shibboleth_login_button_shibboleth_button_label']);
     }
     // the comm
-    $comm_label = api_htmlentities($plugin_info['settings']['add_shibboleth_login_button_shibboleth_button_comment']);;
+    $comm_label = api_htmlentities($plugin_info['settings']['add_shibboleth_login_button_shibboleth_button_comment']); ;
     // URL of the image
     $url_label = $plugin_info['settings']['add_shibboleth_login_button_shibboleth_image_url'];
     

plugin/customfooter/index.php

@@ -4,7 +4,7 @@
  */
 
 if (isset($plugin_info['current_region'])) {
-    switch($plugin_info['current_region']) {
+    switch ($plugin_info['current_region']) {
         case 'footer_left':
             echo $plugin_info['settings']['customfooter_footer_left'];
             break;

src/Chamilo/CoreBundle/Component/Editor/CkEditor/Toolbar/Documents.php

@@ -109,7 +109,7 @@ class Documents extends Basic
             ],
             ['BulletedList', 'NumberedList', 'HorizontalRule'],
             ['JustifyLeft', 'JustifyCenter', 'JustifyBlock'],
-            [   'Styles',
+            ['Styles',
                 'Format',
                 'Font',
                 'FontSize',

src/Chamilo/CoreBundle/Component/Editor/CkEditor/Toolbar/Wiki.php

@@ -56,11 +56,11 @@ class Wiki extends Basic
                 '-',
                 'Find'
             ],
-            ['Wikilink','Link','Unlink','Anchor'],
-            ['Image','Video','Flash','Oembed','Youtube','Audio','Asciimath'],
-            ['Table','HorizontalRule','Smiley','SpecialChar','leaflet'],
-            ['Format','Font','FontSize'],
-            ['Bold','Italic','Underline'],
+            ['Wikilink', 'Link', 'Unlink', 'Anchor'],
+            ['Image', 'Video', 'Flash', 'Oembed', 'Youtube', 'Audio', 'Asciimath'],
+            ['Table', 'HorizontalRule', 'Smiley', 'SpecialChar', 'leaflet'],
+            ['Format', 'Font', 'FontSize'],
+            ['Bold', 'Italic', 'Underline'],
             [
                 'Subscript',
                 'Superscript',
@@ -97,7 +97,7 @@ class Wiki extends Basic
             ['Wikilink', 'Link', 'Image', 'Video', 'Flash', 'Audio', 'Table', 'Asciimath', 'Asciisvg'],
             ['BulletedList', 'NumberedList', 'HorizontalRule'],
             ['JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock'],
-            ['Styles','Format', 'Font', 'FontSize', 'Bold', 'Italic', 'Underline', 'TextColor', 'BGColor', 'Source'],
+            ['Styles', 'Format', 'Font', 'FontSize', 'Bold', 'Italic', 'Underline', 'TextColor', 'BGColor', 'Source'],
             api_get_setting('enabled_wiris') == 'true' ? ['ckeditor_wiris_formulaEditor', 'ckeditor_wiris_CAS'] : [''],
             ['Toolbarswitch']
         ];

src/Chamilo/CourseBundle/Component/CourseCopy/Resources/Announcement.php

@@ -59,7 +59,7 @@ class Announcement extends Resource
         $size,
         $comment
     ) {
-        parent::__construct($id,RESOURCE_ANNOUNCEMENT);
+        parent::__construct($id, RESOURCE_ANNOUNCEMENT);
 
         $this->content = $content;
         $this->title = $title;

src/Chamilo/CourseBundle/Component/CourseCopy/Resources/CourseCopyLearnpath.php

@@ -155,18 +155,18 @@ class CourseCopyLearnpath extends Resource
 		$this->js_lib = $js_lib;
 		$this->content_license = $content_license;
 		$this->debug = $debug;
-		$this->visibility=$visibility;
+		$this->visibility = $visibility;
 
-		$this->use_max_score=$use_max_score;
-		$this->autolaunch=$autolaunch;
-		$this->created_on=$created_on;
-		$this->modified_on=$modified_on;
-		$this->publicated_on=$publicated_on;
-		$this->expired_on=$expired_on;
-		$this->session_id=$session_id;
+		$this->use_max_score = $use_max_score;
+		$this->autolaunch = $autolaunch;
+		$this->created_on = $created_on;
+		$this->modified_on = $modified_on;
+		$this->publicated_on = $publicated_on;
+		$this->expired_on = $expired_on;
+		$this->session_id = $session_id;
 
-		$this->author= $author;
-		$this->preview_image= $preview_image;
+		$this->author = $author;
+		$this->preview_image = $preview_image;
 
 		$this->items = $items;
 	}

src/Chamilo/ThemeBundle/Controller/BreadcrumbController.php

@@ -58,7 +58,7 @@ class BreadcrumbController extends Controller {
         $list = array();
         if ($active) {
             $list[] = $active;
-            while(null !== ($item = $active->getActiveChild())) {
+            while (null !== ($item = $active->getActiveChild())) {
                 $list[] = $item;
                 $active = $item;
             }

src/Chamilo/ThemeBundle/Controller/DefaultController.php

@@ -43,7 +43,7 @@ class DefaultController extends Controller
     }
 
     public function formAction() {
-        $form =$this->createForm( new FormDemoModelType());
+        $form = $this->createForm(new FormDemoModelType());
         return $this->render('ChamiloThemeBundle:Default:form.html.twig', array(
                 'form' => $form->createView()
             ));

src/Chamilo/ThemeBundle/Event/SidebarMenuEvent.php

@@ -74,9 +74,9 @@ class SidebarMenuEvent extends ThemeEvent
      */
     public function getActive() {
 
-        foreach($this->getItems() as $item) {
+        foreach ($this->getItems() as $item) {
             /** @var $item MenuItemInterface */
-            if($item->isActive()) return $item;
+            if ($item->isActive()) return $item;
         }
         return null;
     }

src/Chamilo/ThemeBundle/Event/TaskListEvent.php

@@ -30,7 +30,7 @@ class TaskListEvent extends ThemeEvent {
      *
      * @return $this
      */
-    public function addTask(TaskInterface $taskInterface){
+    public function addTask(TaskInterface $taskInterface) {
         $this->tasks[] = $taskInterface;
         return $this;
     }

src/Chamilo/ThemeBundle/EventListener/NavbarMessageListDemoListener.php

@@ -16,15 +16,15 @@ class NavbarMessageListDemoListener {
 
     public function onListMessages(MessageListEvent $event) {
 
-        foreach($this->getMessages() as $msg) {
+        foreach ($this->getMessages() as $msg) {
             $event->addMessage($msg);
         }
     }
 
     protected function getMessages() {
         return array(
-            new MessageModel(new UserModel('Karl kettenkit'),'Dude! do something!', new \DateTime('-3 days')),
-            new MessageModel(new UserModel('Jack Trockendoc'),'This is some subject', new \DateTime('-10 month')),
+            new MessageModel(new UserModel('Karl kettenkit'), 'Dude! do something!', new \DateTime('-3 days')),
+            new MessageModel(new UserModel('Jack Trockendoc'), 'This is some subject', new \DateTime('-10 month')),
         );
     }
 

src/Chamilo/ThemeBundle/EventListener/NavbarNotificationListDemoListener.php

@@ -16,7 +16,7 @@ class NavbarNotificationListDemoListener {
 
     public function onListNotifications(NotificationListEvent $event) {
 
-        foreach($this->getNotifications() as $notify){
+        foreach ($this->getNotifications() as $notify) {
             $event->addNotification($notify);
         }
 

src/Chamilo/ThemeBundle/EventListener/NavbarTaskListDemoListener.php

@@ -17,7 +17,7 @@ class NavbarTaskListDemoListener
     public function onListTasks(TaskListEvent $event)
     {
 
-        foreach($this->getTasks() as $task) {
+        foreach ($this->getTasks() as $task) {
             $event->addTask($task);
         }
 

src/Chamilo/ThemeBundle/EventListener/SidebarSetupMenuDemoListener.php

@@ -45,12 +45,12 @@ class SidebarSetupMenuDemoListener
 
     protected function activateByRoute($route, $items) {
 
-        foreach($items as $item) { /** @var $item MenuItemModel */
-            if($item->hasChildren()) {
+        foreach ($items as $item) { /** @var $item MenuItemModel */
+            if ($item->hasChildren()) {
                 $this->activateByRoute($route, $item->getChildren());
             }
             else {
-                if($item->getRoute() == $route) {
+                if ($item->getRoute() == $route) {
                     $item->setIsActive(true);
                 }
             }

src/Chamilo/ThemeBundle/Form/FormDemoModelType.php

@@ -34,7 +34,7 @@ class FormDemoModelType extends AbstractType
                 ->add('someChoices', 'choice', array('choices' => $choices, 'expanded' => true, 'multiple' => true))
                 ->add('username')
                 ->add('email')
-                ->add('termsAccepted','checkbox')
+                ->add('termsAccepted', 'checkbox')
                 ->add('message', 'textarea')
                 ->add('price')
                 ->add('date', 'date', array('widget' => 'single_text'))

src/Chamilo/ThemeBundle/Model/MessageModel.php

@@ -51,11 +51,11 @@ class MessageModel implements MessageInterface
      * @param null          $sentAt
      * @param UserInterface $to
      */
-    function __construct(UserInterface $from = null, $subject= '', $sentAt = null, UserInterface $to = null)
+    function __construct(UserInterface $from = null, $subject = '', $sentAt = null, UserInterface $to = null)
     {
         $this->to      = $to;
         $this->subject = $subject;
-        $this->sentAt  = $sentAt ? : new \DateTime();
+        $this->sentAt  = $sentAt ?: new \DateTime();
         $this->from    = $from;
     }
 

src/Chamilo/ThemeBundle/Model/UserModel.php

@@ -31,11 +31,11 @@ class UserModel implements UserInterface
      */
     protected $isOnline = false;
 
-    function __construct($username='', $avatar = '', $memberSince = null, $isOnline = true)
+    function __construct($username = '', $avatar = '', $memberSince = null, $isOnline = true)
     {
         $this->avatar      = $avatar;
         $this->isOnline    = $isOnline;
-        $this->memberSince = $memberSince ?:new \DateTime();
+        $this->memberSince = $memberSince ?: new \DateTime();
         $this->username    = $username;
     }
 

src/Chamilo/ThemeBundle/Theme/ThemeManager.php

@@ -36,7 +36,7 @@ class ThemeManager
     function __construct($container, $resolverClass = null)
     {
         $this->container     = $container;
-        $this->resolverClass = $resolverClass?: 'Chamilo\ThemeBundle\Util\DependencyResolver';
+        $this->resolverClass = $resolverClass ?: 'Chamilo\ThemeBundle\Util\DependencyResolver';
     }
 
     public function registerScript($id, $src, $deps = array(), $location = "bottom")
@@ -54,7 +54,7 @@ class ThemeManager
 
     public function registerStyle($id, $src, $deps = array())
     {
-        if(!isset($this->stylesheets[$id])) {
+        if (!isset($this->stylesheets[$id])) {
             $this->stylesheets[$id] = array(
                 'src'      => $src,
                 'deps'     => $deps,
@@ -66,14 +66,14 @@ class ThemeManager
     {
 
         $unsorted = array(); $srcList = array(); $assetList = array();
-        foreach($this->javascripts as $id => $scriptDefinition) {
-            if($scriptDefinition['location'] == $location) {
+        foreach ($this->javascripts as $id => $scriptDefinition) {
+            if ($scriptDefinition['location'] == $location) {
                 $unsorted[$id] = $scriptDefinition;
             }
         }
 
         $queue = $this->getResolver()->register($unsorted)->resolveAll();
-        foreach($queue as $def) {
+        foreach ($queue as $def) {
             $srcList[] = $def['src'];
         }
         return $srcList;
@@ -83,7 +83,7 @@ class ThemeManager
     {
         $srcList = array();
         $queue = $this->getResolver()->register($this->stylesheets)->resolveAll();
-        foreach($queue as $def) {
+        foreach ($queue as $def) {
             $srcList[] = $def['src'];
         }
         return $srcList;

user.php

@@ -32,7 +32,7 @@ if (empty($array_keys)) {
     exit;
 }
 
-$username 	= substr($array_keys[0],0,20); // max len of an username
+$username = substr($array_keys[0], 0, 20); // max len of an username
 $friend_id = UserManager::get_user_id_from_username($username);
 
 if (!$friend_id) {