Clean up socialmanager::display_user_list(): better shorter check for bad params - loosely refs #6888

main/inc/lib/social.lib.php

@@ -794,11 +794,16 @@ class SocialManager extends UserManager
 
     /**
      * Displays a sortable table with the list of online users.
-     * @param array $user_list
+     * @param array $user_list The list of users to be shown
+     * @return string HTML block or null if and ID was defined
+     * @assert (null) === false
      */
     public static function display_user_list($user_list)
     {
-        if (!isset($_GET['id'])) {
+        $html = null;
+        if (isset($_GET['id']) or count($user_list) < 1) {
+            return false;
+        }
         $column_size = '9';
         $add_row = false;
         if (api_is_anonymous()) {
@@ -813,7 +818,6 @@ class SocialManager extends UserManager
             $course_url = '&amp;cidReq='.Security::remove_XSS($_GET['cidReq']);
         }
 
-            $html = null;
         if ($add_row) {
             $html .='<div class="row">';
         }
@@ -860,7 +864,6 @@ class SocialManager extends UserManager
         if ($add_row) {
             $html .= '</div>';
         }
-        }
         return $html;
     }