Minor - format code.

plugin/grading_electronic/README.md

@@ -1,7 +1,7 @@
 # Grading Electronic Form
-v0.6
+v0.7
 
-Generate a file necesary to the Grading Electronic form for RickyRescue
+Generate a file necessary to the Grading Electronic form for RickyRescue
 
 * Install the plugin
 * Asign the `content_top` region

plugin/grading_electronic/generate.php

@@ -1,12 +1,12 @@
 <?php
 /* For licensing terms, see /license.txt */
 
-use Chamilo\CoreBundle\Entity\Course,
+use Chamilo\CoreBundle\Entity\Course;
-    Chamilo\CoreBundle\Entity\Session,
+use Chamilo\CoreBundle\Entity\Session;
-    Doctrine\Common\Collections\Criteria,
+use Doctrine\Common\Collections\Criteria;
-    Chamilo\CoreBundle\Entity\SessionRelUser,
+use Chamilo\CoreBundle\Entity\SessionRelUser;
-    Chamilo\CoreBundle\Entity\CourseRelUser,
+use Chamilo\CoreBundle\Entity\CourseRelUser;
-    Chamilo\UserBundle\Entity\User;
+use Chamilo\UserBundle\Entity\User;
 
 require_once '../../main/inc/global.inc.php';
 
@@ -152,7 +152,10 @@ try {
             continue;
         }
 
-        Category::register_user_certificate($gradebook->get_id(), $student->getId());
+        Category::register_user_certificate(
+            $gradebook->get_id(),
+            $student->getId()
+        );
     }
 
     $fileName = implode('_', [

plugin/grading_electronic/src/GradingElectronicPlugin.php

@@ -1,6 +1,9 @@
 <?php
 /* For licensing terms, see /license.txt */
 
+/**
+ * Class GradingElectronicPlugin
+ */
 class GradingElectronicPlugin extends Plugin
 {
     const EXTRAFIELD_STUDENT_ID = 'fcdice_or_acadis_student_id';
@@ -23,8 +26,8 @@ class GradingElectronicPlugin extends Plugin
     protected function __construct()
     {
         parent::__construct(
-            '0.6',
+            '0.7',
-            'Angel Fernando Quiroz Campos',
+            'Angel Fernando Quiroz Campos, Julio Montoya',
             array(
                 'tool_enable' => 'boolean',
             )
@@ -62,7 +65,9 @@ class GradingElectronicPlugin extends Plugin
     {
         $uExtraField = new ExtraField('user');
 
-        if (!$uExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_STUDENT_ID)) {
+        if (!$uExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_STUDENT_ID
+        )) {
             $uExtraField->save([
                 'variable' => self::EXTRAFIELD_STUDENT_ID,
                 'field_type' => ExtraField::FIELD_TYPE_TEXT,
@@ -74,7 +79,9 @@ class GradingElectronicPlugin extends Plugin
 
         $cExtraField = new ExtraField('course');
 
-        if (!$cExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_PROVIDER_ID)) {
+        if (!$cExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_PROVIDER_ID
+        )) {
             $cExtraField->save([
                 'variable' => self::EXTRAFIELD_COURSE_PROVIDER_ID,
                 'field_type' => ExtraField::FIELD_TYPE_TEXT,
@@ -84,7 +91,9 @@ class GradingElectronicPlugin extends Plugin
             ]);
         }
 
-        if (!$cExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_ID)) {
+        if (!$cExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_ID
+        )) {
             $cExtraField->save([
                 'variable' => self::EXTRAFIELD_COURSE_ID,
                 'field_type' => ExtraField::FIELD_TYPE_TEXT,
@@ -94,7 +103,9 @@ class GradingElectronicPlugin extends Plugin
             ]);
         }
 
-        if (!$cExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_HOURS)) {
+        if (!$cExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_HOURS
+        )) {
             $cExtraField->save([
                 'variable' => self::EXTRAFIELD_COURSE_HOURS,
                 'field_type' => ExtraField::FIELD_TYPE_TEXT,
@@ -111,21 +122,27 @@ class GradingElectronicPlugin extends Plugin
     private function setDownExtraFields()
     {
         $uExtraField = new ExtraField('user');
-
+        $studentIdField = $uExtraField->get_handler_field_info_by_field_variable(
-        $studentIdField = $uExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_STUDENT_ID);
+            self::EXTRAFIELD_STUDENT_ID
+        );
 
         if ($studentIdField) {
             $uExtraField->delete($studentIdField['id']);
         }
 
         $cExtraField = new ExtraField('course');
+        $providerIdField = $cExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_PROVIDER_ID
+        );
+        $courseIdField = $cExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_ID
+        );
+        $courseHoursField = $cExtraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_HOURS
+        );
 
-        $proviedIdField = $cExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_PROVIDER_ID);
+        if ($providerIdField) {
-        $courseIdField = $cExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_ID);
+            $cExtraField->delete($providerIdField['id']);
-        $courseHoursField = $cExtraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_HOURS);
-
-        if ($proviedIdField) {
-            $cExtraField->delete($proviedIdField['id']);
         }
 
         if ($courseIdField) {
@@ -143,13 +160,15 @@ class GradingElectronicPlugin extends Plugin
     public function getForm()
     {
         $extraField = new ExtraField('course');
-        $courseIdField = $extraField->get_handler_field_info_by_field_variable(self::EXTRAFIELD_COURSE_ID);
+        $courseIdField = $extraField->get_handler_field_info_by_field_variable(
+            self::EXTRAFIELD_COURSE_ID
+        );
 
         if (!$courseIdField) {
             return null;
         }
 
-        $extraFieldValue =  new ExtraFieldValue('course');
+        $extraFieldValue = new ExtraFieldValue('course');
         $courseIdValue = $extraFieldValue->get_values_by_handler_and_field_variable(
             api_get_course_int_id(),
             self::EXTRAFIELD_COURSE_ID

plugin/grading_electronic/view/grading.html.twig

@@ -22,21 +22,18 @@
             </div>
         </div>
     </div>
-
     <script>
         $(document).on('ready', function () {
             $('form[name="frm_grading_electronic"]').on('submit', function (e) {
                 e.preventDefault();
 
                 var $self = $(this);
-
+                $.post('{{ _p.web_plugin }}grading_electronic/generate.php', $self.serialize())
-                $
+                .done(function (response) {
-                    .post('{{ _p.web_plugin }}grading_electronic/generate.php', $self.serialize())
+                    $('#modal-grading-electronic-result').html(
-                    .done(function (response) {
+                        response
-                        $('#modal-grading-electronic-result').html(
+                    );
-                            response
+                });
-                        );
-                    });
             });
         });
     </script>