Update afters merge 1.11.x

main/exercise/Annotation.php

@@ -11,8 +11,8 @@
  */
 class Annotation extends Question
 {
-    public static $typePicture = 'annotation.png';
+    public $typePicture = 'annotation.png';
-    public static $explanationLangVar = 'Annotation';
+    public $explanationLangVar = 'Annotation';
 
     /**
      * Annotation constructor.

main/exercise/Draggable.php

@@ -8,8 +8,8 @@
  */
 class Draggable extends Question
 {
-    public static $typePicture = 'ordering.png';
+    public $typePicture = 'ordering.png';
-    public static $explanationLangVar = 'Draggable';
+    public $explanationLangVar = 'Draggable';
 
     /**
      * Class constructor.

main/exercise/MatchingDraggable.php

@@ -8,8 +8,8 @@
  */
 class MatchingDraggable extends Question
 {
-    public static $typePicture = 'matchingdrag.png';
+    public $typePicture = 'matchingdrag.png';
-    public static $explanationLangVar = 'MatchingDraggable';
+    public $explanationLangVar = 'MatchingDraggable';
 
     /**
      * Class constructor.

main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php

@@ -18,8 +18,8 @@ class MultipleAnswerTrueFalseDegreeCertainty extends Question
     const LEVEL_LIGHTRED = 4;
     const LEVEL_DARKRED = 5;
 
-    public static $typePicture = 'mccert.png';
+    public $typePicture = 'mccert.png';
-    public static $explanationLangVar = 'MultipleAnswerTrueFalseDegreeCertainty';
+    public $explanationLangVar = 'MultipleAnswerTrueFalseDegreeCertainty';
     public $optionsTitle;
     public $options;
 

main/exercise/ReadingComprehension.php

@@ -11,8 +11,8 @@
  */
 class ReadingComprehension extends UniqueAnswer
 {
-    public static $typePicture = 'reading-comprehension.png';
+    public $typePicture = 'reading-comprehension.png';
-    public static $explanationLangVar = 'ReadingComprehension';
+    public $explanationLangVar = 'ReadingComprehension';
 
     /**
      * Defines the different speeds of scrolling for the reading window,

main/exercise/UniqueAnswerImage.php

@@ -10,8 +10,8 @@ use ChamiloSession as Session;
  */
 class UniqueAnswerImage extends UniqueAnswer
 {
-    public static $typePicture = 'uaimg.png';
+    public $typePicture = 'uaimg.png';
-    public static $explanationLangVar = 'UniqueAnswerImage';
+    public $explanationLangVar = 'UniqueAnswerImage';
 
     /**
      * UniqueAnswerImage constructor.

main/exercise/calculated_answer.class.php

@@ -13,8 +13,8 @@ use Webit\Util\EvalMath\EvalMath;
  */
 class CalculatedAnswer extends Question
 {
-    public static $typePicture = 'calculated_answer.png';
+    public $typePicture = 'calculated_answer.png';
-    public static $explanationLangVar = 'CalculatedAnswer';
+    public $explanationLangVar = 'CalculatedAnswer';
 
     /**
      * Constructor.

main/exercise/fill_blanks.class.php

@@ -15,8 +15,8 @@ class FillBlanks extends Question
     const FILL_THE_BLANK_MENU = 1;
     const FILL_THE_BLANK_SEVERAL_ANSWER = 2;
 
-    public static $typePicture = 'fill_in_blanks.png';
+    public $typePicture = 'fill_in_blanks.png';
-    public static $explanationLangVar = 'FillBlanks';
+    public $explanationLangVar = 'FillBlanks';
 
     /**
      * Constructor.

main/exercise/freeanswer.class.php

@@ -12,8 +12,8 @@
  */
 class FreeAnswer extends Question
 {
-    public static $typePicture = 'open_answer.png';
+    public $typePicture = 'open_answer.png';
-    public static $explanationLangVar = 'FreeAnswer';
+    public $explanationLangVar = 'FreeAnswer';
 
     /**
      * Constructor.

main/exercise/global_multiple_answer.class.php

@@ -8,8 +8,8 @@ use ChamiloSession as Session;
  */
 class GlobalMultipleAnswer extends Question
 {
-    public static $typePicture = 'mcmagl.png';
+    public $typePicture = 'mcmagl.png';
-    public static $explanationLangVar = 'GlobalMultipleAnswer';
+    public $explanationLangVar = 'GlobalMultipleAnswer';
 
     /**
      * GlobalMultipleAnswer constructor.

main/exercise/hotspot.class.php

@@ -14,8 +14,8 @@
  */
 class HotSpot extends Question
 {
-    public static $typePicture = 'hotspot.png';
+    public $typePicture = 'hotspot.png';
-    public static $explanationLangVar = 'HotSpot';
+    public $explanationLangVar = 'HotSpot';
 
     /**
      * HotSpot constructor.

main/exercise/matching.class.php

@@ -15,8 +15,8 @@
  */
 class Matching extends Question
 {
-    public static $typePicture = 'matching.png';
+    public $typePicture = 'matching.png';
-    public static $explanationLangVar = 'Matching';
+    public $explanationLangVar = 'Matching';
 
     /**
      * Constructor.

main/exercise/multiple_answer.class.php

@@ -15,8 +15,8 @@ use ChamiloSession as Session;
  */
 class MultipleAnswer extends Question
 {
-    public static $typePicture = 'mcma.png';
+    public $typePicture = 'mcma.png';
-    public static $explanationLangVar = 'MultipleSelect';
+    public $explanationLangVar = 'MultipleSelect';
 
     /**
      * Constructor.

main/exercise/multiple_answer_combination.class.php

@@ -16,8 +16,8 @@ use ChamiloSession as Session;
  */
 class MultipleAnswerCombination extends Question
 {
-    public static $typePicture = 'mcmac.png';
+    public $typePicture = 'mcmac.png';
-    public static $explanationLangVar = 'MultipleSelectCombination';
+    public $explanationLangVar = 'MultipleSelectCombination';
 
     /**
      * Constructor.

main/exercise/multiple_answer_combination_true_false.class.php

@@ -13,8 +13,8 @@
  */
 class MultipleAnswerCombinationTrueFalse extends MultipleAnswerCombination
 {
-    public static $typePicture = 'mcmaco.png';
+    public $typePicture = 'mcmaco.png';
-    public static $explanationLangVar = 'MultipleAnswerCombinationTrueFalse';
+    public $explanationLangVar = 'MultipleAnswerCombinationTrueFalse';
     public $options;
 
     /**

main/exercise/multiple_answer_true_false.class.php

@@ -14,8 +14,8 @@ use ChamiloSession as Session;
  */
 class MultipleAnswerTrueFalse extends Question
 {
-    public static $typePicture = 'mcmao.png';
+    public $typePicture = 'mcmao.png';
-    public static $explanationLangVar = 'MultipleAnswerTrueFalse';
+    public $explanationLangVar = 'MultipleAnswerTrueFalse';
     public $options;
 
     /**

main/exercise/oral_expression.class.php

@@ -12,8 +12,8 @@
  */
 class OralExpression extends Question
 {
-    public static $typePicture = 'audio_question.png';
+    public $typePicture = 'audio_question.png';
-    public static $explanationLangVar = 'OralExpression';
+    public $explanationLangVar = 'OralExpression';
     public $available_extensions = ['wav', 'ogg'];
     private $sessionId;
     private $userId;

main/exercise/question.class.php

@@ -34,8 +34,8 @@ abstract class Question
     public $isContent;
     public $course;
     public $feedback;
-    public static $typePicture = 'new_question.png';
+    public $typePicture = 'new_question.png';
-    public static $explanationLangVar = '';
+    public $explanationLangVar = '';
     public $question_table_class = 'table table-striped';
     public $questionTypeWithFeedback;
     public $extra;

main/exercise/unique_answer.class.php

@@ -18,8 +18,8 @@ use ChamiloSession as Session;
  */
 class UniqueAnswer extends Question
 {
-    public static $typePicture = 'mcua.png';
+    public $typePicture = 'mcua.png';
-    public static $explanationLangVar = 'UniqueSelect';
+    public $explanationLangVar = 'UniqueSelect';
 
     /**
      * Constructor.
@@ -37,6 +37,7 @@ class UniqueAnswer extends Question
     public function createAnswersForm($form)
     {
         // Getting the exercise list
+        /** @var Exercise $obj_ex */
         $obj_ex = Session::read('objExercise');
 
         $editor_config = [
@@ -50,13 +51,6 @@ class UniqueAnswer extends Question
         $nb_answers = isset($_POST['nb_answers']) ? (int) $_POST['nb_answers'] : 4;
         $nb_answers += (isset($_POST['lessAnswers']) ? -1 : (isset($_POST['moreAnswers']) ? 1 : 0));
 
-        /*
-          Types of Feedback
-          $feedback_option[0]=get_lang('Feedback');
-          $feedback_option[1]=get_lang('DirectFeedback');
-          $feedback_option[2]=get_lang('NoFeedback');
-         */
-
         $feedback_title = '';
         switch ($obj_ex->getFeedbackType()) {
             case EXERCISE_FEEDBACK_TYPE_DIRECT:
@@ -99,8 +93,8 @@ class UniqueAnswer extends Question
         }
         $form->addElement('hidden', 'nb_answers');
 
-        //Feedback SELECT
+        $obj_ex->setQuestionList(true);
-        $question_list = $obj_ex->selectQuestionList();
+        $question_list = $obj_ex->getQuestionList();
         $select_question = [];
         $select_question[0] = get_lang('SelectTargetQuestion');
         if (is_array($question_list)) {

main/exercise/unique_answer_no_option.class.php

@@ -15,8 +15,8 @@ use ChamiloSession as Session;
  */
 class UniqueAnswerNoOption extends Question
 {
-    public static $typePicture = 'mcuao.png';
+    public $typePicture = 'mcuao.png';
-    public static $explanationLangVar = 'UniqueAnswerNoOption';
+    public $explanationLangVar = 'UniqueAnswerNoOption';
 
     /**
      * Constructor.

main/inc/lib/sortable_table.class.php

@@ -132,7 +132,7 @@ class SortableTable extends HTML_Table
             $table_id = $table_name.uniqid('table', true);
         }
         if (isset($parameters) && empty($parameters)) {
-            $parameters = ['class' => 'table data_table', 'id' => $table_id];
+            $parameters = ['class' => 'table table-bordered table-striped', 'id' => $table_id];
         }
 
         $this->table_id = $table_id;
@@ -717,7 +717,7 @@ class SortableTable extends HTML_Table
         foreach ($param as $key => &$value) {
             $result[] = '<input type="hidden" name="'.$key.'" value="'.$value.'"/>';
         }
-        $result[] = '<select class="custom-select" name="'.$this->param_prefix.'per_page" onchange="javascript: this.form.submit();">';
+        $result[] = '<select style="width: auto;" class="form-control" name="'.$this->param_prefix.'per_page" onchange="javascript: this.form.submit();">';
         $list = [10, 20, 50, 100, 500, 1000];
 
         $rowList = api_get_configuration_value('table_row_list');

src/CoreBundle/Controller/Admin/SettingsController.php

@@ -178,10 +178,6 @@ class SettingsController extends SyliusSettingsController
             if (!empty($keywordFromGet)) {
                 return $this->redirect($request->headers->get('referer'));
             }
-
-            /*if ($request->headers->has('referer')) {
-                return $this->redirect($request->headers->get('referer'));
-            }*/
         }
         $schemas = $manager->getSchemas();
 

src/CoreBundle/Entity/ExtraField.php

@@ -32,6 +32,7 @@ class ExtraField // extends BaseAttribute
     public const TERMS_AND_CONDITION_TYPE = 14;
     public const FORUM_CATEGORY_TYPE = 15;
     public const FORUM_POST_TYPE = 16;
+    public const EXERCISE_FIELD_TYPE = 17;
 
     /**
      * @var int