chamilo
/
chamilo-lms
mirror of https://github.com/chamilo/chamilo-lms/tree/1.11.x
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[svn r12277] Fixed CSRF security bug http://projects.dokeos.com/?do=details&id=1197

Browse Source
skala
Yannick Warnier 19 years ago
parent ce5028b8fa
commit 34963826f3
1 changed files with 58 additions and 47 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 105
      main/admin/user_list.php

105
main/admin/user_list.php
Unescape View File

@ -1,6 +1,6 @@
<?php <?php
// $Id: user_list.php 11702 2007-03-27 07:35:23Z elixir_inter $ // $Id: user_list.php 12277 2007-05-03 15:35:44Z yannoo $
/* /*
============================================================================== ==============================================================================
Dokeos - elearning and course management software Dokeos - elearning and course management software
@ -36,6 +36,7 @@ $cidReset = true;
require ('../inc/global.inc.php'); require ('../inc/global.inc.php');
require_once (api_get_path(LIBRARY_PATH).'sortabletable.class.php'); require_once (api_get_path(LIBRARY_PATH).'sortabletable.class.php');
require_once (api_get_path(LIBRARY_PATH).'formvalidator/FormValidator.class.php'); require_once (api_get_path(LIBRARY_PATH).'formvalidator/FormValidator.class.php');
require_once (api_get_path(LIBRARY_PATH).'security.lib.php');
$this_section = SECTION_PLATFORM_ADMIN; $this_section = SECTION_PLATFORM_ADMIN;
api_protect_admin_script(); api_protect_admin_script();
@ -256,7 +257,7 @@ function email_filter($email)
function modify_filter($user_id,$url_params) function modify_filter($user_id,$url_params)
{ {
$result .= '<a href="user_information.php?user_id='.$user_id.'"><img src="../img/synthese_view.gif" border="0" style="vertical-align: middle;" title="'.get_lang('Info').'" alt="'.get_lang('Info').'"/></a>&nbsp;'; $result .= '<a href="user_information.php?user_id='.$user_id.'"><img src="../img/synthese_view.gif" border="0" style="vertical-align: middle;" title="'.get_lang('Info').'" alt="'.get_lang('Info').'"/></a>&nbsp;';
$result .= '<a href="user_list.php?action=login_as&amp;user_id='.$user_id.'"><img src="../img/login_as.gif" border="0" style="vertical-align: middle;" alt="'.get_lang('LoginAs').'" title="'.get_lang('LoginAs').'"/></a>&nbsp;'; $result .= '<a href="user_list.php?action=login_as&amp;user_id='.$user_id.'&amp;sec_token='.$_SESSION['sec_token'].'"><img src="../img/login_as.gif" border="0" style="vertical-align: middle;" alt="'.get_lang('LoginAs').'" title="'.get_lang('LoginAs').'"/></a>&nbsp;';
$tbl_user = Database :: get_main_table(TABLE_MAIN_USER); $tbl_user = Database :: get_main_table(TABLE_MAIN_USER);
$sql="SELECT status FROM ".$tbl_user." WHERE user_id='".$user_id."'"; $sql="SELECT status FROM ".$tbl_user." WHERE user_id='".$user_id."'";
@ -270,7 +271,7 @@ function modify_filter($user_id,$url_params)
} }
$result .= '<a href="user_edit.php?user_id='.$user_id.'"><img src="../img/edit.gif" border="0" style="vertical-align: middle;" title="'.get_lang('Edit').'" alt="'.get_lang('Edit').'"/></a>&nbsp;'; $result .= '<a href="user_edit.php?user_id='.$user_id.'"><img src="../img/edit.gif" border="0" style="vertical-align: middle;" title="'.get_lang('Edit').'" alt="'.get_lang('Edit').'"/></a>&nbsp;';
$result .= '<a href="user_list.php?action=delete_user&amp;user_id='.$user_id.'&amp;'.$url_params.'" onclick="javascript:if(!confirm('."'".addslashes(htmlentities(get_lang("ConfirmYourChoice")))."'".')) return false;"><img src="../img/delete.gif" border="0" style="vertical-align: middle;" title="'.get_lang('Delete').'" alt="'.get_lang('Delete').'"/></a>'; $result .= '<a href="user_list.php?action=delete_user&amp;user_id='.$user_id.'&amp;'.$url_params.'&amp;sec_token='.$_SESSION['sec_token'].'" onclick="javascript:if(!confirm('."'".addslashes(htmlentities(get_lang("ConfirmYourChoice")))."'".')) return false;"><img src="../img/delete.gif" border="0" style="vertical-align: middle;" title="'.get_lang('Delete').'" alt="'.get_lang('Delete').'"/></a>';
return $result; return $result;
} }
@ -301,7 +302,7 @@ function active_filter($active, $url_params, $row)
if ($row['0']<>$_user['user_id']) // you cannot lock yourself out otherwise you could disable all the accounts including your own => everybody is locked out and nobody can change it anymore. if ($row['0']<>$_user['user_id']) // you cannot lock yourself out otherwise you could disable all the accounts including your own => everybody is locked out and nobody can change it anymore.
{ {
$result = '<a href="user_list.php?action='.$action.'&amp;user_id='.$row['0'].'&amp;'.$url_params.'"><img src="../img/'.$image.'.gif" border="0" style="vertical-align: middle;" alt="'.get_lang(ucfirst($action)).'" title="'.get_lang(ucfirst($action)).'"/></a>'; $result = '<a href="user_list.php?action='.$action.'&amp;user_id='.$row['0'].'&amp;'.$url_params.'&amp;sec_token='.$_SESSION['sec_token'].'"><img src="../img/'.$image.'.gif" border="0" style="vertical-align: middle;" alt="'.get_lang(ucfirst($action)).'" title="'.get_lang(ucfirst($action)).'"/></a>';
} }
return $result; return $result;
} }
@ -316,7 +317,6 @@ function active_filter($active, $url_params, $row)
function lock_unlock_user($status,$user_id) function lock_unlock_user($status,$user_id)
{ {
$user_table = Database :: get_main_table(TABLE_MAIN_USER); $user_table = Database :: get_main_table(TABLE_MAIN_USER);
if ($status=='lock') if ($status=='lock')
{ {
$status_db='0'; $status_db='0';
@ -392,58 +392,68 @@ else
//api_display_tool_title($tool_name); //api_display_tool_title($tool_name);
if (isset ($_GET['action'])) if (isset ($_GET['action']))
{ {
switch ($_GET['action']) $check = Security::check_token('get');
if($check)
{ {
case 'show_message' : switch ($_GET['action'])
Display :: display_normal_message(stripslashes($_GET['message'])); {
break; case 'show_message' :
case 'delete_user' : Display :: display_normal_message(stripslashes($_GET['message']));
if ($user_id != $_user['user_id'] && UserManager :: delete_user($_GET['user_id'])) break;
{ case 'delete_user' :
Display :: display_normal_message(get_lang('UserDeleted')); if ($user_id != $_user['user_id'] && UserManager :: delete_user($_GET['user_id']))
} {
else Display :: display_normal_message(get_lang('UserDeleted'));
{ }
Display :: display_error_message(get_lang('CannotDeleteUser')); else
} {
break; Display :: display_error_message(get_lang('CannotDeleteUser'));
case 'lock' : }
$message=lock_unlock_user('lock',$_GET['user_id']); break;
Display :: display_normal_message($message); case 'lock' :
break; $message=lock_unlock_user('lock',$_GET['user_id']);
case 'unlock'; Display :: display_normal_message($message);
$message=lock_unlock_user('unlock',$_GET['user_id']); break;
Display :: display_normal_message($message); case 'unlock';
break; $message=lock_unlock_user('unlock',$_GET['user_id']);
Display :: display_normal_message($message);
break;
}
Security::clear_token();
} }
} }
if (isset ($_POST['action'])) if (isset ($_POST['action']))
{ {
switch ($_POST['action']) $check = Security::check_token('post');
if($check)
{ {
case 'delete' : switch ($_POST['action'])
$number_of_selected_users = count($_POST['id']); {
$number_of_deleted_users = 0; case 'delete' :
foreach ($_POST['id'] as $index => $user_id) $number_of_selected_users = count($_POST['id']);
{ $number_of_deleted_users = 0;
if($user_id != $_user['user_id']) foreach ($_POST['id'] as $index => $user_id)
{ {
if(UserManager :: delete_user($user_id)) if($user_id != $_user['user_id'])
{ {
$number_of_deleted_users++; if(UserManager :: delete_user($user_id))
{
$number_of_deleted_users++;
}
} }
} }
} if($number_of_selected_users == $number_of_deleted_users)
if($number_of_selected_users == $number_of_deleted_users) {
{ Display :: display_normal_message(get_lang('SelectedUsersDeleted'));
Display :: display_normal_message(get_lang('SelectedUsersDeleted')); }
} else
else {
{ Display :: display_error_message(get_lang('SomeUsersNotDeleted'));
Display :: display_error_message(get_lang('SomeUsersNotDeleted')); }
} break;
break; }
Security::clear_token();
} }
} }
// Create a search-box // Create a search-box
@ -469,6 +479,7 @@ else
$parameters['keyword_inactive'] = $_GET['keyword_inactive']; $parameters['keyword_inactive'] = $_GET['keyword_inactive'];
} }
// Create a sortable table with user-data // Create a sortable table with user-data
Security::get_token();
$table = new SortableTable('users', 'get_number_of_users', 'get_user_data',2); $table = new SortableTable('users', 'get_number_of_users', 'get_user_data',2);
$table->set_additional_parameters($parameters); $table->set_additional_parameters($parameters);
$table->set_header(0, '', false); $table->set_header(0, '', false);

Write Preview
Loading…
Cancel
Save