Minor - flint fixes

pull/2650/head
Julio Montoya 7 years ago
parent 04cbf04fdd
commit 447932aa3b
  1. 2
      main/admin/index.php
  2. 2
      main/course_info/infocours.php
  3. 66
      main/inc/lib/add_course.lib.inc.php
  4. 1
      main/inc/lib/api.lib.php
  5. 2
      main/inc/lib/display.lib.php
  6. 3
      main/inc/lib/template.lib.php
  7. 1
      main/inc/lib/userportal.lib.php
  8. 12
      main/install/index.php
  9. 5
      main/install/install.lib.php
  10. 2
      src/CoreBundle/Controller/CourseController.php
  11. 3
      src/CoreBundle/Controller/FrontController.php
  12. 7
      src/CoreBundle/Controller/IndexController.php
  13. 6
      src/CoreBundle/Controller/ResourceController.php
  14. 2
      src/CoreBundle/Controller/User/ProfileController.php
  15. 4
      src/CoreBundle/Controller/User/UserController.php
  16. 2
      src/CoreBundle/Controller/UserPortalController.php
  17. 2
      src/CoreBundle/EventListener/LegacyLoginListener.php
  18. 3
      src/CoreBundle/EventListener/LoginSuccessHandler.php
  19. 6
      src/CoreBundle/EventListener/LogoutSuccessHandler.php
  20. 2
      src/CoreBundle/EventListener/OnlineListener.php
  21. 3
      src/CoreBundle/Framework/Exporter.php
  22. 2
      src/CoreBundle/Security/Authorization/Voter/CourseVoter.php
  23. 2
      src/CoreBundle/Settings/ProfileSettingsSchema.php
  24. 2
      src/CoreBundle/Settings/SessionSettingsSchema.php
  25. 1
      src/CoreBundle/Twig/Extension/ChamiloExtension.php
  26. 2
      src/CourseBundle/Controller/Home/HomeController.php
  27. 1
      src/CourseBundle/Entity/CTool.php
  28. 6
      src/CourseBundle/Resources/config/admin.yml
  29. 8
      src/ThemeBundle/EventListener/TwigListener.php
  30. 4
      src/UserBundle/Admin/UserAdmin.php

@ -725,7 +725,7 @@ if (api_is_platform_admin()) {
get_lang('Save'), get_lang('Save'),
'submit_extra_content' 'submit_extra_content'
); );
//var_dump($extraContentForm->returnForm());
$tpl->assign('extraDataForm', $extraContentForm->returnForm()); $tpl->assign('extraDataForm', $extraContentForm->returnForm());
} }

@ -400,7 +400,6 @@ $group[] = $form->createElement(
); );
$globalGroup[get_lang('NewHomeworkEmailAlert')] = $group; $globalGroup[get_lang('NewHomeworkEmailAlert')] = $group;
$group = []; $group = [];
$group[] = $form->createElement( $group[] = $form->createElement(
'radio', 'radio',
@ -493,7 +492,6 @@ $form->addPanelOption(
$globalGroup $globalGroup
); );
$group = []; $group = [];
$group[] = $form->createElement( $group[] = $form->createElement(
'radio', 'radio',

@ -1,10 +1,10 @@
<?php <?php
/* For licensing terms, see /license.txt */ /* For licensing terms, see /license.txt */
use Chamilo\CoreBundle\Framework\Container;
use Chamilo\CourseBundle\Entity\CTool; use Chamilo\CourseBundle\Entity\CTool;
use Chamilo\CourseBundle\Entity\CToolIntro; use Chamilo\CourseBundle\Entity\CToolIntro;
use Chamilo\CourseBundle\Tool\BaseTool; use Chamilo\CourseBundle\Tool\BaseTool;
use Chamilo\CoreBundle\Framework\Container;
/** /**
* Class AddCourse. * Class AddCourse.
@ -451,38 +451,38 @@ class AddCourse
//$toolList = $toolList->getTools(); //$toolList = $toolList->getTools();
/** @var BaseTool $tool */ /** @var BaseTool $tool */
/* foreach ($toolList as $tool) { /* foreach ($toolList as $tool) {
$toolName = $tool->getName(); $toolName = $tool->getName();
$visibility = self::string2binary( $visibility = self::string2binary(
api_get_setting_in_list('course.active_tools_on_create', $toolName) api_get_setting_in_list('course.active_tools_on_create', $toolName)
); );
$toolObject = new CTool(); $toolObject = new CTool();
$toolObject $toolObject
->setName($tool->getName()) ->setName($tool->getName())
->setCategory($tool->getCategory()) ->setCategory($tool->getCategory())
->setLink($tool->getLink()) ->setLink($tool->getLink())
->setImage($tool->getImage()) ->setImage($tool->getImage())
->setVisibility($visibility) ->setVisibility($visibility)
->setAddedTool(0) ->setAddedTool(0)
->setAdmin(0) ->setAdmin(0)
->setTarget($tool->getTarget()) ->setTarget($tool->getTarget())
; ;
$tools[] = $toolObject; $tools[] = $toolObject;
//$settings = $settingsManager->load($toolName); //$settings = $settingsManager->load($toolName);
//var_dump($settings); //var_dump($settings);
//$settingsManager->save($settings); //$settingsManager->save($settings);
} }
$course->setTools($tools); $course->setTools($tools);
$em->persist($course); $em->persist($course);
$em->flush($course); $em->flush($course);
foreach ($tools as $tool) { foreach ($tools as $tool) {
$tool->setId($tool->getIid()); $tool->setId($tool->getIid());
$em->refresh($course); $em->refresh($course);
} }
$em->flush($course);*/ $em->flush($course);*/
/* Course tools */ /* Course tools */
/* /*

@ -2108,7 +2108,6 @@ function api_get_url_entity($id = 0)
return Database::getManager()->getRepository('ChamiloCoreBundle:AccessUrl')->find($id); return Database::getManager()->getRepository('ChamiloCoreBundle:AccessUrl')->find($id);
} }
/** /**
* Returns the current course info array. * Returns the current course info array.

@ -2630,7 +2630,7 @@ class Display
$contentClass = 'panel-collapse collapse '; $contentClass = 'panel-collapse collapse ';
$contentClass .= $open ? 'in' : ''; $contentClass .= $open ? 'in' : '';
$ariaExpanded = $open ? 'true' : 'false'; $ariaExpanded = $open ? 'true' : 'false';
$html = <<<HTML $html = <<<HTML
<div class="card" id="$id"> <div class="card" id="$id">
<div class="card-header"> <div class="card-header">

@ -134,7 +134,7 @@ class Template
} }
//$this->twig = new Twig_Environment($loader, $options); //$this->twig = new Twig_Environment($loader, $options);
$this->twig = Container::getTwig(); $this->twig = Container::getTwig();
if ($isTestMode) { if ($isTestMode) {
//$this->twig->addExtension(new Twig_Extension_Debug()); //$this->twig->addExtension(new Twig_Extension_Debug());
@ -680,6 +680,7 @@ class Template
/** /**
* Set theme, include mainstream CSS files. * Set theme, include mainstream CSS files.
*
* @deprecated * @deprecated
* @see setCssCustomFiles() for additional CSS sheets * @see setCssCustomFiles() for additional CSS sheets
*/ */

@ -1971,7 +1971,6 @@ class IndexManager
} }
$htmlSessionCategory .= '</div>'; // end session cat block $htmlSessionCategory .= '</div>'; // end session cat block
$htmlCategory .= Display::panel($htmlSessionCategory, ''); $htmlCategory .= Display::panel($htmlSessionCategory, '');
} }
$userCategoryHtml .= $htmlCategory; $userCategoryHtml .= $htmlCategory;
} }

@ -789,12 +789,12 @@ if (@$_POST['step2']) {
// No errors // No errors
//if ($result == 0) { //if ($result == 0) {
// Boot kernel and get the doctrine from Symfony container // Boot kernel and get the doctrine from Symfony container
$kernel->boot(); $kernel->boot();
$containerDatabase = $kernel->getContainer(); $containerDatabase = $kernel->getContainer();
$sysPath = api_get_path(SYS_PATH); $sysPath = api_get_path(SYS_PATH);
updateWithContainer($containerDatabase); updateWithContainer($containerDatabase);
//} //}
} else { } else {
set_file_folder_permissions(); set_file_folder_permissions();
$database = connectToDatabase( $database = connectToDatabase(

@ -2993,7 +2993,7 @@ function updateEnvFile($distFile, $envFile, $params)
/** /**
* @param SymfonyContainer $container * @param SymfonyContainer $container
* @param EntityManager $manager * @param EntityManager $manager
*/ */
function installGroups($container, $manager) function installGroups($container, $manager)
{ {
@ -3059,7 +3059,6 @@ function installGroups($container, $manager)
/** /**
* @param SymfonyContainer $container * @param SymfonyContainer $container
*
*/ */
function installPages($container) function installPages($container)
{ {
@ -3159,7 +3158,7 @@ function installPages($container)
/** /**
* @param SymfonyContainer $container * @param SymfonyContainer $container
* @param EntityManager $manager * @param EntityManager $manager
*/ */
function installSchemas($container, $manager) function installSchemas($container, $manager)
{ {

@ -15,7 +15,9 @@ use Symfony\Component\HttpFoundation\Response;
/** /**
* Class CourseController. * Class CourseController.
*
* @Route("/course") * @Route("/course")
*
* @package Chamilo\CoreBundle\Controller * @package Chamilo\CoreBundle\Controller
*/ */
class CourseController extends Controller class CourseController extends Controller

@ -14,8 +14,11 @@ use Symfony\Component\HttpFoundation\Request;
/** /**
* Class FrontController. * Class FrontController.
*
* @Route("/front") * @Route("/front")
*
* @deprecated not used for now * @deprecated not used for now
*
* @package Chamilo\CoreBundle\Controller * @package Chamilo\CoreBundle\Controller
*/ */
class FrontController extends Controller class FrontController extends Controller

@ -4,17 +4,12 @@
namespace Chamilo\CoreBundle\Controller; namespace Chamilo\CoreBundle\Controller;
//use Chamilo\CoreBundle\Admin\CourseAdmin; //use Chamilo\CoreBundle\Admin\CourseAdmin;
use Chamilo\CoreBundle\Entity\ExtraField;
use Chamilo\CoreBundle\Entity\ExtraFieldValues;
use Chamilo\CoreBundle\Framework\PageController; use Chamilo\CoreBundle\Framework\PageController;
use Chamilo\PageBundle\Entity\Block; use Chamilo\PageBundle\Entity\Block;
use Chamilo\UserBundle\Entity\User;
use Symfony\Component\Routing\Annotation\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security; use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use Sylius\Component\Attribute\AttributeType\TextAttributeType;
use Sylius\Component\Attribute\Model\AttributeValueInterface;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
/** /**
* Class IndexController * Class IndexController

@ -3,14 +3,15 @@
namespace Chamilo\CoreBundle\Controller; namespace Chamilo\CoreBundle\Controller;
use League\Flysystem\Filesystem;
use League\Flysystem\Adapter\Local; use League\Flysystem\Adapter\Local;
use League\Flysystem\Filesystem;
use Symfony\Component\HttpFoundation\BinaryFileResponse; use Symfony\Component\HttpFoundation\BinaryFileResponse;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route; use Symfony\Component\Routing\Annotation\Route;
/** /**
* Class ResourceController * Class ResourceController.
*
* @author Julio Montoya <gugli100@gmail.com>. * @author Julio Montoya <gugli100@gmail.com>.
* *
* @Route("/resource") * @Route("/resource")
@ -52,7 +53,6 @@ class ResourceController extends BaseController
/** @var Filesystem $fs */ /** @var Filesystem $fs */
$fs = $this->container->get('oneup_flysystem.courses_filesystem'); $fs = $this->container->get('oneup_flysystem.courses_filesystem');
$path = $course.'/document/'.$file; $path = $course.'/document/'.$file;
// Has folder // Has folder

@ -18,7 +18,6 @@ class ProfileController extends BaseController
* My files. * My files.
* *
* @Route("/{username}/files", methods={"GET"}) * @Route("/{username}/files", methods={"GET"})
*
*/ */
public function fileAction($username) public function fileAction($username)
{ {
@ -52,7 +51,6 @@ class ProfileController extends BaseController
* Gets that rm.wav sound. * Gets that rm.wav sound.
* *
* @Route("/{username}/sounds/{file}", methods={"GET"}) * @Route("/{username}/sounds/{file}", methods={"GET"})
*
*/ */
public function getSoundAction() public function getSoundAction()
{ {

@ -16,13 +16,13 @@ use Symfony\Component\Routing\Annotation\Route;
* *
* @package Chamilo\CoreBundle\Controller * @package Chamilo\CoreBundle\Controller
* @Route("/user") * @Route("/user")
*
* @author Julio Montoya <gugli100@gmail.com> * @author Julio Montoya <gugli100@gmail.com>
*/ */
class UserController extends BaseController class UserController extends BaseController
{ {
/** /**
* @Route("/me", methods={"GET"}) * @Route("/me", methods={"GET"})
*
*/ */
public function indexAction(Request $request) public function indexAction(Request $request)
{ {
@ -63,7 +63,6 @@ class UserController extends BaseController
/** /**
* @Route("/me/my_courses", methods={"GET"}, options={"expose"=true}) * @Route("/me/my_courses", methods={"GET"}, options={"expose"=true})
*
*/ */
public function myCoursesAction() public function myCoursesAction()
{ {
@ -87,7 +86,6 @@ class UserController extends BaseController
/** /**
* @Route("/online", methods={"GET"}) * @Route("/online", methods={"GET"})
*
*/ */
public function onlineAction($app) public function onlineAction($app)
{ {

@ -13,7 +13,9 @@ use Symfony\Component\HttpFoundation\Response;
/** /**
* Class UserPortalController * Class UserPortalController
* author Julio Montoya <gugli100@gmail.com>. * author Julio Montoya <gugli100@gmail.com>.
*
* @Route("/userportal") * @Route("/userportal")
*
* @package Chamilo\CoreBundle\Controller * @package Chamilo\CoreBundle\Controller
*/ */
class UserPortalController extends BaseController class UserPortalController extends BaseController

@ -10,9 +10,9 @@ use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent; use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\GetResponseEvent; use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents; use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken; use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Security\Http\Event\InteractiveLoginEvent; use Symfony\Component\Security\Http\Event\InteractiveLoginEvent;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
/** /**
* Class LegacyLoginListener. * Class LegacyLoginListener.

@ -24,7 +24,8 @@ class LoginSuccessHandler implements AuthenticationSuccessHandlerInterface
* @param UrlGeneratorInterface $urlGenerator * @param UrlGeneratorInterface $urlGenerator
* @param AuthorizationCheckerInterface $checker * @param AuthorizationCheckerInterface $checker
*/ */
public function __construct(UrlGeneratorInterface $urlGenerator, AuthorizationCheckerInterface $checker) { public function __construct(UrlGeneratorInterface $urlGenerator, AuthorizationCheckerInterface $checker)
{
$this->router = $urlGenerator; $this->router = $urlGenerator;
$this->checker = $checker; $this->checker = $checker;
} }

@ -21,9 +21,9 @@ class LogoutSuccessHandler implements LogoutSuccessHandlerInterface
protected $storage; protected $storage;
/** /**
* @param UrlGeneratorInterface $urlGenerator * @param UrlGeneratorInterface $urlGenerator
* @param AuthorizationCheckerInterface $checker * @param AuthorizationCheckerInterface $checker
* @param TokenStorageInterface $storage * @param TokenStorageInterface $storage
*/ */
public function __construct( public function __construct(
UrlGeneratorInterface $urlGenerator, UrlGeneratorInterface $urlGenerator,

@ -23,7 +23,7 @@ class OnlineListener
/** /**
* @param TokenStorageInterface $context * @param TokenStorageInterface $context
* @param ObjectManager $em * @param ObjectManager $em
*/ */
public function __construct(TokenStorageInterface $context, ObjectManager $em) public function __construct(TokenStorageInterface $context, ObjectManager $em)
{ {

@ -11,7 +11,8 @@ use Exporter\Writer\XmlWriter;
use Symfony\Component\HttpFoundation\StreamedResponse; use Symfony\Component\HttpFoundation\StreamedResponse;
/** /**
* Class Exporter * Class Exporter.
*
* @package Chamilo\CoreBundle\Framework\Exporter * @package Chamilo\CoreBundle\Framework\Exporter
*/ */
class Exporter class Exporter

@ -6,8 +6,8 @@ namespace Chamilo\CoreBundle\Security\Authorization\Voter;
use Chamilo\CoreBundle\Entity\Course; use Chamilo\CoreBundle\Entity\Course;
use Chamilo\CoreBundle\Entity\Manager\CourseManager; use Chamilo\CoreBundle\Entity\Manager\CourseManager;
use Chamilo\UserBundle\Entity\User; use Chamilo\UserBundle\Entity\User;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityManager; use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\DependencyInjection\ContainerInterface; use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface; use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter; use Symfony\Component\Security\Core\Authorization\Voter\Voter;

@ -36,7 +36,7 @@ class ProfileSettingsSchema extends AbstractSettingsSchema
'enable_profile_user_address_geolocalization' => '', 'enable_profile_user_address_geolocalization' => '',
'allow_show_skype_account' => '', 'allow_show_skype_account' => '',
'allow_show_linkedin_url' => '', 'allow_show_linkedin_url' => '',
'is_editable' => 'true' 'is_editable' => 'true',
] ]
) )
->setTransformer( ->setTransformer(

@ -45,7 +45,7 @@ class SessionSettingsSchema extends AbstractSettingsSchema
'session_days_after_coach_access' => '', 'session_days_after_coach_access' => '',
'session_days_before_coach_access' => '', 'session_days_before_coach_access' => '',
'show_session_description' => 'false', 'show_session_description' => 'false',
'remove_session_url' => 'false' 'remove_session_url' => 'false',
] ]
) )
; ;

@ -27,7 +27,6 @@ class ChamiloExtension extends \Twig_Extension
new \Twig_SimpleFilter('format_date', 'Template::format_date'), new \Twig_SimpleFilter('format_date', 'Template::format_date'),
new \Twig_SimpleFilter('date_to_time_ago', 'Display::dateToStringAgoAndLongDate'), new \Twig_SimpleFilter('date_to_time_ago', 'Display::dateToStringAgoAndLongDate'),
new \Twig_SimpleFilter('api_get_configuration_value', 'api_get_configuration_value'), new \Twig_SimpleFilter('api_get_configuration_value', 'api_get_configuration_value'),
]; ];
} }

@ -347,7 +347,6 @@ class HomeController extends ToolBaseController
/** /**
* @Route("/{itemId}/edit", methods={"GET"}) * @Route("/{itemId}/edit", methods={"GET"})
*
*/ */
public function editIconAction($itemId) public function editIconAction($itemId)
{ {
@ -389,7 +388,6 @@ class HomeController extends ToolBaseController
/** /**
* @Route("/{itemId}/delete", methods={"GET"}) * @Route("/{itemId}/delete", methods={"GET"})
*
*/ */
public function deleteIconAction($itemId) public function deleteIconAction($itemId)
{ {

@ -9,6 +9,7 @@ use Doctrine\ORM\Mapping as ORM;
/** /**
* CTool. * CTool.
*
* @ORM\HasLifecycleCallbacks * @ORM\HasLifecycleCallbacks
* @ORM\Table( * @ORM\Table(
* name="c_tool", * name="c_tool",

@ -2,14 +2,14 @@ services:
sonata.admin.course: sonata.admin.course:
class: Chamilo\CourseBundle\Admin\CourseAdmin class: Chamilo\CourseBundle\Admin\CourseAdmin
tags: tags:
- { name: sonata.admin, manager_type: orm, group: "LMS", label: "Course" } - {name: sonata.admin, manager_type: orm, group: "LMS", label: "Course"}
arguments: arguments:
- ~ - ~
- Chamilo\CoreBundle\Entity\Course - Chamilo\CoreBundle\Entity\Course
- ~ - ~
calls: calls:
- [ setTranslationDomain, [ChamiloCoreBundle]] - [setTranslationDomain, [ChamiloCoreBundle]]
- [ setToolChain, ['@chamilo_course.tool_chain']] - [setToolChain, ['@chamilo_course.tool_chain']]
sonata.admin.course_rel_user: sonata.admin.course_rel_user:
class: Chamilo\CourseBundle\Admin\CourseRelUserAdmin class: Chamilo\CourseBundle\Admin\CourseRelUserAdmin

@ -7,21 +7,18 @@ use Chamilo\CoreBundle\Framework\Container;
use Symfony\Component\DependencyInjection\ContainerAwareTrait; use Symfony\Component\DependencyInjection\ContainerAwareTrait;
use Symfony\Component\DependencyInjection\ContainerInterface; use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface; use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\GetResponseEvent; use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents; use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\Routing\Route;
class TwigListener implements EventSubscriberInterface class TwigListener implements EventSubscriberInterface
{ {
use ContainerAwareTrait;
public function __construct(ContainerInterface $container) public function __construct(ContainerInterface $container)
{ {
$this->container = $container; $this->container = $container;
} }
use ContainerAwareTrait;
/** /**
* @param GetResponseEvent $event * @param GetResponseEvent $event
*/ */
@ -51,5 +48,4 @@ class TwigListener implements EventSubscriberInterface
KernelEvents::REQUEST => [['onKernelRequest', 15]], KernelEvents::REQUEST => [['onKernelRequest', 15]],
]; ];
} }
} }

@ -66,8 +66,8 @@ class UserAdmin extends BaseUserAdmin
)*/ )*/
->add('firstname', null, ['required' => false]) ->add('firstname', null, ['required' => false])
->add('lastname', null, ['required' => false]) ->add('lastname', null, ['required' => false])
->add('website', 'url', array('required' => false)) ->add('website', 'url', ['required' => false])
->add('biography', 'text', array('required' => false)) ->add('biography', 'text', ['required' => false])
/*->add( /*->add(
'gender', 'gender',
'sonata_user_gender', 'sonata_user_gender',

Loading…
Cancel
Save