Announcements: Fixed Comments - refs BT# 18151

main/admin/system_announcements.php

@@ -351,7 +351,7 @@ if ($action_todo) {
                     isset($values['promotion_id']) ? $values['promotion_id'] : 0,
                     $groupToSend
                 )) {
-                    if (isset($groupToSend)) {
+                    if (0 != $groupToSend) {
                         SystemAnnouncementManager::announcement_for_groups(
                             $values['id'],
                             [$groupToSend]

main/inc/lib/system_announcements.lib.php

@@ -710,9 +710,8 @@ class SystemAnnouncementManager
             $data = Database::store_result($result);
             Database::free_result($result);
             $usersId = [];
-            $totalUsers = count($data);
+            foreach($data as $userArray){
-            for ($i = 0; $i < $totalUsers; $i++) {
+                $usersId[] = $userArray['user_id'];
-                $usersId[] = $data[$i]['user_id'];
             }
             $usersId = implode(',', $usersId);
             $whereUsersInGroup = " AND u.user_id in ($usersId) ";