Coach can access detail user information see BT#11985

main/mySpace/myStudents.php

@@ -9,20 +9,34 @@ require_once '../inc/global.inc.php';
 
 api_block_anonymous_users();
 
+$export = isset($_GET['export']) ? $_GET['export'] : false;
+$sessionId = isset($_GET['id_session']) ? intval($_GET['id_session']) : 0;
+$origin = isset($_GET['origin']) ? Security::remove_XSS($_GET['origin']) : '';
+$course_code = isset($_GET['course']) ? Security :: remove_XSS($_GET['course']) : null;
+$courseInfo = api_get_course_info($course_code);
+$student_id = intval($_GET['student']);
+
 if (!api_is_allowed_to_create_course() &&
     !api_is_session_admin() &&
     !api_is_drh() &&
     !api_is_student_boss() &&
     !api_is_platform_admin()
 ) {
+    if (empty($sessionId)) {
         // Check if the user is tutor of the course
-    $user_course_status = CourseManager::get_tutor_in_course_status(
+        $userCourseStatus = CourseManager::get_tutor_in_course_status(
             api_get_user_id(),
             api_get_course_int_id()
         );
-    if ($user_course_status != 1) {
+        if ($userCourseStatus != 1) {
+            api_not_allowed(true);
+        }
+    } else {
+        $coach = api_is_coach($sessionId, $courseInfo['real_id']);
+        if (!$coach) {
             api_not_allowed(true);
         }
+    }
 }
 
 $htmlHeadXtra[] = '<script>
@@ -33,15 +47,6 @@ function show_image(image,width,height) {
 }
 </script>';
 
-$export = isset($_GET['export']) ? $_GET['export'] : false;
-$sessionId = isset($_GET['id_session']) ? intval($_GET['id_session']) : 0;
-$origin = isset($_GET['origin']) ? Security::remove_XSS($_GET['origin']) : '';
-$course_code = isset($_GET['course']) ? Security :: remove_XSS($_GET['course']) : null;
-$student_id = intval($_GET['student']);
-
-// time spent on the course
-$courseInfo = api_get_course_info($course_code);
-
 if ($export) {
     ob_start();
 }
@@ -263,7 +268,6 @@ while ($row = Database :: fetch_array($rs)) {
     }
 }
 
-
 // Get the list of sessions where the user is subscribed as student
 $sql = 'SELECT session_id, c_id
         FROM '.Database::get_main_table(TABLE_MAIN_SESSION_COURSE_USER).'