Fixing bug when uploading users in a class via CSV now we don't delete the original users

skala
Julio Montoya 13 years ago
parent e700799597
commit 64baf97969
  1. 2
      main/admin/usergroup_user_import.php
  2. 9
      main/inc/lib/usergroup.lib.php

@ -103,7 +103,7 @@ function save_data($users_classes) {
$user_list = $user_data['user_list']; $user_list = $user_data['user_list'];
$class_name = $user_data['class_name']; $class_name = $user_data['class_name'];
$user_list_name = $user_data['user_list_name']; $user_list_name = $user_data['user_list_name'];
$usergroup->subscribe_users_to_usergroup($class_id, $user_list); $usergroup->subscribe_users_to_usergroup($class_id, $user_list, false);
$message .= Display::return_message(get_lang('Class') . ': ' . $class_name . '<br />', 'normal', false); $message .= Display::return_message(get_lang('Class') . ': ' . $class_name . '<br />', 'normal', false);
$message .= Display::return_message(get_lang('Users') . ': ' . implode(', ', $user_list_name)); $message .= Display::return_message(get_lang('Users') . ': ' . implode(', ', $user_list_name));
} }

@ -293,7 +293,7 @@ class UserGroup extends Model {
* @param int usergroup id * @param int usergroup id
* @param array list of user ids * @param array list of user ids
*/ */
function subscribe_users_to_usergroup($usergroup_id, $list) { function subscribe_users_to_usergroup($usergroup_id, $list, $delete_users_not_present_in_list = true) {
$current_list = self::get_users_by_usergroup($usergroup_id); $current_list = self::get_users_by_usergroup($usergroup_id);
$course_list = self::get_courses_by_usergroup($usergroup_id); $course_list = self::get_courses_by_usergroup($usergroup_id);
$session_list = self::get_sessions_by_usergroup($usergroup_id); $session_list = self::get_sessions_by_usergroup($usergroup_id);
@ -308,17 +308,18 @@ class UserGroup extends Model {
} }
} }
} }
if (!empty($current_list)) { if (!empty($current_list)) {
foreach($current_list as $user_id) { foreach($current_list as $user_id) {
if (!in_array($user_id, $list)) { if (!in_array($user_id, $list)) {
$delete_items[] = $user_id; $delete_items[] = $user_id;
} }
} }
} }
//Deleting items //Deleting items
if (!empty($delete_items)) { if (!empty($delete_items) && $delete_users_not_present_in_list) {
foreach($delete_items as $user_id) { foreach ($delete_items as $user_id) {
//Removing courses //Removing courses
if (!empty($course_list)) { if (!empty($course_list)) {
foreach($course_list as $course_id) { foreach($course_list as $course_id) {

Loading…
Cancel
Save