Merge pull request #5014 from christianbeeznest/ofaj-21219-2

Session: Fix error when session is created and visibility - refs BT#21219

public/main/session/session_add.php

@@ -253,9 +253,9 @@ $form->setDefaults($formDefaults);
 if ($form->validate()) {
     $params = $form->getSubmitValues();
     $name = $params['name'];
-    $startDate = $params['access_start_date2'];
+    $startDate = $params['access_start_date'];
     $endDate = $params['access_end_date'];
-    $displayStartDate = $params['display_start_date2'];
+    $displayStartDate = $params['display_start_date'];
     $displayEndDate = $params['display_end_date'];
     $coachStartDate = $params['coach_access_start_date'];
     if (empty($coachStartDate)) {

src/CoreBundle/Entity/Course.php

@@ -550,10 +550,15 @@ class Course extends AbstractResource implements ResourceInterface, ResourceWith
 
     public function getTeachersSubscriptions(): Collection
     {
-        $criteria = Criteria::create();
+        $teacherSubscriptions = new ArrayCollection();
-        $criteria->where(Criteria::expr()->eq('status', CourseRelUser::TEACHER));
 
-        return $this->users->matching($criteria);
+        foreach ($this->users as $subscription) {
+            if ($subscription->getStatus() === CourseRelUser::TEACHER) {
+                $teacherSubscriptions->add($subscription);
+            }
+        }
+
+        return $teacherSubscriptions;
     }
 
     public function addUserAsTeacher(User $user): self