Quiz: Fix division by zero + fix e_notice

pull/4362/head
Angel Fernando Quiroz Campos 3 years ago
parent da15eaa0c3
commit 80d103357a
  1. 2
      main/exercise/answer.class.php
  2. 4
      main/inc/lib/exercise.lib.php
  3. 2
      plugin/xapi/src/ToolExperience/Statement/QuizQuestionAnswered.php

@ -849,7 +849,7 @@ class Answer
if (count($this->position) > $this->new_nbrAnswers) { if (count($this->position) > $this->new_nbrAnswers) {
$i = $this->new_nbrAnswers + 1; $i = $this->new_nbrAnswers + 1;
while ($this->position[$i]) { while (isset($this->position[$i])) {
$position = $this->position[$i]; $position = $this->position[$i];
$sql = "DELETE FROM $answerTable $sql = "DELETE FROM $answerTable
WHERE WHERE

@ -5176,8 +5176,8 @@ EOT;
continue; continue;
} }
$total_score += $result['score']; $total_score += (float) $result['score'];
$total_weight += $result['weight']; $total_weight += (float) $result['weight'];
$question_list_answers[] = [ $question_list_answers[] = [
'question' => $result['open_question'], 'question' => $result['open_question'],

@ -53,7 +53,7 @@ class QuizQuestionAnswered extends BaseStatement
$rawResult = $this->attempt->getMarks(); $rawResult = $this->attempt->getMarks();
$maxResult = $this->question->getPonderation(); $maxResult = $this->question->getPonderation();
$scaledResult = $rawResult / $maxResult; $scaledResult = $maxResult ? ($rawResult / $maxResult) : 0;
$context = $this->generateContext(); $context = $this->generateContext();
$contextActivities = $context $contextActivities = $context

Loading…
Cancel
Save