Add filter for user to custom tabs - refs BT#12876

main/inc/lib/banner.lib.php

@@ -167,8 +167,18 @@ function getCustomTabs()
     $result = Database::query($sql);
     $customTabs = array();
     while ($row = Database::fetch_assoc($result)) {
+        $shouldAdd = true;
+
+        if (strpos($row['subkey'], Plugin::TAB_FILTER_NO_STUDENT) !== false && api_is_student()) {
+            $shouldAdd = false;
+        } elseif (strpos($row['subkey'], Plugin::TAB_FILTER_ONLY_STUDENT) !== false && !api_is_student()) {
+            $shouldAdd = false;
+        }
+
+        if ($shouldAdd) {
             $customTabs[] = $row;
         }
+    }
 
     return $customTabs;
 }

main/inc/lib/plugin.class.php

@@ -51,6 +51,9 @@ class Plugin
      */
     public $course_settings_callback = false;
 
+    const TAB_FILTER_NO_STUDENT = '::no-student';
+    const TAB_FILTER_ONLY_STUDENT = '::only-student';
+
     /**
      * Default constructor for the plugin class. By default, it only sets
      * a few attributes of the object
@@ -638,10 +641,10 @@ class Plugin
      * Add a tab to platform
      * @param string $tabName
      * @param string $url
-    *
+     * @param string $userFilter Optional. Filter tab type
      * @return false|string
      */
-    public function addTab($tabName, $url)
+    public function addTab($tabName, $url, $userFilter = null)
     {
         $sql = "SELECT * FROM settings_current
                 WHERE
@@ -673,6 +676,17 @@ class Plugin
 
         // End Check
         $subkey = 'custom_tab_'.$tabNum;
+
+        if (!empty($userFilter)) {
+            switch ($userFilter) {
+                case self::TAB_FILTER_NO_STUDENT:
+                    //no break
+                case self::TAB_FILTER_ONLY_STUDENT:
+                    $subkey .= $userFilter;
+                    break;
+            }
+        }
+
         $attributes = array(
             'variable' => 'show_tabs',
             'subkey' => $subkey,
@@ -730,9 +744,16 @@ class Plugin
                 $tabs = Database::store_result($result, 'ASSOC');
                 $i = 1;
                 foreach ($tabs as $row) {
-                    $attributes = array(
+                    $newSubKey = "custom_tab_$i";
-                        'subkey' => 'custom_tab_'.$i
+
-                    );
+                    if (strpos($row['subkey'], self::TAB_FILTER_NO_STUDENT) !== false) {
+                        $newSubKey .= self::TAB_FILTER_NO_STUDENT;
+                    } elseif (strpos($row['subkey'], self::TAB_FILTER_ONLY_STUDENT) !== false) {
+                        $newSubKey .= self::TAB_FILTER_ONLY_STUDENT;
+                    }
+
+                    $attributes = ['subkey' => $newSubKey];
+
                     $this->updateTab($row['subkey'], $attributes);
                     $i++;
                 }