Fix reuse mass action in question_pool.php BT#17325

main/exercise/question_pool.php

@@ -1042,18 +1042,20 @@ $headers = [
 ];
 
 echo $pagination;
-echo '<form id="question_pool_id" method="get" action="'.$url.'">';
+
+$tableId = 'question_pool_id';
+echo '<form id="'.$tableId.'" method="get" action="'.$url.'">';
 echo '<input type="hidden" name="fromExercise" value="'.$fromExercise.'">';
 echo '<input type="hidden" name="cidReq" value="'.$_course['code'].'">';
 echo '<input type="hidden" name="selected_course" value="'.$selected_course.'">';
 echo '<input type="hidden" name="course_id" value="'.$selected_course.'">';
+echo '<input type="hidden" name="action">';
 
 $table = new HTML_Table(['class' => 'table table-bordered data_table'], false);
 $row = 0;
 $column = 0;
 foreach ($headers as $header) {
     $table->setHeaderContents($row, $column, $header);
-
     $column++;
 }
 
@@ -1076,19 +1078,25 @@ $table->display();
 
 echo '</form>';
 
-$tableId = 'question_pool_id';
 $html = '<div class="btn-toolbar">';
 $html .= '<div class="btn-group">';
-$html .= '<a class="btn btn-default" href="?'.$url.'selectall=1" onclick="javascript: setCheckbox(true, \''.$tableId.'\'); return false;">'.
-    get_lang('SelectAll').'</a>';
-$html .= '<a class="btn btn-default" href="?'.$url.'" onclick="javascript: setCheckbox(false, \''.$tableId.'\'); return false;">'.get_lang('UnSelectAll').'</a> ';
+$html .= '<a
+        class="btn btn-default"
+        href="?'.$url.'selectall=1"
+        onclick="javascript: setCheckbox(true, \''.$tableId.'\'); return false;">
+        '.get_lang('SelectAll').'</a>';
+$html .= '<a
+            class="btn btn-default"
+            href="?'.$url.'"
+            onclick="javascript: setCheckbox(false, \''.$tableId.'\'); return false;">
+            '.get_lang('UnSelectAll').'</a> ';
 $html .= '</div>';
 $html .= '<div class="btn-group">
             <button class="btn btn-default" onclick="javascript:return false;">'.get_lang('Actions').'</button>
             <button class="btn btn-default dropdown-toggle" data-toggle="dropdown">
                 <span class="caret"></span>
-            </button>';
-$html .= '<ul class="dropdown-menu">';
+            </button>
+            <ul class="dropdown-menu">';
 
 $actionLabel = get_lang('ReUseACopyInCurrentTest');
 $actions = ['clone' => get_lang('ReUseACopyInCurrentTest')];
@@ -1098,7 +1106,10 @@ if ($selected_course == api_get_course_int_id()) {
 
 foreach ($actions as $action => &$label) {
     $html .= '<li>
-            <a data-action ="'.$action.'" href="#" onclick="javascript:action_click(this, \''.$tableId.'\');">'.
+            <a
+                data-action ="'.$action.'"
+                href="#"
+                onclick="javascript:action_click(this, \''.$tableId.'\');">'.
                 $label.'
             </a>
           </li>';

main/template/default/layout/main.js.tpl

@@ -501,7 +501,7 @@ function setCheckbox(value, table_id) {
 }
 
 function action_click(element, table_id) {
-    d = $("#"+table_id);
+    var d = $("#"+table_id);
     if (!confirm('{{ "ConfirmYourChoice"|get_lang | escape('js')}}')) {
         return false;
     } else {