Remove limit_session_admin_role from conf file and use setting #2708

app/Migrations/Schema/V110/Version20150522222222.php

@@ -663,7 +663,7 @@ class Version20150522222222 extends AbstractMigrationChamilo
             '',
             'radio',
             'Session',
-            ($value?$value:'false'),
+            ($value?'true':'false'),
             'SessionAdminPermissionsLimitTitle',
             'SessionAdminPermissionsLimitComment',
             null,

main/admin/index.php

@@ -122,7 +122,7 @@ if (api_is_platform_admin()) {
     ];
 
     if (api_is_session_admin()) {
-        if (true === api_get_configuration_value('limit_session_admin_role')) {
+        if ('true' === api_get_setting('limit_session_admin_role')) {
             $items = array_filter($items, function (array $item) {
                 $urls = ['user_list.php', 'user_add.php'];
 

main/install/configuration.dist.php

@@ -411,8 +411,6 @@ ALTER TABLE portfolio_category CHANGE title title LONGTEXT NOT NULL;
 //$_configuration['session_admins_edit_courses_content'] = false;
 // Adds roles to the system announcements (requires DB change BT#12476)
 //$_configuration['system_announce_extra_roles'] = false;
-// Limits the features that a session admin has access to from the main admin panel (removes users import and usergroups)
-//$_configuration['limit_session_admin_role'] = false;
 // Limits that a session admin has access to list users
 //$_configuration['limit_session_admin_list_users'] = false;
 // Course tools visibility edition in sessions