Minor - format code, remove php warnings

main/inc/lib/message.lib.php

@@ -292,6 +292,7 @@ class MessageManager
                     
                 ";
         $result = Database::query($sql);
+
         return Database::num_rows($result) > 0;
     }
 

plugin/customcertificate/src/CustomCertificatePlugin.php

@@ -32,7 +32,7 @@ class CustomCertificatePlugin extends Plugin
     {
         parent::__construct(
             '1.0',
-            'Jose Angel Ruiz - NoSoloRed (original author)',
+            'Jose Angel Ruiz - NoSoloRed (original author), Julio Montoya',
             [
                 'enable_plugin_customcertificate' => 'boolean',
             ]
@@ -82,7 +82,7 @@ class CustomCertificatePlugin extends Plugin
     public function uninstall()
     {
         // Deleting course settings.
-        $this->uninstall_course_fields_in_all_courses($this->course_settings);
+        $this->uninstall_course_fields_in_all_courses();
 
         $tablesToBeDeleted = [self::TABLE_CUSTOMCERTIFICATE];
         foreach ($tablesToBeDeleted as $tableToBeDeleted) {
@@ -138,10 +138,9 @@ class CustomCertificatePlugin extends Plugin
                     'certificate_default' => 0,
                 ];
 
-                Database::insert(self::TABLE_CUSTOMCERTIFICATE, $params);
+                $certificateId = Database::insert(self::TABLE_CUSTOMCERTIFICATE, $params);
-                $certificateId = Database::insert_id();
 
-                //Image manager
+                // Image manager
                 $pathDestiny = $base.'certificates/'.$certificateId.'/';
 
                 if (!file_exists($pathDestiny)) {
@@ -172,8 +171,7 @@ class CustomCertificatePlugin extends Plugin
                     $params['c_id'] = 0;
                     $params['session_id'] = 0;
                     $params['certificate_default'] = 1;
-                    Database::insert(self::TABLE_CUSTOMCERTIFICATE, $params);
+                    $certificateId = Database::insert(self::TABLE_CUSTOMCERTIFICATE, $params);
-                    $certificateId = Database::insert_id();
                     $pathOrigin = $base.'certificates/default/';
                     $pathDestiny = $base.'certificates/'.$certificateId.'/';
                     foreach ($imgList as $value) {
@@ -205,7 +203,7 @@ class CustomCertificatePlugin extends Plugin
     {
         $id = (int) $id;
         if (empty($id)) {
-            return false;
+            return [];
         }
 
         $certificateTable = Database::get_main_table(TABLE_MAIN_GRADEBOOK_CERTIFICATE);
@@ -237,9 +235,8 @@ class CustomCertificatePlugin extends Plugin
      * Check if it redirects.
      *
      * @param certificate $certificate
-     * @param int         $id
+     * @param int         $certId
      *
-     * @return array
      */
     public function redirectCheck($certificate, $certId)
     {
@@ -268,6 +265,7 @@ class CustomCertificatePlugin extends Plugin
                     '&course_code='.$infoCertificate['course_code'].
                     '&session_id='.$infoCertificate['session_id'];
                 header('Location: '.$url);
+                exit;
             }
         }
     }

plugin/customcertificate/src/print_certificate.php

@@ -464,11 +464,12 @@ function getIndexFiltered($index)
     $txt = strip_tags($index, "<b><strong><i>");
     $txt = str_replace(chr(13).chr(10).chr(13).chr(10), chr(13).chr(10), $txt);
     $lines = explode(chr(13).chr(10), $txt);
-
+    $text1 = '';
     for ($x = 0; $x < 47; $x++) {
         $text1 .= $lines[$x].chr(13).chr(10);
     }
 
+    $text2 = '';
     for ($x = 47; $x < 94; $x++) {
         $text2 .= $lines[$x].chr(13).chr(10);
     }