Minor - Format code - refs BT#17549

main/exercise/exercise.class.php

@@ -3226,13 +3226,12 @@ class Exercise
                 $params['class'] .= ' no-header ';
             }
 
-            $html .= Display::url(
-                $urlTitle,
-                $url,
-                $params
-            );
+            $html .= Display::url($urlTitle, $url, $params);
             $html .= '<br />';
-        } else {
+
+            return $html;
+        }
+
         // User
         if (api_is_allowed_to_session_edit()) {
             $endReminderValue = false;
@@ -3257,8 +3256,7 @@ class Exercise
             // used to select it with jquery
             $class .= ' question-validate-btn';
             if ($this->type == ONE_PER_PAGE) {
-                    if ($questionNum != 1) {
-                        if ($this->showPreviousButton()) {
+                if ($questionNum != 1 && $this->showPreviousButton()) {
                     $prev_question = $questionNum - 2;
                     $showPreview = true;
                     if (!empty($myRemindList)) {
@@ -3297,7 +3295,6 @@ class Exercise
                         );
                     }
                 }
-                    }
 
                 // Next question
                 if (!empty($questions_in_media)) {
@@ -3317,9 +3314,9 @@ class Exercise
                         ['type' => 'button', 'class' => $class, 'data-question' => $question_id]
                     );
                 }
-                    $buttonList[] = '<span id="save_for_now_'.$question_id.'" class="exercise_save_mini_message"></span>&nbsp;';
+                $buttonList[] = '<span id="save_for_now_'.$question_id.'" class="exercise_save_mini_message"></span>';
 
-                    $html .= implode(PHP_EOL, $buttonList);
+                $html .= implode(PHP_EOL, $buttonList).PHP_EOL;
             } else {
                 if ($this->review_answers) {
                     $all_label = get_lang('ReviewQuestions');
@@ -3335,9 +3332,8 @@ class Exercise
                     $all_label,
                     ['type' => 'button', 'class' => $class]
                 );
-                    $buttonList[] = '&nbsp;'.Display::span(null, ['id' => 'save_all_response']);
-                    $html .= implode(PHP_EOL, $buttonList);
-                }
+                $buttonList[] = Display::span(null, ['id' => 'save_all_response']);
+                $html .= implode(PHP_EOL, $buttonList).PHP_EOL;
             }
         }