Portfolio: Advanced sharing allow to hide comment except for author - refs BT18201

main/inc/lib/PortfolioController.php

@@ -3259,6 +3259,7 @@ class PortfolioController
                 false
             )
         );
+        $form->addCheckBox('hidden', '', get_lang('HiddenButVisibleForMe'));
         $form->addButtonSave(get_lang('Save'));
 
         if ($form->validate()) {
@@ -3275,6 +3276,10 @@ class PortfolioController
                 ]
             );
 
+            if (empty($recipients) && empty($values['hidden'])) {
+                $comment->setVisibility(PortfolioComment::VISIBILITY_VISIBLE);
+            } else {
+                if (empty($values['hidden'])) {
                     foreach ($recipients as $userId) {
                         api_item_property_update(
                             $courseInfo,
@@ -3289,10 +3294,8 @@ class PortfolioController
                             $sessionId
                         );
                     }
+                }
 
-            if (empty($recipients)) {
-                $comment->setVisibility(PortfolioComment::VISIBILITY_VISIBLE);
-            } else {
                 $comment->setVisibility(PortfolioComment::VISIBILITY_PER_USER);
             }
 
@@ -3325,7 +3328,13 @@ class PortfolioController
             $result
         );
 
-        $form->setDefaults(['users' => $recipients]);
+        $defaults = ['users' => $recipients];
+
+        if (empty($recipients) && PortfolioComment::VISIBILITY_PER_USER === $comment->getVisibility()) {
+            $defaults['hidden'] = true;
+        }
+
+        $form->setDefaults($defaults);
         $form->protect();
 
         $interbreadcrumb[] = [