Add function visibility + fix PHP warning.

main/inc/lib/formvalidator/Rule/CompareFields.php

@@ -13,11 +13,12 @@ class HTML_QuickForm_Compare_Fields extends HTML_QuickForm_Rule_Compare
      * @param   string the value to compare
      * @return boolean True if date is valid
      */
-    function validate($values = [], $operator_and_max_value = null)
+    public function validate($values = [], $operator_and_max_value = null)
     {
         if (is_array($values) && !empty($values) && !empty($operator_and_max_value)) {
             $final_value = 0;
             foreach ($values as $value) {
+                $value = (float) $value;
                 $final_value += $value;
             }
             $params = explode('@', $operator_and_max_value);
@@ -29,4 +30,4 @@ class HTML_QuickForm_Compare_Fields extends HTML_QuickForm_Rule_Compare
 
         return false;
     }
-}
+}

main/inc/lib/pear/HTML/QuickForm/Rule.php

@@ -1,5 +1,4 @@
 <?php
-/* vim: set expandtab tabstop=4 shiftwidth=4 softtabstop=4: */
 
 /**
  * Abstract base class for QuickForm validation rules
@@ -42,7 +41,7 @@ class HTML_QuickForm_Rule
     * @var  string
     * @access   public
     */
-    var $name;
+    public $name;
 
    /**
     * Validates a value
@@ -78,4 +77,4 @@ class HTML_QuickForm_Rule
     {
         return array('', '');
     }
-}
+}

main/inc/lib/pear/HTML/QuickForm/Rule/Compare.php

@@ -76,7 +76,7 @@ class HTML_QuickForm_Rule_Compare extends HTML_QuickForm_Rule
      * @param string $operator
      * @return mixed
      */
-    function validate($values, $operator = null)
+    public function validate($values, $operator = null)
     {
         $operator = $this->_findOperator($operator);
         if ('===' != $operator && '!==' != $operator) {
@@ -87,8 +87,7 @@ class HTML_QuickForm_Rule_Compare extends HTML_QuickForm_Rule
         return $compareFn($values[0], $values[1]);
     }
 
-
+    public function getValidationScript($operator = null)
-    function getValidationScript($operator = null)
     {
         $operator = $this->_findOperator($operator);
         if ('===' != $operator && '!==' != $operator) {