Exercise: Don't limit query to get wrong answered questions - refs BT#19993

pull/4325/head
Angel Fernando Quiroz Campos 3 years ago
parent a91286ed33
commit e98088c835
  1. 4
      main/inc/lib/exercise.lib.php
  2. 2
      main/mySpace/question_stats_global_detail.php

@ -6408,11 +6408,10 @@ EOT;
return $total; return $total;
} }
public static function getWrongQuestionResults($courseId, $exerciseId, $sessionId = 0, $groups = [], $users = [], $limit = 10) public static function getWrongQuestionResults($courseId, $exerciseId, $sessionId = 0, $groups = [], $users = [])
{ {
$courseId = (int) $courseId; $courseId = (int) $courseId;
$exerciseId = (int) $exerciseId; $exerciseId = (int) $exerciseId;
$limit = (int) $limit;
$questionTable = Database::get_course_table(TABLE_QUIZ_QUESTION); $questionTable = Database::get_course_table(TABLE_QUIZ_QUESTION);
$attemptTable = Database::get_main_table(TABLE_STATISTIC_TRACK_E_ATTEMPT); $attemptTable = Database::get_main_table(TABLE_STATISTIC_TRACK_E_ATTEMPT);
@ -6459,7 +6458,6 @@ EOT;
$userCondition $userCondition
GROUP BY q.iid GROUP BY q.iid
ORDER BY count DESC ORDER BY count DESC
LIMIT $limit
"; ";
$result = Database::query($sql); $result = Database::query($sql);

@ -98,7 +98,7 @@ function getCourseSessionRow($courseId, Exercise $exercise, $sessionId, $title)
$sessionId $sessionId
); );
//$questions = ExerciseLib::getWrongQuestionResults($courseId, $exerciseId, $sessionId, 10); //$questions = ExerciseLib::getWrongQuestionResults($courseId, $exerciseId, $sessionId);
return [ return [
'title' => $title, 'title' => $title,
'correct_count' => $correctCount, 'correct_count' => $correctCount,

Loading…
Cancel
Save