Fixing code conventions details -refs #6680

main/admin/user_import.php

@@ -68,8 +68,8 @@ function validate_data($users) {
         // 4. Check classname
         $usergroup = new UserGroup();
         if (!empty($user['ClassName'])) {
-            $class_name = explode('|', trim($user['ClassName']));
-            foreach ($class_name as $class) {
+            $className = explode('|', trim($user['ClassName']));
+            foreach ($className as $class) {
                 if (!$usergroup->usergroup_exists($class)) {
                     $user['error'] = get_lang('ClassNameNotAvailable');
                     $errors[] = $user;
@@ -158,10 +158,10 @@ function save_data($users) {
             }
             $usergroup = new UserGroup();
             if (!empty($user['ClassName'])) {
-                $class_name = explode('|', trim($user['ClassName']));
-                foreach ($class_name as $class) {
-                    $class_id = $usergroup -> get_id_by_name($class);
-                    $usergroup -> add_user($user_id, $class_id);
+                $className = explode('|', trim($user['ClassName']));
+                foreach ($className as $class) {
+                    $classId = $usergroup->get_id_by_name($class);
+                    $usergroup->add_user($user_id, $classId);
                 }
                 
             }

main/admin/user_list.php

@@ -699,7 +699,7 @@ if (!empty($action)) {
 			case 'show_message' :
                 if (!empty($_GET['message'])) {
                     $message = Display :: return_message(stripslashes($_GET['message']), 'confirmation');
-                }
+                } else {
 
                     if (!empty($_GET['warn'])) {
                     	// to prevent too long messages
@@ -707,6 +707,7 @@ if (!empty($action)) {
                             $_GET['warn'] = $_SESSION['session_message_import_users'];
                     	}
                     	$message = Display::return_message(urldecode($_GET['warn']),'warning', false);
+                    }
                }
 
 				break;

main/inc/lib/usergroup.lib.php

@@ -781,12 +781,12 @@ class UserGroup extends Model
 	 * @param int $user_id The user id
 	 * @param int $class_id The class id
 	 */
-	function add_user($user_id, $class_id)
+	public function add_user($userId, $classId)
     {   
         $table_rel_user = Database::get_main_table(TABLE_USERGROUP_REL_USER);
-         $user_id  = intval($user_id);
-         $class_id = intval($class_id);
-	       $sql = "INSERT INTO $table_rel_user SET user_id = '".$user_id."', usergroup_id='".$class_id."'";
+        $userId  = intval($userId);
+        $classId = intval($classId);
+        $sql = "INSERT INTO $table_rel_user SET user_id = '".$userId."', usergroup_id='".$classId."'";
 	    Database::query($sql);
     }