Better check and handling of user creation

remotes/origin/stable45
Bart Visscher 13 years ago committed by Thomas Mueller
parent a12d3834d4
commit 3ed0960edb
  1. 2
      lib/user.php
  2. 7
      settings/ajax/createuser.php

@ -182,7 +182,7 @@ class OC_User {
$backend->createUser($uid,$password); $backend->createUser($uid,$password);
OC_Hook::emit( "OC_User", "post_createUser", array( "uid" => $uid, "password" => $password )); OC_Hook::emit( "OC_User", "post_createUser", array( "uid" => $uid, "password" => $password ));
return true; return self::userExists($uid);
} }
} }
return false; return false;

@ -37,14 +37,17 @@ $username = $_POST["username"];
$password = $_POST["password"]; $password = $_POST["password"];
// Does the group exist? // Does the group exist?
if( in_array( $username, OC_User::getUsers())) { if(OC_User::userExists($username)) {
OC_JSON::error(array("data" => array( "message" => "User already exists" ))); OC_JSON::error(array("data" => array( "message" => "User already exists" )));
exit(); exit();
} }
// Return Success story // Return Success story
try { try {
OC_User::createUser($username, $password); if (!OC_User::createUser($username, $password)) {
OC_JSON::error(array('data' => array( 'message' => 'User creation failed for '.$username )));
exit();
}
foreach( $groups as $i ) { foreach( $groups as $i ) {
if(!OC_Group::groupExists($i)) { if(!OC_Group::groupExists($i)) {
OC_Group::createGroup($i); OC_Group::createGroup($i);

Loading…
Cancel
Save