fix: removed unused variable and check if tag ids are empty before starting the inserts

Signed-off-by: yemkareems <yemkareems@gmail.com>
pull/45580/head
yemkareems 5 months ago committed by Marcel Klehr
parent d0883b5e85
commit 87cd78413c
  1. 7
      lib/private/SystemTag/SystemTagObjectMapper.php

@ -126,11 +126,16 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
$result = $query->executeQuery();
$rows = $result->fetchAll();
$existingTags = [];
foreach ($rows as $k => $row) {
foreach ($rows as $row) {
$existingTags[] = $row['systemtagid'];
}
//filter only tags that do not exist in db
$tagIds = array_diff($tagIds, $existingTags);
if (empty($tagIds)) {
// no tags to insert so return here
$this->connection->commit();
return;
}
$query = $this->connection->getQueryBuilder();
$query->insert(self::RELATION_TABLE)

Loading…
Cancel
Save