Fix comparisons in the dav app

Signed-off-by: Joas Schilling <coding@schilljs.com>

apps/dav/lib/CalDAV/CalDavBackend.php

@@ -1158,7 +1158,7 @@ class CalDavBackend extends AbstractBackend implements SyncSupport, Subscription
 				$requirePostFilter = false;
 			}
 			// There was a time-range filter
-			if ($componentType == 'VEVENT' && isset($filters['comp-filters'][0]['time-range'])) {
+			if ($componentType === 'VEVENT' && isset($filters['comp-filters'][0]['time-range'])) {
 				$timeRange = $filters['comp-filters'][0]['time-range'];
 
 				// If start time OR the end time is not specified, we can do a

apps/dav/lib/CalDAV/Search/SearchPlugin.php

@@ -134,7 +134,7 @@ class SearchPlugin extends ServerPlugin {
 
 		// If we're dealing with the calendar home, the calendar home itself is
 		// responsible for the calendar-query
-		if ($node instanceof CalendarHome && $depth == 2) {
+		if ($node instanceof CalendarHome && $depth === 2) {
 
 			$nodePaths = $node->calendarSearch($report->filters, $report->limit, $report->offset);
 
@@ -156,4 +156,4 @@ class SearchPlugin extends ServerPlugin {
 			$this->server->generateMultiStatus($result,
 				$prefer['return'] === 'minimal'));
 	}
-}
+}

apps/dav/lib/CardDAV/CardDavBackend.php

@@ -1019,7 +1019,7 @@ class CardDavBackend implements BackendInterface, SyncSupport {
 			}
 			$preferred = 0;
 			foreach($property->parameters as $parameter) {
-				if ($parameter->name == 'TYPE' && strtoupper($parameter->getValue()) == 'PREF') {
+				if ($parameter->name === 'TYPE' && strtoupper($parameter->getValue()) === 'PREF') {
 					$preferred = 1;
 					break;
 				}

apps/dav/lib/Connector/Sabre/Directory.php

@@ -225,7 +225,7 @@ class Directory extends \OCA\DAV\Connector\Sabre\Node
 			throw new \Sabre\DAV\Exception\NotFound('File with name ' . $path . ' could not be located');
 		}
 
-		if ($info['mimetype'] == 'httpd/unix-directory') {
+		if ($info['mimetype'] === 'httpd/unix-directory') {
 			$node = new \OCA\DAV\Connector\Sabre\Directory($this->fileView, $info, $this->tree, $this->shareManager);
 		} else {
 			$node = new \OCA\DAV\Connector\Sabre\File($this->fileView, $info, $this->shareManager);

apps/dav/lib/Connector/Sabre/File.php

@@ -147,7 +147,7 @@ class File extends Node implements IFile {
 			// compare expected and actual size
 			if (isset($_SERVER['CONTENT_LENGTH']) && $_SERVER['REQUEST_METHOD'] === 'PUT') {
 				$expected = $_SERVER['CONTENT_LENGTH'];
-				if ($count != $expected) {
+				if ($count !== $expected) {
 					throw new BadRequest('expected filesize ' . $expected . ' got ' . $count);
 				}
 			}
@@ -410,7 +410,7 @@ class File extends Node implements IFile {
 		if (isset ($_SERVER['REQUEST_METHOD']) && $_SERVER['REQUEST_METHOD'] === 'PUT') {
 			if (isset($_SERVER['CONTENT_LENGTH'])) {
 				$expected = $_SERVER['CONTENT_LENGTH'];
-				if ($bytesWritten != $expected) {
+				if ($bytesWritten !== $expected) {
 					$chunk_handler->remove($info['index']);
 					throw new BadRequest(
 						'expected filesize ' . $expected . ' got ' . $bytesWritten);

apps/dav/lib/Connector/Sabre/ObjectTree.php

@@ -81,7 +81,7 @@ class ObjectTree extends \Sabre\DAV\Tree {
 		if (isset($_SERVER['HTTP_OC_CHUNKED'])) {
 			// resolve to real file name to find the proper node
 			list($dir, $name) = \Sabre\Uri\split($path);
-			if ($dir == '/' || $dir == '.') {
+			if ($dir === '/' || $dir === '.') {
 				$dir = '';
 			}
 

apps/dav/lib/DAV/Sharing/Backend.php

@@ -170,7 +170,7 @@ class Backend {
 				'href' => "principal:${row['principaluri']}",
 				'commonName' => isset($p['{DAV:}displayname']) ? $p['{DAV:}displayname'] : '',
 				'status' => 1,
-				'readOnly' => ($row['access'] == self::ACCESS_READ),
+				'readOnly' => ((int) $row['access'] === self::ACCESS_READ),
 				'{http://owncloud.org/ns}principal' => $row['principaluri'],
 				'{http://owncloud.org/ns}group-share' => is_null($p)
 			];