fix populating account array with missing default values

- both $userData and $defaultUserData have numeric indices
- each element contains at least the name and other fields
- appending the missing data array is sufficient

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

lib/private/Accounts/AccountManager.php

@@ -473,15 +473,16 @@ class AccountManager implements IAccountManager {
 	 * Make sure that all expected data are set
 	 */
 	protected function addMissingDefaultValues(array $userData, array $defaultUserData): array {
-		foreach ($defaultUserData as $i => $value) {
+		foreach ($defaultUserData as $defaultDataItem) {
-			// If property doesn't exists, initialize it
+			// If property does not exist, initialize it
-			if (!array_key_exists($i, $userData)) {
+			$userDataIndex = array_search($defaultDataItem['name'], array_column($userData, 'name'));
-				$userData[$i] = [];
+			if ($userDataIndex === false) {
+				$userData[] = $defaultDataItem;
+				continue;
 			}
 
 			// Merge and extend default missing values
-			$defaultValueIndex = array_search($value['name'], array_column($defaultUserData, 'name'));
+			$userData[$userDataIndex] = array_merge($defaultDataItem, $userData[$userDataIndex]);
-			$userData[$i] = array_merge($defaultUserData[$defaultValueIndex], $userData[$i]);
 		}
 
 		return $userData;

tests/lib/Accounts/AccountManagerTest.php

@@ -516,8 +516,6 @@ class AccountManagerTest extends TestCase {
 				'value' => 'bob',
 				'verified' => IAccountManager::NOT_VERIFIED,
 			],
-			[],
-			[],
 			[
 				'name' => IAccountManager::PROPERTY_EMAIL,
 				'value' => 'bob@bob.bob',
@@ -533,23 +531,23 @@ class AccountManagerTest extends TestCase {
 			],
 
 			[
-				'name' => IAccountManager::PROPERTY_ADDRESS,
+				'name' => IAccountManager::PROPERTY_EMAIL,
-				'value' => '',
+				'value' => 'bob@bob.bob',
-				'scope' => IAccountManager::SCOPE_LOCAL,
+				'scope' => IAccountManager::SCOPE_FEDERATED,
 				'verified' => IAccountManager::NOT_VERIFIED,
 			],
 
 			[
-				'name' => IAccountManager::PROPERTY_WEBSITE,
+				'name' => IAccountManager::PROPERTY_ADDRESS,
 				'value' => '',
 				'scope' => IAccountManager::SCOPE_LOCAL,
 				'verified' => IAccountManager::NOT_VERIFIED,
 			],
 
 			[
-				'name' => IAccountManager::PROPERTY_EMAIL,
+				'name' => IAccountManager::PROPERTY_WEBSITE,
-				'value' => 'bob@bob.bob',
+				'value' => '',
-				'scope' => IAccountManager::SCOPE_FEDERATED,
+				'scope' => IAccountManager::SCOPE_LOCAL,
 				'verified' => IAccountManager::NOT_VERIFIED,
 			],