fix: Move hint about firewall issues to common helper string

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pull/45254/head
Ferdinand Thiessen 7 months ago
parent a5fc9b1563
commit ef320200b9
No known key found for this signature in database
GPG Key ID: 45FAE7268762B400
  1. 2
      apps/settings/lib/SetupChecks/CheckServerResponseTrait.php
  2. 2
      apps/settings/lib/SetupChecks/JavaScriptModules.php

@ -47,7 +47,7 @@ trait CheckServerResponseTrait {
* Common helper string in case a check could not fetch any results * Common helper string in case a check could not fetch any results
*/ */
protected function serverConfigHelp(): string { protected function serverConfigHelp(): string {
return $this->l10n->t('To allow this check to run you have to make sure that your webserver can connect to itself. Therefor it must be able to resolve and connect to at least one its `trusted_domains` or the `overwrite.cli.url`.'); return $this->l10n->t('To allow this check to run you have to make sure that your Web server can connect to itself. Therefore it must be able to resolve and connect to at least one of its `trusted_domains` or the `overwrite.cli.url`. This failure may be the result of a server-side DNS mismatch or outbound firewall rule.');
} }
/** /**

@ -68,7 +68,7 @@ class JavaScriptModules implements ISetupCheck {
} }
if ($noResponse) { if ($noResponse) {
return SetupResult::warning($this->l10n->t('Could not check for JavaScript support via any of your `trusted_domains` nor `overwrite.cli.url`. This may be the result of a server-side DNS mismatch or outbound firewall rule. Please check manually if your webserver serves `.mjs` files using the JavaScript MIME type.') . "\n" . $this->serverConfigHelp()); return SetupResult::warning($this->l10n->t('Unable to run check for JavaScript support. Please remedy or confirm manually if your webserver serves `.mjs` files using the JavaScript MIME type.') . "\n" . $this->serverConfigHelp());
} }
return SetupResult::error($this->l10n->t('Your webserver does not serve `.mjs` files using the JavaScript MIME type. This will break some apps by preventing browsers from executing the JavaScript files. You should configure your webserver to serve `.mjs` files with either the `text/javascript` or `application/javascript` MIME type.')); return SetupResult::error($this->l10n->t('Your webserver does not serve `.mjs` files using the JavaScript MIME type. This will break some apps by preventing browsers from executing the JavaScript files. You should configure your webserver to serve `.mjs` files with either the `text/javascript` or `application/javascript` MIME type.'));

Loading…
Cancel
Save