203 Commits (stable22)

Author	SHA1	Message	Date
Jonas	3fbd7a6602	Check whether entry is of type ICacheEntry in Cache->remove() ... In some scenarios (file not in cache, but partial data of it in the object), Cache->get() might return an array, which leads to errors like "Call to a member function getId() on array". So check whether the returned entry is of type ICacheEntry before doing operations on it in Cache->remove(). Fixes: #33023 Signed-off-by: Jonas <jonas@freesources.org>	4 years ago
Robin Appelman	0edce619c8	tell mysql to ignore the sort index for search queries ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Joas Schilling	4eff6b1c81	Deduplicate storage ids in list before reusing ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Robin Appelman	73a8ea2d4e	background scan the source storage when a background scan on a storage jail is triggered ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	c4fa59c540	properly handle cases where cache wrappers block access ... `CacheWrapper::formatCacheEntry` can return false for files that should be filtered out Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Vincent Petry	a721d346b9	Normalize directory entries in Encoding wrapper ... Directory entry file names are now normalized in getMetaData(), getDirectoryContents() and opendir(). This makes the scanner work properly as it assumes pre-normalized names. In case the names were not normalized, the scanner will now skip the entries and display a warning when applicable. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	2b4badf768	Move storage encoding compatibility warning logic ... The encoding check for file names is now happening the Scanner, and an event will be emitted only if the storage doesn't contain the encoding compatibility wrapper. The event is listened to by the occ scan command to be able to display a warning in case of file name mismatches when they have NFD encoding. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	787d7956cb	Normalize file name before existence check in scanner ... The scanner would not find a NFD-encoded file name in an existing file list that is normalized. This normalizes the file name before scanning. Fixes issues where scanning repeatedly would make NFD files flicker in and out of existence in the file cache. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Sijmen Schoon	071eda7baa	Move query outside the loop and reduce chunk size to 1000 ... This involved changing CacheQueryBuilder\whereParentIn to take a parameter name, renaming the function accordingly. Signed-off-by: Sijmen Schoon <me@sijmenschoon.nl>	4 years ago
Sijmen Schoon	ec3b1ccd91	Limit parameter count per query in Cache.removeChildren ... Signed-off-by: Sijmen Schoon <me@sijmenschoon.nl>	4 years ago
Carl Schwan	7bf4a45f49	Fix permissions when copying from ObjectStorage ... Make sure that when a user copy a file from a directory they don't have all permissions to a directory where they have more permissions, the permissions are correctly set to the one from the parent taget folder. This was caused by the ObjectStoreStorage::copyFromStorage using the jailed storage and cache entry instead of the unjailed one like other storages (the local one). Steps to reproduce + Use object storage + Create a groupfolder with one group having full permission and another one who can just read files. + With an user who is in the second group, copy a file from the groupfolder to the home folder of this user. + The file in the home folder of the user will be read only and can't be deleted even though it is in their home folder and they are the owner. In oc_filecache, the permissions stored for this file are 1 (READ) Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Robin Appelman	5f438375a9	more reliable return value for Watcher::checkUpdate ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	d4fb676dd7	generate a better optimized query for path prefix search filters ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	9e5440abc3	use getGetUnjailedRoot to determine if jailed search needs the path filter ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	5444db1ebf	use case insensitive like when limiting search to jail ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	1534b24e38	dont apply jail search filter is on the root ... the extra '/' breaks things and the filter wouldn't do anything anyway except making the databases job harder Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	362cb2a11f	inject SearchBuilder ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	66e10718c6	split of query building bits from searchhelper ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	f938daa6e4	update tests and fix some edge cases around new search ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	27e50b24aa	some cleanup and documentation ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	5d1d53c42e	perform file search in a single query ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	9774fb1573	use searchoperation for storage filter instead of db expression ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	e198dc1b20	rework search api to allow searching on multiple caches at once ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Robin Appelman	7ee528fc5a	properly use limit and offset for search in Jail wrapper ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	ed2396b045	better cleanup of filecache when deleting an external storage ... this way it can delete the cache entries even with per-user credentials Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Morris Jobke	81fef4ddee	Log when a storage is marked as unavailable ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
John Molakvoæ (skjnldsv)	2074d87d0c	Catch invalid cache source storage path ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Robin Appelman	50e374c12f	only require user to be set in a query that handles tags ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	d7748e2b4d	verify that cache entry is valid ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	c2fc3195dd	also implement for FailedCache and NullCache ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	d2bcb57a54	add ICopyFromCache trait to expose existing implementation ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	b844293536	catch notfound and forbidden exception in smb::getmetadata ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Roeland Jago Douma	c3f1eb4f7f	Remove Redundantcasts ... For #25839 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
dependabot-preview[bot]	eb502c02ff	Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 ... Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Robin Appelman	0363af3790	move AbstractCacheEvent into OCP ... otherwise we have concrete cache events in OCP extending non OCP classes Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	e511a539b7	adjust tests ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	5ae0be08b4	fix search in nested jails ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	27f9df2e87	fix cachjail searching for root ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	a44aab11f7	do cachejail search filtering in sql ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Christoph Wurst	8b64e92b92	Bump doctrine/dbal from 2.12.0 to 3.0.0 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Robin Appelman	205386b24e	ignore files that have no read permissions during scanning ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Christoph Wurst	9ce3ea3368	Update license headers ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Daniel Kesselberg	e0e76bb784	Limit getIncomplete query to one row ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
Robin Appelman	aef1cdba03	code style and dispatchTyped ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	88f35d52d2	rename cache event to follow new naming standards ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	23fb497ff5	extend cache events ... - adds cache remove event - expose storage id in event - emit events during cache move Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Joas Schilling	cffad62771	Empty string is returned as null, but empty string in file cache is the root and exists ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	8027dcbc6f	Don't leave cursors open when tests fail ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago