38462 Commits (8a1d3c7e877f143d211af259d08737c0d9aa8cfe)

 

All Branches   

Search

Author	SHA1	Message	Date
Lukas Reschke	b7fe28bba1	Fix indentation ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	8 years ago
Roeland Jago Douma	ad24b86013	Merge pull request #4350 from nextcloud/adjust-old-bruteforce-protection-annotations ... Adjust existing bruteforce protection code	8 years ago
Daniel Calviño Sánchez	50dfca8d8a	Make possible to specify a subset of the acceptance tests to run ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	ed7d63d16a	Add acceptance test steps to Drone ... Each acceptance test feature is run in its own Drone step. The container of the step runs the acceptance tests themselves, but they require two additional Drone services. One service provides the Selenium server that performs the web browser actions specified by the tests, and the other service provides the Nextcloud server that the tests will be run against (due to security concerns the acceptance tests themselves can not create Docker containers for the Nextcloud server as done when running them in a local system, as if Drone containers had access to Docker a malicious pull request could be used to take over the Drone server). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	be96be09b5	Add general multiplier for find timeouts ... Although the timeouts specified in the acceptance tests are enough in most cases they may not be when running them in a slow system or environment. For those situations a general multiplier for find timeouts is added. It can be set in the "behat.yml" configuration file to increase the timeout used in every find call (except those that used a timeout of 0, as in those cases the element had to be already present when finding it and whether the system is slow or not does not change that). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	a7e1833cf3	Add the timeout in NoSuchElementException messages ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	ff7d1bf1e7	Add NextcloudTestServerHelper for Nextcloud servers in Drone services ... Due to security concerns, the public Nextcloud server repository is not set as "trusted" in Drone (otherwise a malicious pull request could be used to take over the server), so it is not possible to create Docker containers from the containers started by Drone. Therefore, the Nextcloud server must be started as a service by Drone itself. The NextcloudTestServerDroneHelper is added to manage from the acceptance tests a Nextcloud test server running in a Drone service; to be able to control the remote Nextcloud server the Drone service must provide the Nextcloud server control server. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	c452390d59	Extract waiting for the server to start to the Utils class ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	34510b73a2	Extract installation and configuration of the Nextcloud server ... The installation and configuration of the Nextcloud server as expected by the acceptance tests is extracted to its own script so it can be used from any element that launches the acceptance tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	7de82615ff	Use NextcloudTestServerHelper in NextcloudTestServerContext ... Instead of depending on a Nextcloud test server created through Docker, NextcloudTestServerContext now uses the NextcloudTestServerHelper interface. This makes possible to provide other implementations of the interface for those cases in which using a Docker container is not a valid approach, like in the continuous integration system of the public repository due to security concerns. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	f10156f009	Extract NextcloudTestServerHelper interface ... The NextcloudTestServerHelper interface provides the needed methods to manage the Nextcloud server used in acceptance tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	4d71d37fe3	Reorganize method position inside class ... For consistency with the rest of private methods in the class, "isContainerRegistered" is moved below the only public method in which it is used ("cleanUp"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	03233b1d58	Hide methods not needed outside the class ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	8170b99561	Remove no longer needed methods ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	dead90f1cf	Move all Docker-related logic to NextcloudTestServerDockerHelper ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	38efa97aa5	Rename methods to something less tied to its implementation ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	c4613733eb	Add acceptance tests related to access levels ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	1203369ea6	Add acceptance tests related to login ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	6a15d9da9c	Add script to set up and run the acceptance tests ... The acceptance tests require several elements to be set up in order to be run. Besides those PHP packages that it depends on, like Behat or Mink, it requires a running Selenium server and a Docker image with the Nextcloud server to be tested available in the system. The "run.sh" script takes care of preparing all the needed elements and then run the acceptance tests; once finished, either normally or due to an error, it also cleans up the temporal elements created/started by the script and the acceptance tests. The Docker image with the Nextcloud server to be tested is created from the Nextcloud code in the greatparent directory each time "run.sh" is executed; the code is copied inside the image, so once the acceptance tests are started the code in the greatparent directory can be modified without affecting them. As it is based on the current code at the time of the launch that image is created and destroyed each time the acceptance tests are run. However, the image that it is based on, which is created using "docker/nextcloud-local-parent/Dockerfile", does not change between runs, so it is kept built in the system to speed up the launch of acceptance tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	b22997796b	Add wrappers to adapt the element finding system of Mink ... Mink elements (including the document element) provide a "find(selector, locator)" method to look for child elements in their web browser session. The Locator class is added to be able to store the selector and locator in a single object; it also provides a fluent API to ease the definition of Mink locators, specially those using the "named" selector. The method "find(locator, timeout, timeoutStep)" is added to Actor objects; it is simply a wrapper over Mink's "find(selector, locator)" method, although it throws an exception if the element can not be found instead of returning null, and it also makes possible to automatically retry to find the element for certain amount of time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	7c07f01d59	Add actors for test scenarios ... An actor plays the role of an end-user in the test scenario. As such, each actor has its own web browser session used to perform the actions specified by the steps of the scenario. Only one actor is active at a time in a test scenario, and the current actor can be set through the "I act as XXX" step; from then on, all the steps are performed by that actor, until a different actor is set by calling "I act as XXX" again. If no actor was explicitly set in a scenario then the default actor, unsurprisingly named "default", is the one used. The ActorContext class is added to provide automatic support for all that. To use the ActorContext, besides adding it to the context list in "behat.yml", a Mink session for each actor used in the features must be specified in "behat.yml". Once done other Contexts just need to implement the ActorAwareInterface (which can be done simply by using the ActorAware trait) to have access to the current Actor object of the test scenario; as the Actor object provides its own session other Contexts do not need to extend from RawMinkContext. The ActorContext is itself a RawMinkContext, so it automatically receives the base URL of the Nextcloud test server run by NextcloudTestServerContext and propagates that base URL to all the actors. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	4c620f1fcb	Add helper context to isolate the test server with Docker containers ... Scenarios in acceptance tests must be independent one of each other. That is, the execution of one scenario can not affect the execution of another scenario, nor it can depend on the result of the execution of a different scenario. Each scenario must be isolated and self-contained. As the acceptance tests are run against a Nextcloud server the server must be in a known and predefined initial state each time a scenario begins. The NextcloudTestServerContext is introduced to automatically set up the Nextcloud test server for each scenario. This can be achieved using Docker containers. Before an scenario begins a new Docker container with a Nextcloud server is run; the scenario is then run against the server provided by the container. When the scenario ends the container is destroyed. As long as the Nextcloud server uses local data storage each scenario is thus isolated from the rest. The NextcloudTestServerContext also notifies its sibling RawMinkContexts about the base URL of the Nextcloud test server being used in each scenario. Although it uses the Behat context system, NextcloudTestServerContext is not really part of the acceptance tests, but a provider of core features needed by them; it can be seen as part of a Nextcloud acceptance test library. Therefore, those classes are stored in the "core" directory instead of the "bootstrap" directory. Besides its own (quite limited) autoload configuration, Behat also uses the Composer autoloader, so the "core" directory has to be added there for its classes to be found by Behat. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	b5fba56499	Add basic files for the automated acceptance test system ... The acceptance tests verify that a Nextcloud server works as expected from the point of view of an end-user. They are specified as user stories using Behat paired with Mink, which provides web browser automation. Mink supports several browser emulators, but the system is set up to use Selenium, as it is FOSS and the one that better reflects the use of a web browser by an end-user (as, in fact, it controls real web browsers). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Morris Jobke	1dfd7de10e	Remove unused CSS styles ... * could not find an traces of .popup and .arrow anywhere else Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	6fa7e41047	Fix font-weight of settings button ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	74936e15d1	Remove unused CSS ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	f1ddb939a0	Merge pull request #4371 from nextcloud/dont-allow-dot-usernames ... Better validation of allowed user names	8 years ago
Nextcloud bot	febe01f571	[tx-robot] updated from transifex	8 years ago
Nextcloud bot	6b490f45fd	[tx-robot] updated from transifex	8 years ago
Morris Jobke	269600a04f	Merge pull request #4369 from nextcloud/fix-translations ... Fix translations	8 years ago
Morris Jobke	34e0b21f41	Merge pull request #3585 from nextcloud/popover-clickable-area ... expand clickable area of popover menu entries to full width	8 years ago
Morris Jobke	4b2d594c70	Merge pull request #4379 from nextcloud/nicely-designed-confirmation-mail ... Beautify test email	8 years ago
Jan-Christoph Borchardt	535ec04245	expand clickable area of popover menu entries to full width ... Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	8 years ago
Joas Schilling	1c0bffe87f	Fix translations ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Morris Jobke	47fe5e8f41	Merge pull request #4380 from nextcloud/show-instance-name-in-from ... Add instance name to default sender	8 years ago
Lukas Reschke	0a54d5a5dd	Beautify test email ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	8 years ago
Morris Jobke	d379ac7545	Merge pull request #4372 from nextcloud/smtp-password ... Don't put the SMTP password into the HTML code	8 years ago
Nextcloud bot	c40b7acb09	[tx-robot] updated from transifex	8 years ago
Lukas Reschke	203ef88509	Add "Reply-To" on ShareByMailProvider mails ... Fixes https://github.com/nextcloud/server/issues/4209 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	8 years ago
Morris Jobke	d2c4440ed6	Fix unit tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	2850f09bf2	Make group settings routes explicit ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	d12ec7cff1	Revert "Match slashes in ../{id} resource routes" ... This reverts commit 31f9be7a75. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Lukas Reschke	bae64e810e	Add instance name to default sender ... Otherwise your mail program shows "foo@mail.com" instead of "Nextcloud" or whatever your instance name is. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	8 years ago
Christoph Wurst	24f5c44e2b	Merge pull request #4376 from nextcloud/add-bruteforce-protection-to-change-self-password ... Add bruteforce protection to changePersonalPassword	8 years ago
Lukas Reschke	805419bb95	Add bruteforce protection to changePersonalPassword ... While the risk is actually quite low because one would already have the user session and could potentially do other havoc it makes sense to throttle here in case of invalid previous password attempts. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	8 years ago
Artur Neumann	bf58d24b5c	remove accidently left over *f*it ... Signed-off-by: Artur Neumann <info@individual-it.net>	8 years ago
Artur Neumann	88f02f27a3	JS tests for upload only function ... Signed-off-by: Artur Neumann <info@individual-it.net>	8 years ago
Artur Neumann	cdb65eff34	refactor to make it easier to test ... Signed-off-by: Artur Neumann <info@individual-it.net>	8 years ago
Joas Schilling	fcaa315c96	Fix some more stuff ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Joas Schilling	dfca672378	Fix tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago