|
|
|
|
/*
|
|
|
|
|
* controldata.c
|
|
|
|
|
*
|
|
|
|
|
* controldata functions
|
|
|
|
|
*
|
|
|
|
|
* Copyright (c) 2010-2021, PostgreSQL Global Development Group
|
|
|
|
|
* src/bin/pg_upgrade/controldata.c
|
|
|
|
|
*/
|
|
|
|
|
|
Create libpgcommon, and move pg_malloc et al to it
libpgcommon is a new static library to allow sharing code among the
various frontend programs and backend; this lets us eliminate duplicate
implementations of common routines. We avoid libpgport, because that's
intended as a place for porting issues; per discussion, it seems better
to keep them separate.
The first use case, and the only implemented by this patch, is pg_malloc
and friends, which many frontend programs were already using.
At the same time, we can use this to provide palloc emulation functions
for the frontend; this way, some palloc-using files in the backend can
also be used by the frontend cleanly. To do this, we change palloc() in
the backend to be a function instead of a macro on top of
MemoryContextAlloc(). This was previously believed to cause loss of
performance, but this implementation has been tweaked by Tom and Andres
so that on modern compilers it provides a slight improvement over the
previous one.
This lets us clean up some places that were already with
localized hacks.
Most of the pg_malloc/palloc changes in this patch were authored by
Andres Freund. Zoltán Böszörményi also independently provided a form of
that. libpgcommon infrastructure was authored by Álvaro.
13 years ago
|
|
|
#include "postgres_fe.h"
|
|
|
|
|
|
|
|
|
|
#include <ctype.h>
|
|
|
|
|
|
|
|
|
|
#include "pg_upgrade.h"
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* get_control_data()
|
|
|
|
|
*
|
|
|
|
|
* gets pg_control information in "ctrl". Assumes that bindir and
|
|
|
|
|
* datadir are valid absolute paths to postgresql bin and pgdata
|
|
|
|
|
* directories respectively *and* pg_resetwal is version compatible
|
|
|
|
|
* with datadir. The main purpose of this function is to get pg_control
|
|
|
|
|
* data in a version independent manner.
|
|
|
|
|
*
|
|
|
|
|
* The approach taken here is to invoke pg_resetwal with -n option
|
|
|
|
|
* and then pipe its output. With little string parsing we get the
|
|
|
|
|
* pg_control data. pg_resetwal cannot be run while the server is running
|
|
|
|
|
* so we use pg_controldata; pg_controldata doesn't provide all the fields
|
|
|
|
|
* we need to actually perform the upgrade, but it provides enough for
|
|
|
|
|
* check mode. We do not implement pg_resetwal -n because it is hard to
|
|
|
|
|
* return valid xid data for a running server.
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
get_control_data(ClusterInfo *cluster, bool live_check)
|
|
|
|
|
{
|
|
|
|
|
char cmd[MAXPGPATH];
|
|
|
|
|
char bufin[MAX_STRING];
|
|
|
|
|
FILE *output;
|
|
|
|
|
char *p;
|
|
|
|
|
bool got_tli = false;
|
|
|
|
|
bool got_log_id = false;
|
|
|
|
|
bool got_log_seg = false;
|
|
|
|
|
bool got_xid = false;
|
|
|
|
|
bool got_oid = false;
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
bool got_multi = false;
|
|
|
|
|
bool got_oldestmulti = false;
|
|
|
|
|
bool got_oldestxid = false;
|
|
|
|
|
bool got_mxoff = false;
|
|
|
|
|
bool got_nextxlogfile = false;
|
|
|
|
|
bool got_float8_pass_by_value = false;
|
|
|
|
|
bool got_align = false;
|
|
|
|
|
bool got_blocksz = false;
|
|
|
|
|
bool got_largesz = false;
|
|
|
|
|
bool got_walsz = false;
|
|
|
|
|
bool got_walseg = false;
|
|
|
|
|
bool got_ident = false;
|
|
|
|
|
bool got_index = false;
|
|
|
|
|
bool got_toast = false;
|
|
|
|
|
bool got_large_object = false;
|
|
|
|
|
bool got_date_is_int = false;
|
|
|
|
|
bool got_data_checksum_version = false;
|
|
|
|
|
bool got_cluster_state = false;
|
|
|
|
|
char *lc_collate = NULL;
|
|
|
|
|
char *lc_ctype = NULL;
|
|
|
|
|
char *lc_monetary = NULL;
|
|
|
|
|
char *lc_numeric = NULL;
|
|
|
|
|
char *lc_time = NULL;
|
|
|
|
|
char *lang = NULL;
|
|
|
|
|
char *language = NULL;
|
|
|
|
|
char *lc_all = NULL;
|
|
|
|
|
char *lc_messages = NULL;
|
|
|
|
|
uint32 tli = 0;
|
|
|
|
|
uint32 logid = 0;
|
|
|
|
|
uint32 segno = 0;
|
|
|
|
|
char *resetwal_bin;
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Because we test the pg_resetwal output as strings, it has to be in
|
|
|
|
|
* English. Copied from pg_regress.c.
|
|
|
|
|
*/
|
|
|
|
|
if (getenv("LC_COLLATE"))
|
|
|
|
|
lc_collate = pg_strdup(getenv("LC_COLLATE"));
|
|
|
|
|
if (getenv("LC_CTYPE"))
|
|
|
|
|
lc_ctype = pg_strdup(getenv("LC_CTYPE"));
|
|
|
|
|
if (getenv("LC_MONETARY"))
|
|
|
|
|
lc_monetary = pg_strdup(getenv("LC_MONETARY"));
|
|
|
|
|
if (getenv("LC_NUMERIC"))
|
|
|
|
|
lc_numeric = pg_strdup(getenv("LC_NUMERIC"));
|
|
|
|
|
if (getenv("LC_TIME"))
|
|
|
|
|
lc_time = pg_strdup(getenv("LC_TIME"));
|
|
|
|
|
if (getenv("LANG"))
|
|
|
|
|
lang = pg_strdup(getenv("LANG"));
|
|
|
|
|
if (getenv("LANGUAGE"))
|
|
|
|
|
language = pg_strdup(getenv("LANGUAGE"));
|
|
|
|
|
if (getenv("LC_ALL"))
|
|
|
|
|
lc_all = pg_strdup(getenv("LC_ALL"));
|
|
|
|
|
if (getenv("LC_MESSAGES"))
|
|
|
|
|
lc_messages = pg_strdup(getenv("LC_MESSAGES"));
|
|
|
|
|
|
Use setenv() in preference to putenv().
Since at least 2001 we've used putenv() and avoided setenv(), on the
grounds that the latter was unportable and not in POSIX. However,
POSIX added it that same year, and by now the situation has reversed:
setenv() is probably more portable than putenv(), since POSIX now
treats the latter as not being a core function. And setenv() has
cleaner semantics too. So, let's reverse that old policy.
This commit adds a simple src/port/ implementation of setenv() for
any stragglers (we have one in the buildfarm, but I'd not be surprised
if that code is never used in the field). More importantly, extend
win32env.c to also support setenv(). Then, replace usages of putenv()
with setenv(), and get rid of some ad-hoc implementations of setenv()
wannabees.
Also, adjust our src/port/ implementation of unsetenv() to follow the
POSIX spec that it returns an error indicator, rather than returning
void as per the ancient BSD convention. I don't feel a need to make
all the call sites check for errors, but the portability stub ought
to match real-world practice.
Discussion: https://postgr.es/m/2065122.1609212051@sss.pgh.pa.us
5 years ago
|
|
|
unsetenv("LC_COLLATE");
|
|
|
|
|
unsetenv("LC_CTYPE");
|
|
|
|
|
unsetenv("LC_MONETARY");
|
|
|
|
|
unsetenv("LC_NUMERIC");
|
|
|
|
|
unsetenv("LC_TIME");
|
|
|
|
|
#ifndef WIN32
|
Use setenv() in preference to putenv().
Since at least 2001 we've used putenv() and avoided setenv(), on the
grounds that the latter was unportable and not in POSIX. However,
POSIX added it that same year, and by now the situation has reversed:
setenv() is probably more portable than putenv(), since POSIX now
treats the latter as not being a core function. And setenv() has
cleaner semantics too. So, let's reverse that old policy.
This commit adds a simple src/port/ implementation of setenv() for
any stragglers (we have one in the buildfarm, but I'd not be surprised
if that code is never used in the field). More importantly, extend
win32env.c to also support setenv(). Then, replace usages of putenv()
with setenv(), and get rid of some ad-hoc implementations of setenv()
wannabees.
Also, adjust our src/port/ implementation of unsetenv() to follow the
POSIX spec that it returns an error indicator, rather than returning
void as per the ancient BSD convention. I don't feel a need to make
all the call sites check for errors, but the portability stub ought
to match real-world practice.
Discussion: https://postgr.es/m/2065122.1609212051@sss.pgh.pa.us
5 years ago
|
|
|
unsetenv("LANG");
|
|
|
|
|
#else
|
|
|
|
|
/* On Windows the default locale may not be English, so force it */
|
Use setenv() in preference to putenv().
Since at least 2001 we've used putenv() and avoided setenv(), on the
grounds that the latter was unportable and not in POSIX. However,
POSIX added it that same year, and by now the situation has reversed:
setenv() is probably more portable than putenv(), since POSIX now
treats the latter as not being a core function. And setenv() has
cleaner semantics too. So, let's reverse that old policy.
This commit adds a simple src/port/ implementation of setenv() for
any stragglers (we have one in the buildfarm, but I'd not be surprised
if that code is never used in the field). More importantly, extend
win32env.c to also support setenv(). Then, replace usages of putenv()
with setenv(), and get rid of some ad-hoc implementations of setenv()
wannabees.
Also, adjust our src/port/ implementation of unsetenv() to follow the
POSIX spec that it returns an error indicator, rather than returning
void as per the ancient BSD convention. I don't feel a need to make
all the call sites check for errors, but the portability stub ought
to match real-world practice.
Discussion: https://postgr.es/m/2065122.1609212051@sss.pgh.pa.us
5 years ago
|
|
|
setenv("LANG", "en", 1);
|
|
|
|
|
#endif
|
Use setenv() in preference to putenv().
Since at least 2001 we've used putenv() and avoided setenv(), on the
grounds that the latter was unportable and not in POSIX. However,
POSIX added it that same year, and by now the situation has reversed:
setenv() is probably more portable than putenv(), since POSIX now
treats the latter as not being a core function. And setenv() has
cleaner semantics too. So, let's reverse that old policy.
This commit adds a simple src/port/ implementation of setenv() for
any stragglers (we have one in the buildfarm, but I'd not be surprised
if that code is never used in the field). More importantly, extend
win32env.c to also support setenv(). Then, replace usages of putenv()
with setenv(), and get rid of some ad-hoc implementations of setenv()
wannabees.
Also, adjust our src/port/ implementation of unsetenv() to follow the
POSIX spec that it returns an error indicator, rather than returning
void as per the ancient BSD convention. I don't feel a need to make
all the call sites check for errors, but the portability stub ought
to match real-world practice.
Discussion: https://postgr.es/m/2065122.1609212051@sss.pgh.pa.us
5 years ago
|
|
|
unsetenv("LANGUAGE");
|
|
|
|
|
unsetenv("LC_ALL");
|
|
|
|
|
setenv("LC_MESSAGES", "C", 1);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Check for clean shutdown
|
|
|
|
|
*/
|
|
|
|
|
if (!live_check || cluster == &new_cluster)
|
|
|
|
|
{
|
|
|
|
|
/* only pg_controldata outputs the cluster state */
|
|
|
|
|
snprintf(cmd, sizeof(cmd), "\"%s/pg_controldata\" \"%s\"",
|
|
|
|
|
cluster->bindir, cluster->pgdata);
|
|
|
|
|
fflush(stdout);
|
|
|
|
|
fflush(stderr);
|
|
|
|
|
|
|
|
|
|
if ((output = popen(cmd, "r")) == NULL)
|
|
|
|
|
pg_fatal("could not get control data using %s: %s\n",
|
|
|
|
|
cmd, strerror(errno));
|
|
|
|
|
|
|
|
|
|
/* we have the result of cmd in "output". so parse it line by line now */
|
|
|
|
|
while (fgets(bufin, sizeof(bufin), output))
|
|
|
|
|
{
|
|
|
|
|
if ((p = strstr(bufin, "Database cluster state:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: database cluster state problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We checked earlier for a postmaster lock file, and if we
|
|
|
|
|
* found one, we tried to start/stop the server to replay the
|
|
|
|
|
* WAL. However, pg_ctl -m immediate doesn't leave a lock
|
|
|
|
|
* file, but does require WAL replay, so we check here that
|
|
|
|
|
* the server was shut down cleanly, from the controldata
|
|
|
|
|
* perspective.
|
|
|
|
|
*/
|
|
|
|
|
/* remove leading spaces */
|
|
|
|
|
while (*p == ' ')
|
|
|
|
|
p++;
|
|
|
|
|
if (strcmp(p, "shut down in recovery\n") == 0)
|
|
|
|
|
{
|
|
|
|
|
if (cluster == &old_cluster)
|
|
|
|
|
pg_fatal("The source cluster was shut down while in recovery mode. To upgrade, use \"rsync\" as documented or shut it down as a primary.\n");
|
|
|
|
|
else
|
|
|
|
|
pg_fatal("The target cluster was shut down while in recovery mode. To upgrade, use \"rsync\" as documented or shut it down as a primary.\n");
|
|
|
|
|
}
|
|
|
|
|
else if (strcmp(p, "shut down\n") != 0)
|
|
|
|
|
{
|
|
|
|
|
if (cluster == &old_cluster)
|
|
|
|
|
pg_fatal("The source cluster was not shut down cleanly.\n");
|
|
|
|
|
else
|
|
|
|
|
pg_fatal("The target cluster was not shut down cleanly.\n");
|
|
|
|
|
}
|
|
|
|
|
got_cluster_state = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
pclose(output);
|
|
|
|
|
|
|
|
|
|
if (!got_cluster_state)
|
|
|
|
|
{
|
|
|
|
|
if (cluster == &old_cluster)
|
|
|
|
|
pg_fatal("The source cluster lacks cluster state information:\n");
|
|
|
|
|
else
|
|
|
|
|
pg_fatal("The target cluster lacks cluster state information:\n");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* pg_resetxlog has been renamed to pg_resetwal in version 10 */
|
|
|
|
|
if (GET_MAJOR_VERSION(cluster->bin_version) <= 906)
|
|
|
|
|
resetwal_bin = "pg_resetxlog\" -n";
|
|
|
|
|
else
|
|
|
|
|
resetwal_bin = "pg_resetwal\" -n";
|
Replace SYSTEMQUOTEs with Windows-specific wrapper functions.
It's easy to forget using SYSTEMQUOTEs when constructing command strings
for system() or popen(). Even if we fix all the places missing it now, it is
bound to be forgotten again in the future. Introduce wrapper functions that
do the the extra quoting for you, and get rid of SYSTEMQUOTEs in all the
callers.
We previosly used SYSTEMQUOTEs in all the hard-coded command strings, and
this doesn't change the behavior of those. But user-supplied commands, like
archive_command, restore_command, COPY TO/FROM PROGRAM calls, as well as
pgbench's \shell, will now gain an extra pair of quotes. That is desirable,
but if you have existing scripts or config files that include an extra
pair of quotes, those might need to be adjusted.
Reviewed by Amit Kapila and Tom Lane
12 years ago
|
|
|
snprintf(cmd, sizeof(cmd), "\"%s/%s \"%s\"",
|
|
|
|
|
cluster->bindir,
|
|
|
|
|
live_check ? "pg_controldata\"" : resetwal_bin,
|
|
|
|
|
cluster->pgdata);
|
|
|
|
|
fflush(stdout);
|
|
|
|
|
fflush(stderr);
|
|
|
|
|
|
|
|
|
|
if ((output = popen(cmd, "r")) == NULL)
|
Improve error reporting in pg_upgrade's file copying/linking/rewriting.
The previous design for this had copyFile(), linkFile(), and
rewriteVisibilityMap() returning strerror strings, with the caller
producing one-size-fits-all error messages based on that. This made it
impossible to produce messages that described the failures with any degree
of precision, especially not short-read problems since those don't set
errno at all.
Since pg_upgrade has no intention of continuing after any error in this
area, let's fix this by just letting these functions call pg_fatal() for
themselves, making it easy for each point of failure to have a suitable
error message. Taking this approach also allows dropping cleanup code
that was unnecessary and was often rather sloppy about preserving errno.
To not lose relevant info that was reported before, pass in the schema name
and table name of the current table so that they can be included in the
error reports.
An additional problem was the use of getErrorText(), which was flat out
wrong for all but a couple of call sites, because it unconditionally did
"_dosmaperr(GetLastError())" on Windows. That's only appropriate when
reporting an error from a Windows-native API, which only a couple of
the callers were actually doing. Thus, even the reported strerror string
would be unrelated to the actual failure in many cases on Windows.
To fix, get rid of getErrorText() altogether, and just have call sites
do strerror(errno) instead, since that's the way all the rest of our
frontend programs do it. Add back the _dosmaperr() calls in the two
places where that's actually appropriate.
In passing, make assorted messages hew more closely to project style
guidelines, notably by removing initial capitals in not-complete-sentence
primary error messages. (I didn't make any effort to clean up places
I didn't have another reason to touch, though.)
Per discussion of a report from Thomas Kellerer. Back-patch to 9.6,
but no further; given the relative infrequency of reports of problems
here, it's not clear it's worth adapting the patch to older branches.
Patch by me, but with credit to Alvaro Herrera for spotting the issue
with getErrorText's misuse of _dosmaperr().
Discussion: <nsjrbh$8li$1@blaine.gmane.org>
9 years ago
|
|
|
pg_fatal("could not get control data using %s: %s\n",
|
|
|
|
|
cmd, strerror(errno));
|
|
|
|
|
|
|
|
|
|
/* Only in <= 9.2 */
|
|
|
|
|
if (GET_MAJOR_VERSION(cluster->major_version) <= 902)
|
|
|
|
|
{
|
|
|
|
|
cluster->controldata.data_checksum_version = 0;
|
|
|
|
|
got_data_checksum_version = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* we have the result of cmd in "output". so parse it line by line now */
|
|
|
|
|
while (fgets(bufin, sizeof(bufin), output))
|
|
|
|
|
{
|
|
|
|
|
pg_log(PG_VERBOSE, "%s", bufin);
|
|
|
|
|
|
|
|
|
|
if ((p = strstr(bufin, "pg_control version number:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: pg_resetwal problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.ctrl_ver = str2uint(p);
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Catalog version number:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.cat_ver = str2uint(p);
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's TimeLineID:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
tli = str2uint(p);
|
|
|
|
|
got_tli = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "First log file ID after reset:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
logid = str2uint(p);
|
|
|
|
|
got_log_id = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "First log file segment after reset:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
segno = str2uint(p);
|
|
|
|
|
got_log_seg = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's NextXID:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.chkpnt_nxtepoch = str2uint(p);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Delimiter changed from '/' to ':' in 9.6. We don't test for
|
|
|
|
|
* the catalog version of the change because the catalog version
|
|
|
|
|
* is pulled from pg_controldata too, and it isn't worth adding an
|
|
|
|
|
* order dependency for this --- we just check the string.
|
|
|
|
|
*/
|
|
|
|
|
if (strchr(p, '/') != NULL)
|
|
|
|
|
p = strchr(p, '/');
|
|
|
|
|
else if (GET_MAJOR_VERSION(cluster->major_version) >= 906)
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
else
|
|
|
|
|
p = NULL;
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove '/' or ':' char */
|
|
|
|
|
cluster->controldata.chkpnt_nxtxid = str2uint(p);
|
|
|
|
|
got_xid = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's NextOID:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.chkpnt_nxtoid = str2uint(p);
|
|
|
|
|
got_oid = true;
|
|
|
|
|
}
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's NextMultiXactId:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
cluster->controldata.chkpnt_nxtmulti = str2uint(p);
|
|
|
|
|
got_multi = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's oldestXID:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.chkpnt_oldstxid = str2uint(p);
|
|
|
|
|
got_oldestxid = true;
|
|
|
|
|
}
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's oldestMultiXid:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
cluster->controldata.chkpnt_oldstMulti = str2uint(p);
|
|
|
|
|
got_oldestmulti = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Latest checkpoint's NextMultiOffset:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
cluster->controldata.chkpnt_nxtmxoff = str2uint(p);
|
|
|
|
|
got_mxoff = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "First log segment after reset:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
/* Skip the colon and any whitespace after it */
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
p = strpbrk(p, "01234567890ABCDEF");
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
/* Make sure it looks like a valid WAL file name */
|
|
|
|
|
if (strspn(p, "0123456789ABCDEF") != 24)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
strlcpy(cluster->controldata.nextxlogfile, p, 25);
|
|
|
|
|
got_nextxlogfile = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Float8 argument passing:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
/* used later for contrib check */
|
|
|
|
|
cluster->controldata.float8_pass_by_value = strstr(p, "by value") != NULL;
|
|
|
|
|
got_float8_pass_by_value = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Maximum data alignment:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.align = str2uint(p);
|
|
|
|
|
got_align = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Database block size:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.blocksz = str2uint(p);
|
|
|
|
|
got_blocksz = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Blocks per segment of large relation:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.largesz = str2uint(p);
|
|
|
|
|
got_largesz = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "WAL block size:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.walsz = str2uint(p);
|
|
|
|
|
got_walsz = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Bytes per WAL segment:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.walseg = str2uint(p);
|
|
|
|
|
got_walseg = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Maximum length of identifiers:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.ident = str2uint(p);
|
|
|
|
|
got_ident = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Maximum columns in an index:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.index = str2uint(p);
|
|
|
|
|
got_index = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Maximum size of a TOAST chunk:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.toast = str2uint(p);
|
|
|
|
|
got_toast = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Size of a large-object chunk:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.large_object = str2uint(p);
|
|
|
|
|
got_large_object = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "Date/time type storage:")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
cluster->controldata.date_is_int = strstr(p, "64-bit integers") != NULL;
|
|
|
|
|
got_date_is_int = true;
|
|
|
|
|
}
|
|
|
|
|
else if ((p = strstr(bufin, "checksum")) != NULL)
|
|
|
|
|
{
|
|
|
|
|
p = strchr(p, ':');
|
|
|
|
|
|
|
|
|
|
if (p == NULL || strlen(p) <= 1)
|
|
|
|
|
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
|
|
|
|
|
|
|
|
|
|
p++; /* remove ':' char */
|
|
|
|
|
/* used later for contrib check */
|
|
|
|
|
cluster->controldata.data_checksum_version = str2uint(p);
|
|
|
|
|
got_data_checksum_version = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
pclose(output);
|
|
|
|
|
|
|
|
|
|
/*
|
Use setenv() in preference to putenv().
Since at least 2001 we've used putenv() and avoided setenv(), on the
grounds that the latter was unportable and not in POSIX. However,
POSIX added it that same year, and by now the situation has reversed:
setenv() is probably more portable than putenv(), since POSIX now
treats the latter as not being a core function. And setenv() has
cleaner semantics too. So, let's reverse that old policy.
This commit adds a simple src/port/ implementation of setenv() for
any stragglers (we have one in the buildfarm, but I'd not be surprised
if that code is never used in the field). More importantly, extend
win32env.c to also support setenv(). Then, replace usages of putenv()
with setenv(), and get rid of some ad-hoc implementations of setenv()
wannabees.
Also, adjust our src/port/ implementation of unsetenv() to follow the
POSIX spec that it returns an error indicator, rather than returning
void as per the ancient BSD convention. I don't feel a need to make
all the call sites check for errors, but the portability stub ought
to match real-world practice.
Discussion: https://postgr.es/m/2065122.1609212051@sss.pgh.pa.us
5 years ago
|
|
|
* Restore environment variables. Note all but LANG and LC_MESSAGES were
|
|
|
|
|
* unset above.
|
|
|
|
|
*/
|
Use setenv() in preference to putenv().
Since at least 2001 we've used putenv() and avoided setenv(), on the
grounds that the latter was unportable and not in POSIX. However,
POSIX added it that same year, and by now the situation has reversed:
setenv() is probably more portable than putenv(), since POSIX now
treats the latter as not being a core function. And setenv() has
cleaner semantics too. So, let's reverse that old policy.
This commit adds a simple src/port/ implementation of setenv() for
any stragglers (we have one in the buildfarm, but I'd not be surprised
if that code is never used in the field). More importantly, extend
win32env.c to also support setenv(). Then, replace usages of putenv()
with setenv(), and get rid of some ad-hoc implementations of setenv()
wannabees.
Also, adjust our src/port/ implementation of unsetenv() to follow the
POSIX spec that it returns an error indicator, rather than returning
void as per the ancient BSD convention. I don't feel a need to make
all the call sites check for errors, but the portability stub ought
to match real-world practice.
Discussion: https://postgr.es/m/2065122.1609212051@sss.pgh.pa.us
5 years ago
|
|
|
if (lc_collate)
|
|
|
|
|
setenv("LC_COLLATE", lc_collate, 1);
|
|
|
|
|
if (lc_ctype)
|
|
|
|
|
setenv("LC_CTYPE", lc_ctype, 1);
|
|
|
|
|
if (lc_monetary)
|
|
|
|
|
setenv("LC_MONETARY", lc_monetary, 1);
|
|
|
|
|
if (lc_numeric)
|
|
|
|
|
setenv("LC_NUMERIC", lc_numeric, 1);
|
|
|
|
|
if (lc_time)
|
|
|
|
|
setenv("LC_TIME", lc_time, 1);
|
|
|
|
|
if (lang)
|
|
|
|
|
setenv("LANG", lang, 1);
|
|
|
|
|
else
|
|
|
|
|
unsetenv("LANG");
|
|
|
|
|
if (language)
|
|
|
|
|
setenv("LANGUAGE", language, 1);
|
|
|
|
|
if (lc_all)
|
|
|
|
|
setenv("LC_ALL", lc_all, 1);
|
|
|
|
|
if (lc_messages)
|
|
|
|
|
setenv("LC_MESSAGES", lc_messages, 1);
|
|
|
|
|
else
|
|
|
|
|
unsetenv("LC_MESSAGES");
|
|
|
|
|
|
|
|
|
|
pg_free(lc_collate);
|
|
|
|
|
pg_free(lc_ctype);
|
|
|
|
|
pg_free(lc_monetary);
|
|
|
|
|
pg_free(lc_numeric);
|
|
|
|
|
pg_free(lc_time);
|
|
|
|
|
pg_free(lang);
|
|
|
|
|
pg_free(language);
|
|
|
|
|
pg_free(lc_all);
|
|
|
|
|
pg_free(lc_messages);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Before 9.3, pg_resetwal reported the xlogid and segno of the first log
|
|
|
|
|
* file after reset as separate lines. Starting with 9.3, it reports the
|
|
|
|
|
* WAL file name. If the old cluster is older than 9.3, we construct the
|
|
|
|
|
* WAL file name from the xlogid and segno.
|
|
|
|
|
*/
|
|
|
|
|
if (GET_MAJOR_VERSION(cluster->major_version) <= 902)
|
|
|
|
|
{
|
|
|
|
|
if (got_tli && got_log_id && got_log_seg)
|
|
|
|
|
{
|
|
|
|
|
snprintf(cluster->controldata.nextxlogfile, 25, "%08X%08X%08X",
|
|
|
|
|
tli, logid, segno);
|
|
|
|
|
got_nextxlogfile = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* verify that we got all the mandatory pg_control data */
|
|
|
|
|
if (!got_xid || !got_oid ||
|
|
|
|
|
!got_multi || !got_oldestxid ||
|
|
|
|
|
(!got_oldestmulti &&
|
|
|
|
|
cluster->controldata.cat_ver >= MULTIXACT_FORMATCHANGE_CAT_VER) ||
|
|
|
|
|
!got_mxoff || (!live_check && !got_nextxlogfile) ||
|
|
|
|
|
!got_float8_pass_by_value || !got_align || !got_blocksz ||
|
|
|
|
|
!got_largesz || !got_walsz || !got_walseg || !got_ident ||
|
|
|
|
|
!got_index || !got_toast ||
|
|
|
|
|
(!got_large_object &&
|
|
|
|
|
cluster->controldata.ctrl_ver >= LARGE_OBJECT_SIZE_PG_CONTROL_VER) ||
|
|
|
|
|
!got_date_is_int || !got_data_checksum_version)
|
|
|
|
|
{
|
|
|
|
|
if (cluster == &old_cluster)
|
|
|
|
|
pg_log(PG_REPORT,
|
|
|
|
|
"The source cluster lacks some required control information:\n");
|
|
|
|
|
else
|
|
|
|
|
pg_log(PG_REPORT,
|
|
|
|
|
"The target cluster lacks some required control information:\n");
|
|
|
|
|
|
|
|
|
|
if (!got_xid)
|
|
|
|
|
pg_log(PG_REPORT, " checkpoint next XID\n");
|
|
|
|
|
|
|
|
|
|
if (!got_oid)
|
|
|
|
|
pg_log(PG_REPORT, " latest checkpoint next OID\n");
|
|
|
|
|
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
if (!got_multi)
|
|
|
|
|
pg_log(PG_REPORT, " latest checkpoint next MultiXactId\n");
|
|
|
|
|
|
|
|
|
|
if (!got_oldestmulti &&
|
|
|
|
|
cluster->controldata.cat_ver >= MULTIXACT_FORMATCHANGE_CAT_VER)
|
Improve concurrency of foreign key locking
This patch introduces two additional lock modes for tuples: "SELECT FOR
KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each
other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
FOR UPDATE". UPDATE commands that do not modify the values stored in
the columns that are part of the key of the tuple now grab a SELECT FOR
NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
with tuple locks of the FOR KEY SHARE variety.
Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
means the concurrency improvement applies to them, which is the whole
point of this patch.
The added tuple lock semantics require some rejiggering of the multixact
module, so that the locking level that each transaction is holding can
be stored alongside its Xid. Also, multixacts now need to persist
across server restarts and crashes, because they can now represent not
only tuple locks, but also tuple updates. This means we need more
careful tracking of lifetime of pg_multixact SLRU files; since they now
persist longer, we require more infrastructure to figure out when they
can be removed. pg_upgrade also needs to be careful to copy
pg_multixact files over from the old server to the new, or at least part
of multixact.c state, depending on the versions of the old and new
servers.
Tuple time qualification rules (HeapTupleSatisfies routines) need to be
careful not to consider tuples with the "is multi" infomask bit set as
being only locked; they might need to look up MultiXact values (i.e.
possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
whereas they previously were assured to only use information readily
available from the tuple header. This is considered acceptable, because
the extra I/O would involve cases that would previously cause some
commands to block waiting for concurrent transactions to finish.
Another important change is the fact that locking tuples that have
previously been updated causes the future versions to be marked as
locked, too; this is essential for correctness of foreign key checks.
This causes additional WAL-logging, also (there was previously a single
WAL record for a locked tuple; now there are as many as updated copies
of the tuple there exist.)
With all this in place, contention related to tuples being checked by
foreign key rules should be much reduced.
As a bonus, the old behavior that a subtransaction grabbing a stronger
tuple lock than the parent (sub)transaction held on a given tuple and
later aborting caused the weaker lock to be lost, has been fixed.
Many new spec files were added for isolation tester framework, to ensure
overall behavior is sane. There's probably room for several more tests.
There were several reviewers of this patch; in particular, Noah Misch
and Andres Freund spent considerable time in it. Original idea for the
patch came from Simon Riggs, after a problem report by Joel Jacobson.
Most code is from me, with contributions from Marti Raudsepp, Alexander
Shulgin, Noah Misch and Andres Freund.
This patch was discussed in several pgsql-hackers threads; the most
important start at the following message-ids:
AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
1290721684-sup-3951@alvh.no-ip.org
1294953201-sup-2099@alvh.no-ip.org
1320343602-sup-2290@alvh.no-ip.org
1339690386-sup-8927@alvh.no-ip.org
4FE5FF020200002500048A3D@gw.wicourts.gov
4FEAB90A0200002500048B7D@gw.wicourts.gov
13 years ago
|
|
|
pg_log(PG_REPORT, " latest checkpoint oldest MultiXactId\n");
|
|
|
|
|
|
|
|
|
|
if (!got_oldestxid)
|
|
|
|
|
pg_log(PG_REPORT, " latest checkpoint oldestXID\n");
|
|
|
|
|
|
|
|
|
|
if (!got_mxoff)
|
|
|
|
|
pg_log(PG_REPORT, " latest checkpoint next MultiXactOffset\n");
|
|
|
|
|
|
|
|
|
|
if (!live_check && !got_nextxlogfile)
|
|
|
|
|
pg_log(PG_REPORT, " first WAL segment after reset\n");
|
|
|
|
|
|
|
|
|
|
if (!got_float8_pass_by_value)
|
|
|
|
|
pg_log(PG_REPORT, " float8 argument passing method\n");
|
|
|
|
|
|
|
|
|
|
if (!got_align)
|
|
|
|
|
pg_log(PG_REPORT, " maximum alignment\n");
|
|
|
|
|
|
|
|
|
|
if (!got_blocksz)
|
|
|
|
|
pg_log(PG_REPORT, " block size\n");
|
|
|
|
|
|
|
|
|
|
if (!got_largesz)
|
|
|
|
|
pg_log(PG_REPORT, " large relation segment size\n");
|
|
|
|
|
|
|
|
|
|
if (!got_walsz)
|
|
|
|
|
pg_log(PG_REPORT, " WAL block size\n");
|
|
|
|
|
|
|
|
|
|
if (!got_walseg)
|
|
|
|
|
pg_log(PG_REPORT, " WAL segment size\n");
|
|
|
|
|
|
|
|
|
|
if (!got_ident)
|
|
|
|
|
pg_log(PG_REPORT, " maximum identifier length\n");
|
|
|
|
|
|
|
|
|
|
if (!got_index)
|
|
|
|
|
pg_log(PG_REPORT, " maximum number of indexed columns\n");
|
|
|
|
|
|
|
|
|
|
if (!got_toast)
|
|
|
|
|
pg_log(PG_REPORT, " maximum TOAST chunk size\n");
|
|
|
|
|
|
|
|
|
|
if (!got_large_object &&
|
|
|
|
|
cluster->controldata.ctrl_ver >= LARGE_OBJECT_SIZE_PG_CONTROL_VER)
|
|
|
|
|
pg_log(PG_REPORT, " large-object chunk size\n");
|
|
|
|
|
|
|
|
|
|
if (!got_date_is_int)
|
|
|
|
|
pg_log(PG_REPORT, " dates/times are integers?\n");
|
|
|
|
|
|
|
|
|
|
/* value added in Postgres 9.3 */
|
|
|
|
|
if (!got_data_checksum_version)
|
|
|
|
|
pg_log(PG_REPORT, " data checksum version\n");
|
|
|
|
|
|
|
|
|
|
pg_fatal("Cannot continue without required control information, terminating\n");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* check_control_data()
|
|
|
|
|
*
|
|
|
|
|
* check to make sure the control data settings are compatible
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
check_control_data(ControlData *oldctrl,
|
|
|
|
|
ControlData *newctrl)
|
|
|
|
|
{
|
|
|
|
|
if (oldctrl->align == 0 || oldctrl->align != newctrl->align)
|
|
|
|
|
pg_fatal("old and new pg_controldata alignments are invalid or do not match\n"
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
8 years ago
|
|
|
"Likely one cluster is a 32-bit install, the other 64-bit\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->blocksz == 0 || oldctrl->blocksz != newctrl->blocksz)
|
|
|
|
|
pg_fatal("old and new pg_controldata block sizes are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->largesz == 0 || oldctrl->largesz != newctrl->largesz)
|
|
|
|
|
pg_fatal("old and new pg_controldata maximum relation segment sizes are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->walsz == 0 || oldctrl->walsz != newctrl->walsz)
|
|
|
|
|
pg_fatal("old and new pg_controldata WAL block sizes are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->walseg == 0 || oldctrl->walseg != newctrl->walseg)
|
|
|
|
|
pg_fatal("old and new pg_controldata WAL segment sizes are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->ident == 0 || oldctrl->ident != newctrl->ident)
|
|
|
|
|
pg_fatal("old and new pg_controldata maximum identifier lengths are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->index == 0 || oldctrl->index != newctrl->index)
|
|
|
|
|
pg_fatal("old and new pg_controldata maximum indexed columns are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->toast == 0 || oldctrl->toast != newctrl->toast)
|
|
|
|
|
pg_fatal("old and new pg_controldata maximum TOAST chunk sizes are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
/* large_object added in 9.5, so it might not exist in the old cluster */
|
|
|
|
|
if (oldctrl->large_object != 0 &&
|
|
|
|
|
oldctrl->large_object != newctrl->large_object)
|
|
|
|
|
pg_fatal("old and new pg_controldata large-object chunk sizes are invalid or do not match\n");
|
|
|
|
|
|
|
|
|
|
if (oldctrl->date_is_int != newctrl->date_is_int)
|
|
|
|
|
pg_fatal("old and new pg_controldata date/time storage types do not match\n");
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* float8_pass_by_value does not need to match, but is used in
|
|
|
|
|
* check_for_isn_and_int8_passing_mismatch().
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We might eventually allow upgrades from checksum to no-checksum
|
|
|
|
|
* clusters.
|
|
|
|
|
*/
|
|
|
|
|
if (oldctrl->data_checksum_version == 0 &&
|
|
|
|
|
newctrl->data_checksum_version != 0)
|
|
|
|
|
pg_fatal("old cluster does not use data checksums but the new one does\n");
|
|
|
|
|
else if (oldctrl->data_checksum_version != 0 &&
|
|
|
|
|
newctrl->data_checksum_version == 0)
|
|
|
|
|
pg_fatal("old cluster uses data checksums but the new one does not\n");
|
|
|
|
|
else if (oldctrl->data_checksum_version != newctrl->data_checksum_version)
|
|
|
|
|
pg_fatal("old and new cluster pg_controldata checksum versions do not match\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
disable_old_cluster(void)
|
|
|
|
|
{
|
|
|
|
|
char old_path[MAXPGPATH],
|
|
|
|
|
new_path[MAXPGPATH];
|
|
|
|
|
|
|
|
|
|
/* rename pg_control so old server cannot be accidentally started */
|
|
|
|
|
prep_status("Adding \".old\" suffix to old global/pg_control");
|
|
|
|
|
|
|
|
|
|
snprintf(old_path, sizeof(old_path), "%s/global/pg_control", old_cluster.pgdata);
|
|
|
|
|
snprintf(new_path, sizeof(new_path), "%s/global/pg_control.old", old_cluster.pgdata);
|
|
|
|
|
if (pg_mv_file(old_path, new_path) != 0)
|
|
|
|
|
pg_fatal("Unable to rename %s to %s.\n", old_path, new_path);
|
|
|
|
|
check_ok();
|
|
|
|
|
|
|
|
|
|
pg_log(PG_REPORT, "\n"
|
|
|
|
|
"If you want to start the old cluster, you will need to remove\n"
|
|
|
|
|
"the \".old\" suffix from %s/global/pg_control.old.\n"
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
8 years ago
|
|
|
"Because \"link\" mode was used, the old cluster cannot be safely\n"
|
|
|
|
|
"started once the new cluster has been started.\n\n", old_cluster.pgdata);
|
|
|
|
|
}
|
