doc: Apply more consistently <productname> markup for OpenSSL

OpenSSL was quoted in inconsistent ways in many places of the docs,
sometimes with <application>, <productname> or just nothing.

Author: Daniel Gustafsson
Discussion: https://postgr.es/m/DA91E5F0-5F9D-41A7-A7A6-B91CDE0F1D63@yesql.se

doc/src/sgml/config.sgml

@@ -1261,10 +1261,11 @@ include_dir 'conf.d'
           <term><literal>+3DES</literal></term>
           <listitem>
            <para>
-            The OpenSSL default order for <literal>HIGH</literal> is problematic
+            The <productname>OpenSSL</productname> default order for
-            because it orders 3DES higher than AES128.  This is wrong because
+            <literal>HIGH</literal> is problematic because it orders 3DES
-            3DES offers less security than AES128, and it is also much
+            higher than AES128.  This is wrong because 3DES offers less
-            slower.  <literal>+3DES</literal> reorders it after all other
+            security than AES128, and it is also much slower.
+            <literal>+3DES</literal> reorders it after all other
             <literal>HIGH</literal> and <literal>MEDIUM</literal> ciphers.
            </para>
           </listitem>
@@ -1284,8 +1285,8 @@ include_dir 'conf.d'
        </para>
 
        <para>
-        Available cipher suite details will vary across OpenSSL versions.  Use
+        Available cipher suite details will vary across
-        the command
+        <productname>OpenSSL</productname> versions.  Use the command
         <literal>openssl ciphers -v 'HIGH:MEDIUM:+3DES:!aNULL'</literal> to
         see actual details for the currently installed <application>OpenSSL</application>
         version.  Note that this list is filtered at run time based on the
@@ -1337,7 +1338,8 @@ include_dir 'conf.d'
        </para>
 
        <para>
-        OpenSSL names for the most common curves are:
+        <productname>OpenSSL</productname> names for the most common curves
+        are:
         <literal>prime256v1</literal> (NIST P-256),
         <literal>secp384r1</literal> (NIST P-384),
         <literal>secp521r1</literal> (NIST P-521).

doc/src/sgml/installation.sgml

@@ -2293,7 +2293,7 @@ ERROR:  could not load library "/opt/dbs/pgsql/lib/plperl.so": Bad address
 
      <listitem>
       <para>
-       OpenSSL is not supported.
+       <productname>OpenSSL</productname> is not supported.
       </para>
      </listitem>
 

doc/src/sgml/libpq.sgml

@@ -812,7 +812,8 @@ int callback_fn(char *buf, int size, PGconn *conn);
        its path will be in <literal>conn->sslkey</literal> when the callback
        is invoked. This will be empty if the default key path is being used.
        For keys that are engine specifiers, it is up to engine implementations
-       whether they use the OpenSSL password callback or define their own handling.
+       whether they use the <productname>OpenSSL</productname> password
+       callback or define their own handling.
       </para>
 
       <para>
@@ -1672,13 +1673,15 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
        <para>
         Specifying this parameter with any non-empty value suppresses the
         <literal>Enter PEM pass phrase:</literal>
-        prompt that OpenSSL will emit by default when an encrypted client
+        prompt that <productname>OpenSSL</productname> will emit by default
-        certificate key is provided to <literal>libpq</literal>.
+        when an encrypted client certificate key is provided to
+        <literal>libpq</literal>.
        </para>
        <para>
-        If the key is not encrypted this parameter is ignored. The parameter has no
+        If the key is not encrypted this parameter is ignored. The parameter
-        effect on keys specified by OpenSSL engines unless the engine uses the
+        has no effect on keys specified by <productname>OpenSSL</productname>
-        OpenSSL password callback mechanism for prompts.
+        engines unless the engine uses the <productname>OpenSSL</productname>
+        password callback mechanism for prompts.
        </para>
        <para>
         There is no environment variable equivalent to this option, and no
@@ -2471,8 +2474,9 @@ void *PQsslStruct(const PGconn *conn, const char *struct_name);
       </para>
       <para>
        The struct(s) available depend on the SSL implementation in use.
-       For OpenSSL, there is one struct, available under the name "OpenSSL",
+       For <productname>OpenSSL</productname>, there is one struct,
-       and it returns a pointer to the OpenSSL <literal>SSL</literal> struct.
+       available under the name "OpenSSL", and it returns a pointer to the
+       <productname>OpenSSL</productname> <literal>SSL</literal> struct.
        To use this function, code along the following lines could be used:
 <programlisting><![CDATA[
 #include <libpq-fe.h>
@@ -2516,8 +2520,9 @@ void *PQgetssl(const PGconn *conn);
       <para>
        This function is equivalent to <literal>PQsslStruct(conn, "OpenSSL")</literal>. It should
        not be used in new applications, because the returned struct is
-       specific to OpenSSL and will not be available if another SSL
+       specific to <productname>OpenSSL</productname> and will not be
-       implementation is used. To check if a connection uses SSL, call
+       available if another <acronym>SSL</acronym> implementation is used.
+       To check if a connection uses SSL, call
        <xref linkend="libpq-PQsslInUse"/> instead, and for more details about the
        connection, use <xref linkend="libpq-PQsslAttribute"/>.
       </para>
@@ -7665,15 +7670,17 @@ ldap://ldap.acme.com/cn=dbserver,cn=hosts?pgconnectinfo?base?(objectclass=*)
 
   <para>
    The key may be
-   stored in cleartext or encrypted with a passphrase using any algorithm supported
+   stored in cleartext or encrypted with a passphrase using any algorithm
-   by OpenSSL, like AES-128. If the key is stored encrypted, then the passphrase
+   supported by <productname>OpenSSL</productname>, like AES-128. If the key
-   may be provided in the <xref linkend="libpq-connect-sslpassword"/> connection
+   is stored encrypted, then the passphrase may be provided in the
-   option. If an encrypted key is supplied and the <literal>sslpassword</literal>
+   <xref linkend="libpq-connect-sslpassword"/> connection option. If an
-   option is absent or blank, a password will be prompted for interactively by
+   encrypted key is supplied and the <literal>sslpassword</literal> option
-   OpenSSL with a <literal>Enter PEM pass phrase:</literal>
+   is absent or blank, a password will be prompted for interactively by
-   prompt if a TTY is available. Applications can override the client certificate
+   <productname>OpenSSL</productname> with a
-   prompt and the handling of the <literal>sslpassword</literal> parameter by supplying
+   <literal>Enter PEM pass phrase:</literal> prompt if a TTY is available.
-   their own key password callback; see
+   Applications can override the client certificate prompt and the handling
+   of the <literal>sslpassword</literal> parameter by supplying their own
+   key password callback; see
    <xref linkend="libpq-pqsetsslkeypasshook-openssl"/>.
   </para>
 
@@ -7936,7 +7943,7 @@ void PQinitOpenSSL(int do_ssl, int do_crypto);
 
       <para>
        When <parameter>do_ssl</parameter> is non-zero, <application>libpq</application>
-       will initialize the <application>OpenSSL</application> library before first
+       will initialize the <productname>OpenSSL</productname> library before first
        opening a database connection.  When <parameter>do_crypto</parameter> is
        non-zero, the <literal>libcrypto</literal> library will be initialized.  By
        default (if <xref linkend="libpq-PQinitOpenSSL"/> is not called), both libraries
@@ -7945,7 +7952,7 @@ void PQinitOpenSSL(int do_ssl, int do_crypto);
       </para>
 
       <para>
-       If your application uses and initializes either <application>OpenSSL</application>
+       If your application uses and initializes either <productname>OpenSSL</productname>
        or its underlying <literal>libcrypto</literal> library, you <emphasis>must</emphasis>
        call this function with zeroes for the appropriate parameter(s)
        before first opening a database connection.  Also be sure that you
@@ -7967,7 +7974,7 @@ void PQinitSSL(int do_ssl);
        This function is equivalent to
        <literal>PQinitOpenSSL(do_ssl, do_ssl)</literal>.
        It is sufficient for applications that initialize both or neither
-       of <application>OpenSSL</application> and <literal>libcrypto</literal>.
+       of <productname>OpenSSL</productname> and <literal>libcrypto</literal>.
       </para>
 
       <para>

doc/src/sgml/pgcrypto.sgml

@@ -45,8 +45,8 @@ digest(data bytea, type text) returns bytea
     <literal>sha224</literal>, <literal>sha256</literal>,
     <literal>sha384</literal> and <literal>sha512</literal>.
     If <filename>pgcrypto</filename> was built with
-    OpenSSL, more algorithms are available, as detailed in
+    <productname>OpenSSL</productname>, more algorithms are available, as
-    <xref linkend="pgcrypto-with-without-openssl"/>.
+    detailed in <xref linkend="pgcrypto-with-without-openssl"/>.
    </para>
 
    <para>
@@ -1162,9 +1162,10 @@ gen_random_uuid() returns uuid
    </para>
 
    <para>
-    When compiled with OpenSSL, there will be more algorithms available.
+    When compiled with <productname>OpenSSL</productname>, there will be
-    Also public-key encryption functions will be faster as OpenSSL
+    more algorithms available. Also public-key encryption functions will
-    has more optimized BIGNUM functions.
+    be faster as <productname>OpenSSL</productname> has more optimized
+    BIGNUM functions.
    </para>
 
    <table id="pgcrypto-with-without-openssl">
@@ -1239,7 +1240,8 @@ gen_random_uuid() returns uuid
    <orderedlist>
     <listitem>
      <para>
-      Any digest algorithm OpenSSL supports is automatically picked up.
+      Any digest algorithm <productname>OpenSSL</productname> supports
+      is automatically picked up.
       This is not possible with ciphers, which need to be supported
       explicitly.
      </para>

doc/src/sgml/sslinfo.sgml

@@ -173,8 +173,8 @@
     <para>
      This function returns the value of the specified field in the
      certificate subject, or NULL if the field is not present.
-     Field names are string constants that are
+     Field names are string constants that are converted into ASN1 object
-     converted into ASN1 object identifiers using the OpenSSL object
+     identifiers using the <productname>OpenSSL</productname> object
      database.  The following values are acceptable:
     </para>
 <literallayout class="monospaced">