Update a code comment

The comment explained that ALTER TABLE ADD CONSTRAINT USING INDEX is
only supported with a btree index.  (This is not being changed.)  The
reason is to keep upgrades robust, as explained there.  The other part
of the comment, that btree is the only unique index kind anyway, is
somewhat less true as we're trying to enable unique indexes other than
btree, and it's irrelevant to this check.  There is a check for
indisunique earlier already.  So just remove this part of the comment.

Author: Mark Dilger <mark.dilger@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330@enterprisedb.com
pull/207/head
Peter Eisentraut 6 months ago
parent 4f7f7b0375
commit 190dc27998
  1. 9
      src/backend/parser/parse_utilcmd.c

@ -2486,11 +2486,10 @@ transformIndexConstraint(Constraint *constraint, CreateStmtContext *cxt)
parser_errposition(cxt->pstate, constraint->location))); parser_errposition(cxt->pstate, constraint->location)));
/* /*
* Insist on it being a btree. That's the only kind that supports * Insist on it being a btree. We must have an index that exactly
* uniqueness at the moment anyway; but we must have an index that * matches what you'd get from plain ADD CONSTRAINT syntax, else dump
* exactly matches what you'd get from plain ADD CONSTRAINT syntax, * and reload will produce a different index (breaking pg_upgrade in
* else dump and reload will produce a different index (breaking * particular).
* pg_upgrade in particular).
*/ */
if (index_rel->rd_rel->relam != get_index_am_oid(DEFAULT_INDEX_TYPE, false)) if (index_rel->rd_rel->relam != get_index_am_oid(DEFAULT_INDEX_TYPE, false))
ereport(ERROR, ereport(ERROR,

Loading…
Cancel
Save