mirror of https://github.com/postgres/postgres
This new DDL command splits a single partition into several partitions. Just like the ALTER TABLE ... MERGE PARTITIONS ... command, new partitions are created using the createPartitionTable() function with the parent partition as the template. This commit comprises a quite naive implementation which works in a single process and holds the ACCESS EXCLUSIVE LOCK on the parent table during all the operations, including the tuple routing. This is why the new DDL command can't be recommended for large, partitioned tables under high load. However, this implementation comes in handy in certain cases, even as it is. Also, it could serve as a foundation for future implementations with less locking and possibly parallelism. Discussion: https://postgr.es/m/c73a1746-0cd0-6bdd-6b23-3ae0b7c0c582%40postgrespro.ru Author: Dmitry Koval <d.koval@postgrespro.ru> Co-authored-by: Alexander Korotkov <aekorotkov@gmail.com> Co-authored-by: Tender Wang <tndrwang@gmail.com> Co-authored-by: Richard Guo <guofenglinux@gmail.com> Co-authored-by: Dagfinn Ilmari Mannsaker <ilmari@ilmari.org> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Co-authored-by: Jian He <jian.universality@gmail.com> Reviewed-by: Matthias van de Meent <boekewurm+postgres@gmail.com> Reviewed-by: Laurenz Albe <laurenz.albe@cybertec.at> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Justin Pryzby <pryzby@telsasoft.com> Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Robert Haas <rhaas@postgresql.org> Reviewed-by: Stephane Tachoires <stephane.tachoires@gmail.com> Reviewed-by: Jian He <jian.universality@gmail.com> Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com> Reviewed-by: Pavel Borisov <pashkin.elfe@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Alexander Lakhin <exclusion@gmail.com> Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reviewed-by: Daniel Gustafsson <dgustafsson@postgresql.org> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Noah Misch <noah@leadboat.com>pull/258/head
Alexander Korotkov
4 days ago
parent
f2e4cc4279
commit
4b3d173629
@ -0,0 +1,230 @@ |
|||||||
|
Parsed test spec with 2 sessions |
||||||
|
|
||||||
|
starting permutation: s1b s1splt s2b s2i s1c s2c s2s |
||||||
|
step s1b: BEGIN; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2b: BEGIN; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1b s1splt s2brr s2i s1c s2c s2s |
||||||
|
step s1b: BEGIN; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2brr: BEGIN ISOLATION LEVEL REPEATABLE READ; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1b s1splt s2bs s2i s1c s2c s2s |
||||||
|
step s1b: BEGIN; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2bs: BEGIN ISOLATION LEVEL SERIALIZABLE; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1brr s1splt s2b s2i s1c s2c s2s |
||||||
|
step s1brr: BEGIN ISOLATION LEVEL REPEATABLE READ; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2b: BEGIN; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1brr s1splt s2brr s2i s1c s2c s2s |
||||||
|
step s1brr: BEGIN ISOLATION LEVEL REPEATABLE READ; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2brr: BEGIN ISOLATION LEVEL REPEATABLE READ; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1brr s1splt s2bs s2i s1c s2c s2s |
||||||
|
step s1brr: BEGIN ISOLATION LEVEL REPEATABLE READ; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2bs: BEGIN ISOLATION LEVEL SERIALIZABLE; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1bs s1splt s2b s2i s1c s2c s2s |
||||||
|
step s1bs: BEGIN ISOLATION LEVEL SERIALIZABLE; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2b: BEGIN; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1bs s1splt s2brr s2i s1c s2c s2s |
||||||
|
step s1bs: BEGIN ISOLATION LEVEL SERIALIZABLE; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2brr: BEGIN ISOLATION LEVEL REPEATABLE READ; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1bs s1splt s2bs s2i s1c s2c s2s |
||||||
|
step s1bs: BEGIN ISOLATION LEVEL SERIALIZABLE; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2bs: BEGIN ISOLATION LEVEL SERIALIZABLE; |
||||||
|
step s2i: INSERT INTO tpart VALUES (1, 'text01'); <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2i: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 1|text01 |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(5 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1b s1splt s2b s2u s1c s2c s2s |
||||||
|
step s1b: BEGIN; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2b: BEGIN; |
||||||
|
step s2u: UPDATE tpart SET i = 16 where i = 5; <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2u: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_15_20 |15|text15 |
||||||
|
tpart_15_20 |16|text05 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(4 rows) |
||||||
|
|
||||||
|
|
||||||
|
starting permutation: s1b s1splt s2b s2u2 s1c s2c s2s |
||||||
|
step s1b: BEGIN; |
||||||
|
step s1splt: ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); |
||||||
|
step s2b: BEGIN; |
||||||
|
step s2u2: UPDATE tpart SET i = 11 where i = 15; <waiting ...> |
||||||
|
step s1c: COMMIT; |
||||||
|
step s2u2: <... completed> |
||||||
|
step s2c: COMMIT; |
||||||
|
step s2s: SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; |
||||||
|
tableoid | i|t |
||||||
|
-------------+--+------ |
||||||
|
tpart_00_10 | 5|text05 |
||||||
|
tpart_10_15 |11|text15 |
||||||
|
tpart_20_30 |25|text25 |
||||||
|
tpart_default|35|text35 |
||||||
|
(4 rows) |
||||||
|
|
||||||
@ -0,0 +1,62 @@ |
|||||||
|
# Verify that SPLIT operation locks DML operations with partitioned table |
||||||
|
|
||||||
|
setup |
||||||
|
{ |
||||||
|
DROP TABLE IF EXISTS tpart; |
||||||
|
CREATE TABLE tpart(i int, t text) partition by range(i); |
||||||
|
CREATE TABLE tpart_00_10 PARTITION OF tpart FOR VALUES FROM (0) TO (10); |
||||||
|
CREATE TABLE tpart_10_20 PARTITION OF tpart FOR VALUES FROM (10) TO (20); |
||||||
|
CREATE TABLE tpart_20_30 PARTITION OF tpart FOR VALUES FROM (20) TO (30); |
||||||
|
CREATE TABLE tpart_default PARTITION OF tpart DEFAULT; |
||||||
|
INSERT INTO tpart VALUES (5, 'text05'); |
||||||
|
INSERT INTO tpart VALUES (15, 'text15'); |
||||||
|
INSERT INTO tpart VALUES (25, 'text25'); |
||||||
|
INSERT INTO tpart VALUES (35, 'text35'); |
||||||
|
} |
||||||
|
|
||||||
|
teardown |
||||||
|
{ |
||||||
|
DROP TABLE tpart; |
||||||
|
} |
||||||
|
|
||||||
|
session s1 |
||||||
|
step s1b { BEGIN; } |
||||||
|
step s1brr { BEGIN ISOLATION LEVEL REPEATABLE READ; } |
||||||
|
step s1bs { BEGIN ISOLATION LEVEL SERIALIZABLE; } |
||||||
|
step s1splt { ALTER TABLE tpart SPLIT PARTITION tpart_10_20 INTO |
||||||
|
(PARTITION tpart_10_15 FOR VALUES FROM (10) TO (15), |
||||||
|
PARTITION tpart_15_20 FOR VALUES FROM (15) TO (20)); } |
||||||
|
step s1c { COMMIT; } |
||||||
|
|
||||||
|
|
||||||
|
session s2 |
||||||
|
step s2b { BEGIN; } |
||||||
|
step s2brr { BEGIN ISOLATION LEVEL REPEATABLE READ; } |
||||||
|
step s2bs { BEGIN ISOLATION LEVEL SERIALIZABLE; } |
||||||
|
step s2i { INSERT INTO tpart VALUES (1, 'text01'); } |
||||||
|
step s2c { COMMIT; } |
||||||
|
step s2s { SELECT tableoid::regclass, * FROM tpart ORDER BY tableoid::regclass::text COLLATE "C", i; } |
||||||
|
step s2u { UPDATE tpart SET i = 16 where i = 5; } |
||||||
|
step s2u2 { UPDATE tpart SET i = 11 where i = 15; } |
||||||
|
|
||||||
|
|
||||||
|
# s1 starts SPLIT PARTITION then s2 trying to insert row and |
||||||
|
# waits until s1 finished SPLIT operation. |
||||||
|
|
||||||
|
permutation s1b s1splt s2b s2i s1c s2c s2s |
||||||
|
permutation s1b s1splt s2brr s2i s1c s2c s2s |
||||||
|
permutation s1b s1splt s2bs s2i s1c s2c s2s |
||||||
|
|
||||||
|
permutation s1brr s1splt s2b s2i s1c s2c s2s |
||||||
|
permutation s1brr s1splt s2brr s2i s1c s2c s2s |
||||||
|
permutation s1brr s1splt s2bs s2i s1c s2c s2s |
||||||
|
|
||||||
|
permutation s1bs s1splt s2b s2i s1c s2c s2s |
||||||
|
permutation s1bs s1splt s2brr s2i s1c s2c s2s |
||||||
|
permutation s1bs s1splt s2bs s2i s1c s2c s2s |
||||||
|
|
||||||
|
# Tuple routing between partitions. |
||||||
|
permutation s1b s1splt s2b s2u s1c s2c s2s |
||||||
|
|
||||||
|
# Tuple routing inside splitting partition. |
||||||
|
permutation s1b s1splt s2b s2u2 s1c s2c s2s |
||||||
File diff suppressed because it is too large
Load Diff
File diff suppressed because it is too large
Load Diff
Loading…
Reference in new issue