mirror of https://github.com/postgres/postgres
Remove unstable test suite added by 525392d57
The 'cached-plan-inval' test suite, introduced in 525392d57 under
src/test/modules/delay_execution, aimed to verify that cached plan
invalidation triggers replanning after deferred locks are taken.
However, its ExecutorStart_hook-based approach relies on lock timing
assumptions that, in retrospect, are fragile. This instability was
exposed by failures on BF animal trilobite, which builds with
CLOBBER_CACHE_ALWAYS.
One option was to dynamically disable the cache behavior that causes
the test suite to fail by setting "debug_discard_caches = 0", but it
seems better to remove the suite. The risk of future failures due to
other cache flush hazards outweighs the benefit of catching real
breakage in the backend behavior it tests.
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/2990641.1740117879@sss.pgh.pa.us
pull/200/head
Amit Langote
7 months ago
parent
f8d7f29b3e
commit
4f1b6e5bb4
@ -1,250 +0,0 @@ |
||||
Parsed test spec with 2 sessions |
||||
|
||||
starting permutation: s1prep s2lock s1exec s2dropi s2unlock |
||||
step s1prep: SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q AS SELECT * FROM foov WHERE a = $1 FOR UPDATE; |
||||
EXPLAIN (COSTS OFF) EXECUTE q (1); |
||||
QUERY PLAN |
||||
----------------------------------------------------- |
||||
LockRows |
||||
-> Append |
||||
Subplans Removed: 2 |
||||
-> Index Scan using foo1_1_a on foo1_1 foo_1 |
||||
Index Cond: (a = $1) |
||||
(5 rows) |
||||
|
||||
step s2lock: SELECT pg_advisory_lock(12345); |
||||
pg_advisory_lock |
||||
---------------- |
||||
|
||||
(1 row) |
||||
|
||||
step s1exec: LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q (1); <waiting ...> |
||||
step s2dropi: DROP INDEX foo1_1_a; |
||||
step s2unlock: SELECT pg_advisory_unlock(12345); |
||||
pg_advisory_unlock |
||||
------------------ |
||||
t |
||||
(1 row) |
||||
|
||||
step s1exec: <... completed> |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is not valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
------------------------------------ |
||||
LockRows |
||||
-> Append |
||||
Subplans Removed: 2 |
||||
-> Seq Scan on foo1_1 foo_1 |
||||
Filter: (a = $1) |
||||
(5 rows) |
||||
|
||||
|
||||
starting permutation: s1prep2 s2lock s1exec2 s2dropi s2unlock |
||||
step s1prep2: SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q2 AS SELECT * FROM foov WHERE a = one() or a = two(); |
||||
EXPLAIN (COSTS OFF) EXECUTE q2; |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
--------------------------------------------------- |
||||
Append |
||||
Subplans Removed: 1 |
||||
-> Index Scan using foo1_1_a on foo1_1 foo_1 |
||||
Index Cond: (a = ANY (ARRAY[one(), two()])) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
(6 rows) |
||||
|
||||
step s2lock: SELECT pg_advisory_lock(12345); |
||||
pg_advisory_lock |
||||
---------------- |
||||
|
||||
(1 row) |
||||
|
||||
step s1exec2: LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q2; <waiting ...> |
||||
step s2dropi: DROP INDEX foo1_1_a; |
||||
step s2unlock: SELECT pg_advisory_unlock(12345); |
||||
pg_advisory_unlock |
||||
------------------ |
||||
t |
||||
(1 row) |
||||
|
||||
step s1exec2: <... completed> |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is not valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
-------------------------------------------- |
||||
Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on foo1_1 foo_1 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
(6 rows) |
||||
|
||||
|
||||
starting permutation: s1prep3 s2lock s1exec3 s2dropi s2unlock |
||||
step s1prep3: SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q3 AS UPDATE foov SET a = a WHERE a = one() or a = two(); |
||||
EXPLAIN (COSTS OFF) EXECUTE q3; |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
--------------------------------------------------------------- |
||||
Nested Loop |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Index Only Scan using foo1_1_a on foo1_1 foo_1 |
||||
Index Cond: (a = ANY (ARRAY[one(), two()])) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Materialize |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on bar1 bar_1 |
||||
Filter: (a = one()) |
||||
|
||||
Update on bar |
||||
Update on bar1 bar_1 |
||||
-> Nested Loop |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Index Scan using foo1_1_a on foo1_1 foo_1 |
||||
Index Cond: (a = ANY (ARRAY[one(), two()])) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Materialize |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on bar1 bar_1 |
||||
Filter: (a = one()) |
||||
|
||||
Update on foo |
||||
Update on foo1_1 foo_1 |
||||
Update on foo1_2 foo_2 |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Index Scan using foo1_1_a on foo1_1 foo_1 |
||||
Index Cond: (a = ANY (ARRAY[one(), two()])) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
(37 rows) |
||||
|
||||
step s2lock: SELECT pg_advisory_lock(12345); |
||||
pg_advisory_lock |
||||
---------------- |
||||
|
||||
(1 row) |
||||
|
||||
step s1exec3: LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q3; <waiting ...> |
||||
step s2dropi: DROP INDEX foo1_1_a; |
||||
step s2unlock: SELECT pg_advisory_unlock(12345); |
||||
pg_advisory_unlock |
||||
------------------ |
||||
t |
||||
(1 row) |
||||
|
||||
step s1exec3: <... completed> |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is not valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
-------------------------------------------------------- |
||||
Nested Loop |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on foo1_1 foo_1 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Materialize |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on bar1 bar_1 |
||||
Filter: (a = one()) |
||||
|
||||
Update on bar |
||||
Update on bar1 bar_1 |
||||
-> Nested Loop |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on foo1_1 foo_1 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Materialize |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on bar1 bar_1 |
||||
Filter: (a = one()) |
||||
|
||||
Update on foo |
||||
Update on foo1_1 foo_1 |
||||
Update on foo1_2 foo_2 |
||||
-> Append |
||||
Subplans Removed: 1 |
||||
-> Seq Scan on foo1_1 foo_1 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
-> Seq Scan on foo1_2 foo_2 |
||||
Filter: ((a = one()) OR (a = two())) |
||||
(37 rows) |
||||
|
||||
|
||||
starting permutation: s1prep4 s2lock s1exec4 s2dropi s2unlock |
||||
step s1prep4: SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q4 AS SELECT * FROM generate_series(1, 1) WHERE EXISTS (SELECT * FROM foov WHERE a = $1 FOR UPDATE); |
||||
EXPLAIN (COSTS OFF) EXECUTE q4 (1); |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
------------------------------------------------------------- |
||||
Result |
||||
One-Time Filter: (InitPlan 1).col1 |
||||
InitPlan 1 |
||||
-> LockRows |
||||
-> Append |
||||
Subplans Removed: 2 |
||||
-> Index Scan using foo1_1_a on foo1_1 foo_1 |
||||
Index Cond: (a = $1) |
||||
-> Function Scan on generate_series |
||||
(9 rows) |
||||
|
||||
step s2lock: SELECT pg_advisory_lock(12345); |
||||
pg_advisory_lock |
||||
---------------- |
||||
|
||||
(1 row) |
||||
|
||||
step s1exec4: LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q4 (1); <waiting ...> |
||||
step s2dropi: DROP INDEX foo1_1_a; |
||||
step s2unlock: SELECT pg_advisory_unlock(12345); |
||||
pg_advisory_unlock |
||||
------------------ |
||||
t |
||||
(1 row) |
||||
|
||||
step s1exec4: <... completed> |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is not valid |
||||
s1: NOTICE: Finished ExecutorStart(): CachedPlan is valid |
||||
QUERY PLAN |
||||
-------------------------------------------- |
||||
Result |
||||
One-Time Filter: (InitPlan 1).col1 |
||||
InitPlan 1 |
||||
-> LockRows |
||||
-> Append |
||||
Subplans Removed: 2 |
||||
-> Seq Scan on foo1_1 foo_1 |
||||
Filter: (a = $1) |
||||
-> Function Scan on generate_series |
||||
(9 rows) |
||||
|
||||
@ -1,86 +0,0 @@ |
||||
# Test to check that invalidation of cached generic plans during ExecutorStart |
||||
# is correctly detected causing an updated plan to be re-executed. |
||||
|
||||
setup |
||||
{ |
||||
CREATE TABLE foo (a int, b text) PARTITION BY RANGE (a); |
||||
CREATE TABLE foo1 PARTITION OF foo FOR VALUES FROM (MINVALUE) TO (3) PARTITION BY RANGE (a); |
||||
CREATE TABLE foo1_1 PARTITION OF foo1 FOR VALUES FROM (MINVALUE) TO (2); |
||||
CREATE TABLE foo1_2 PARTITION OF foo1 FOR VALUES FROM (2) TO (3); |
||||
CREATE INDEX foo1_1_a ON foo1_1 (a); |
||||
CREATE TABLE foo2 PARTITION OF foo FOR VALUES FROM (3) TO (MAXVALUE); |
||||
INSERT INTO foo SELECT generate_series(-1000, 1000); |
||||
CREATE VIEW foov AS SELECT * FROM foo; |
||||
CREATE FUNCTION one () RETURNS int AS $$ BEGIN RETURN 1; END; $$ LANGUAGE PLPGSQL STABLE; |
||||
CREATE FUNCTION two () RETURNS int AS $$ BEGIN RETURN 2; END; $$ LANGUAGE PLPGSQL STABLE; |
||||
CREATE TABLE bar (a int, b text) PARTITION BY LIST(a); |
||||
CREATE TABLE bar1 PARTITION OF bar FOR VALUES IN (1); |
||||
CREATE INDEX ON bar1(a); |
||||
CREATE TABLE bar2 PARTITION OF bar FOR VALUES IN (2); |
||||
CREATE RULE update_foo AS ON UPDATE TO foo DO ALSO UPDATE bar SET a = a WHERE a = one(); |
||||
CREATE RULE update_bar AS ON UPDATE TO bar DO ALSO SELECT 1; |
||||
ANALYZE; |
||||
} |
||||
|
||||
teardown |
||||
{ |
||||
DROP VIEW foov; |
||||
DROP RULE update_foo ON foo; |
||||
DROP TABLE foo, bar; |
||||
DROP FUNCTION one(), two(); |
||||
} |
||||
|
||||
session "s1" |
||||
step "s1prep" { SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q AS SELECT * FROM foov WHERE a = $1 FOR UPDATE; |
||||
EXPLAIN (COSTS OFF) EXECUTE q (1); } |
||||
|
||||
step "s1prep2" { SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q2 AS SELECT * FROM foov WHERE a = one() or a = two(); |
||||
EXPLAIN (COSTS OFF) EXECUTE q2; } |
||||
|
||||
step "s1prep3" { SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q3 AS UPDATE foov SET a = a WHERE a = one() or a = two(); |
||||
EXPLAIN (COSTS OFF) EXECUTE q3; } |
||||
|
||||
step "s1prep4" { SET plan_cache_mode = force_generic_plan; |
||||
PREPARE q4 AS SELECT * FROM generate_series(1, 1) WHERE EXISTS (SELECT * FROM foov WHERE a = $1 FOR UPDATE); |
||||
EXPLAIN (COSTS OFF) EXECUTE q4 (1); } |
||||
|
||||
step "s1exec" { LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q (1); } |
||||
step "s1exec2" { LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q2; } |
||||
step "s1exec3" { LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q3; } |
||||
step "s1exec4" { LOAD 'delay_execution'; |
||||
SET delay_execution.executor_start_lock_id = 12345; |
||||
EXPLAIN (COSTS OFF) EXECUTE q4 (1); } |
||||
|
||||
session "s2" |
||||
step "s2lock" { SELECT pg_advisory_lock(12345); } |
||||
step "s2unlock" { SELECT pg_advisory_unlock(12345); } |
||||
step "s2dropi" { DROP INDEX foo1_1_a; } |
||||
|
||||
# In all permutations below, while "s1exec", "s1exec2", etc. wait to |
||||
# acquire the advisory lock, "s2drop" drops the index being used in the |
||||
# cached plan. When "s1exec" and others are unblocked and begin initializing |
||||
# the plan, including acquiring necessary locks on partitions, the concurrent |
||||
# index drop is detected. This causes plan initialization to be aborted, |
||||
# prompting the caller to retry with a new plan. |
||||
|
||||
# Case with runtime pruning using EXTERN parameter |
||||
permutation "s1prep" "s2lock" "s1exec" "s2dropi" "s2unlock" |
||||
|
||||
# Case with runtime pruning using stable function |
||||
permutation "s1prep2" "s2lock" "s1exec2" "s2dropi" "s2unlock" |
||||
|
||||
# Case with a rule adding another query causing the CachedPlan to contain |
||||
# multiple PlannedStmts |
||||
permutation "s1prep3" "s2lock" "s1exec3" "s2dropi" "s2unlock" |
||||
|
||||
# Case with run-time pruning inside a subquery |
||||
permutation "s1prep4" "s2lock" "s1exec4" "s2dropi" "s2unlock" |
||||
Loading…
Reference in new issue