open-dsi
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make two-phase tests of ECPG and main suite more concurrent-proof

Browse Source 
The ECPG and main 2PC tests have been using rather-generic names for the
prepared transactions they generate.  This commit switches the 2PC
transactions to use more complex GIDs, reducing the risk of naming
conflicts.

The main 2PC tests also include scans of pg_prepared_xacts that do not
apply filters on the GID of the prepared transactions, making it
possible to fail the test when any 2PC transaction runs concurrently.
The CI has been able to see such failures with an installcheck
running the ECPG and the main regression test suites in parallel.  The
queries on pg_prepared_xacts gain quals to only look after the GIDs
generated locally.

The race is very hard to reproduce, so no backbatch is done for now.

Reported-by: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4-mWCGbbE_bne5=AfqjYGDaUZmjCw2+soLjrdNA0xUDFw@mail.gmail.com
pull/160/head
Michael Paquier 1 year ago
parent 3c18409265
commit 7e61e4cc7c
6 changed files with 111 additions and 111 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 4
      src/interfaces/ecpg/test/expected/sql-twophase.c
  2. 4
      src/interfaces/ecpg/test/expected/sql-twophase.stderr
  3. 4
      src/interfaces/ecpg/test/sql/twophase.pgc
  4. 84
      src/test/regress/expected/prepared_xacts.out
  5. 62
      src/test/regress/expected/prepared_xacts_1.out
  6. 50
      src/test/regress/sql/prepared_xacts.sql

4
src/interfaces/ecpg/test/expected/sql-twophase.c
Unescape View File

@ -79,7 +79,7 @@ if (sqlca.sqlcode < 0) sqlprint();}
strcpy(msg, "prepare transaction"); strcpy(msg, "prepare transaction");
{ ECPGtrans(__LINE__, NULL, "prepare transaction 'gxid'"); { ECPGtrans(__LINE__, NULL, "prepare transaction 'ecpg_twophase'");
#line 32 "twophase.pgc" #line 32 "twophase.pgc"
if (sqlca.sqlcode < 0) sqlprint();} if (sqlca.sqlcode < 0) sqlprint();}
@ -87,7 +87,7 @@ if (sqlca.sqlcode < 0) sqlprint();}
strcpy(msg, "commit prepared"); strcpy(msg, "commit prepared");
{ ECPGtrans(__LINE__, NULL, "commit prepared 'gxid'"); { ECPGtrans(__LINE__, NULL, "commit prepared 'ecpg_twophase'");
#line 35 "twophase.pgc" #line 35 "twophase.pgc"
if (sqlca.sqlcode < 0) sqlprint();} if (sqlca.sqlcode < 0) sqlprint();}

4
src/interfaces/ecpg/test/expected/sql-twophase.stderr
Unescape View File

@ -20,9 +20,9 @@
[NO_PID]: sqlca: code: 0, state: 00000 [NO_PID]: sqlca: code: 0, state: 00000
[NO_PID]: ecpg_process_output on line 29: OK: INSERT 0 1 [NO_PID]: ecpg_process_output on line 29: OK: INSERT 0 1
[NO_PID]: sqlca: code: 0, state: 00000 [NO_PID]: sqlca: code: 0, state: 00000
[NO_PID]: ECPGtrans on line 32: action "prepare transaction 'gxid'"; connection "ecpg1_regression" [NO_PID]: ECPGtrans on line 32: action "prepare transaction 'ecpg_twophase'"; connection "ecpg1_regression"
[NO_PID]: sqlca: code: 0, state: 00000 [NO_PID]: sqlca: code: 0, state: 00000
[NO_PID]: ECPGtrans on line 35: action "commit prepared 'gxid'"; connection "ecpg1_regression" [NO_PID]: ECPGtrans on line 35: action "commit prepared 'ecpg_twophase'"; connection "ecpg1_regression"
[NO_PID]: sqlca: code: 0, state: 00000 [NO_PID]: sqlca: code: 0, state: 00000
[NO_PID]: ecpg_execute on line 38: query: drop table t1; with 0 parameter(s) on connection ecpg1_regression [NO_PID]: ecpg_execute on line 38: query: drop table t1; with 0 parameter(s) on connection ecpg1_regression
[NO_PID]: sqlca: code: 0, state: 00000 [NO_PID]: sqlca: code: 0, state: 00000

4
src/interfaces/ecpg/test/sql/twophase.pgc
Unescape View File

@ -29,10 +29,10 @@ int main(void)
exec sql insert into t1 values(1); exec sql insert into t1 values(1);
strcpy(msg, "prepare transaction"); strcpy(msg, "prepare transaction");
exec sql prepare transaction 'gxid'; exec sql prepare transaction 'ecpg_twophase';
strcpy(msg, "commit prepared"); strcpy(msg, "commit prepared");
exec sql commit prepared 'gxid'; exec sql commit prepared 'ecpg_twophase';
strcpy(msg, "drop"); strcpy(msg, "drop");
exec sql drop table t1; exec sql drop table t1;

84
src/test/regress/expected/prepared_xacts.out
Unescape View File

@ -17,7 +17,7 @@ SELECT * FROM pxtest1;
bbb bbb
(1 row) (1 row)
PREPARE TRANSACTION 'foo1'; PREPARE TRANSACTION 'regress_foo1';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
@ -25,21 +25,21 @@ SELECT * FROM pxtest1;
(1 row) (1 row)
-- Test pg_prepared_xacts system view -- Test pg_prepared_xacts system view
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------ --------------
foo1 regress_foo1
(1 row) (1 row)
-- Test ROLLBACK PREPARED -- Test ROLLBACK PREPARED
ROLLBACK PREPARED 'foo1'; ROLLBACK PREPARED 'regress_foo1';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
aaa aaa
(1 row) (1 row)
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -54,14 +54,14 @@ SELECT * FROM pxtest1;
ddd ddd
(2 rows) (2 rows)
PREPARE TRANSACTION 'foo2'; PREPARE TRANSACTION 'regress_foo2';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
aaa aaa
(1 row) (1 row)
COMMIT PREPARED 'foo2'; COMMIT PREPARED 'regress_foo2';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
@ -79,18 +79,18 @@ SELECT * FROM pxtest1;
eee eee
(2 rows) (2 rows)
PREPARE TRANSACTION 'foo3'; PREPARE TRANSACTION 'regress_foo3';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------ --------------
foo3 regress_foo3
(1 row) (1 row)
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
INSERT INTO pxtest1 VALUES ('fff'); INSERT INTO pxtest1 VALUES ('fff');
-- This should fail, because the gid foo3 is already in use -- This should fail, because the gid foo3 is already in use
PREPARE TRANSACTION 'foo3'; PREPARE TRANSACTION 'regress_foo3';
ERROR: transaction identifier "foo3" is already in use ERROR: transaction identifier "regress_foo3" is already in use
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
@ -98,7 +98,7 @@ SELECT * FROM pxtest1;
ddd ddd
(2 rows) (2 rows)
ROLLBACK PREPARED 'foo3'; ROLLBACK PREPARED 'regress_foo3';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
@ -116,11 +116,11 @@ SELECT * FROM pxtest1;
eee eee
(2 rows) (2 rows)
PREPARE TRANSACTION 'foo4'; PREPARE TRANSACTION 'regress_foo4';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------ --------------
foo4 regress_foo4
(1 row) (1 row)
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
@ -136,15 +136,15 @@ INSERT INTO pxtest1 VALUES ('fff');
ERROR: could not serialize access due to read/write dependencies among transactions ERROR: could not serialize access due to read/write dependencies among transactions
DETAIL: Reason code: Canceled on identification as a pivot, during write. DETAIL: Reason code: Canceled on identification as a pivot, during write.
HINT: The transaction might succeed if retried. HINT: The transaction might succeed if retried.
PREPARE TRANSACTION 'foo5'; PREPARE TRANSACTION 'regress_foo5';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------ --------------
foo4 regress_foo4
(1 row) (1 row)
ROLLBACK PREPARED 'foo4'; ROLLBACK PREPARED 'regress_foo4';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -165,7 +165,7 @@ SELECT pg_advisory_xact_lock_shared(1);
(1 row) (1 row)
PREPARE TRANSACTION 'foo6'; -- fails PREPARE TRANSACTION 'regress_foo6'; -- fails
ERROR: cannot PREPARE while holding both session-level and transaction-level locks on the same object ERROR: cannot PREPARE while holding both session-level and transaction-level locks on the same object
-- Test subtransactions -- Test subtransactions
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
@ -176,7 +176,7 @@ BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
ROLLBACK TO a; ROLLBACK TO a;
SAVEPOINT b; SAVEPOINT b;
INSERT INTO pxtest2 VALUES (3); INSERT INTO pxtest2 VALUES (3);
PREPARE TRANSACTION 'regress-one'; PREPARE TRANSACTION 'regress_sub1';
CREATE TABLE pxtest3(fff int); CREATE TABLE pxtest3(fff int);
-- Test shared invalidation -- Test shared invalidation
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
@ -192,7 +192,7 @@ BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
1 1
(1 row) (1 row)
PREPARE TRANSACTION 'regress-two'; PREPARE TRANSACTION 'regress_sub2';
-- No such cursor -- No such cursor
FETCH 1 FROM foo; FETCH 1 FROM foo;
ERROR: cursor "foo" does not exist ERROR: cursor "foo" does not exist
@ -202,11 +202,11 @@ ERROR: relation "pxtest2" does not exist
LINE 1: SELECT * FROM pxtest2; LINE 1: SELECT * FROM pxtest2;
^ ^
-- There should be two prepared transactions -- There should be two prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------------- --------------
regress-one regress_sub1
regress-two regress_sub2
(2 rows) (2 rows)
-- pxtest3 should be locked because of the pending DROP -- pxtest3 should be locked because of the pending DROP
@ -217,11 +217,11 @@ rollback;
-- Disconnect, we will continue testing in a different backend -- Disconnect, we will continue testing in a different backend
\c - \c -
-- There should still be two prepared transactions -- There should still be two prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------------- --------------
regress-one regress_sub1
regress-two regress_sub2
(2 rows) (2 rows)
-- pxtest3 should still be locked because of the pending DROP -- pxtest3 should still be locked because of the pending DROP
@ -230,7 +230,7 @@ lock table pxtest3 in access share mode nowait;
ERROR: could not obtain lock on relation "pxtest3" ERROR: could not obtain lock on relation "pxtest3"
rollback; rollback;
-- Commit table creation -- Commit table creation
COMMIT PREPARED 'regress-one'; COMMIT PREPARED 'regress_sub1';
\d pxtest2 \d pxtest2
Table "public.pxtest2" Table "public.pxtest2"
Column | Type | Collation | Nullable | Default Column | Type | Collation | Nullable | Default
@ -245,20 +245,20 @@ SELECT * FROM pxtest2;
(2 rows) (2 rows)
-- There should be one prepared transaction -- There should be one prepared transaction
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
------------- --------------
regress-two regress_sub2
(1 row) (1 row)
-- Commit table drop -- Commit table drop
COMMIT PREPARED 'regress-two'; COMMIT PREPARED 'regress_sub2';
SELECT * FROM pxtest3; SELECT * FROM pxtest3;
ERROR: relation "pxtest3" does not exist ERROR: relation "pxtest3" does not exist
LINE 1: SELECT * FROM pxtest3; LINE 1: SELECT * FROM pxtest3;
^ ^
-- There should be no prepared transactions -- There should be no prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)

62
src/test/regress/expected/prepared_xacts_1.out
Unescape View File

@ -17,7 +17,7 @@ SELECT * FROM pxtest1;
bbb bbb
(1 row) (1 row)
PREPARE TRANSACTION 'foo1'; PREPARE TRANSACTION 'regress_foo1';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
@ -27,21 +27,21 @@ SELECT * FROM pxtest1;
(1 row) (1 row)
-- Test pg_prepared_xacts system view -- Test pg_prepared_xacts system view
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
-- Test ROLLBACK PREPARED -- Test ROLLBACK PREPARED
ROLLBACK PREPARED 'foo1'; ROLLBACK PREPARED 'regress_foo1';
ERROR: prepared transaction with identifier "foo1" does not exist ERROR: prepared transaction with identifier "regress_foo1" does not exist
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
aaa aaa
(1 row) (1 row)
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -56,7 +56,7 @@ SELECT * FROM pxtest1;
ddd ddd
(2 rows) (2 rows)
PREPARE TRANSACTION 'foo2'; PREPARE TRANSACTION 'regress_foo2';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
@ -65,8 +65,8 @@ SELECT * FROM pxtest1;
aaa aaa
(1 row) (1 row)
COMMIT PREPARED 'foo2'; COMMIT PREPARED 'regress_foo2';
ERROR: prepared transaction with identifier "foo2" does not exist ERROR: prepared transaction with identifier "regress_foo2" does not exist
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
@ -82,10 +82,10 @@ SELECT * FROM pxtest1;
aaa aaa
(1 row) (1 row)
PREPARE TRANSACTION 'foo3'; PREPARE TRANSACTION 'regress_foo3';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -93,7 +93,7 @@ SELECT gid FROM pg_prepared_xacts;
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
INSERT INTO pxtest1 VALUES ('fff'); INSERT INTO pxtest1 VALUES ('fff');
-- This should fail, because the gid foo3 is already in use -- This should fail, because the gid foo3 is already in use
PREPARE TRANSACTION 'foo3'; PREPARE TRANSACTION 'regress_foo3';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
@ -102,8 +102,8 @@ SELECT * FROM pxtest1;
aaa aaa
(1 row) (1 row)
ROLLBACK PREPARED 'foo3'; ROLLBACK PREPARED 'regress_foo3';
ERROR: prepared transaction with identifier "foo3" does not exist ERROR: prepared transaction with identifier "regress_foo3" does not exist
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
foobar foobar
-------- --------
@ -119,10 +119,10 @@ SELECT * FROM pxtest1;
aaa aaa
(1 row) (1 row)
PREPARE TRANSACTION 'foo4'; PREPARE TRANSACTION 'regress_foo4';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -136,17 +136,17 @@ SELECT * FROM pxtest1;
-- This should fail, because the two transactions have a write-skew anomaly -- This should fail, because the two transactions have a write-skew anomaly
INSERT INTO pxtest1 VALUES ('fff'); INSERT INTO pxtest1 VALUES ('fff');
PREPARE TRANSACTION 'foo5'; PREPARE TRANSACTION 'regress_foo5';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
ROLLBACK PREPARED 'foo4'; ROLLBACK PREPARED 'regress_foo4';
ERROR: prepared transaction with identifier "foo4" does not exist ERROR: prepared transaction with identifier "regress_foo4" does not exist
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -167,7 +167,7 @@ SELECT pg_advisory_xact_lock_shared(1);
(1 row) (1 row)
PREPARE TRANSACTION 'foo6'; -- fails PREPARE TRANSACTION 'regress_foo6'; -- fails
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
-- Test subtransactions -- Test subtransactions
@ -179,7 +179,7 @@ BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
ROLLBACK TO a; ROLLBACK TO a;
SAVEPOINT b; SAVEPOINT b;
INSERT INTO pxtest2 VALUES (3); INSERT INTO pxtest2 VALUES (3);
PREPARE TRANSACTION 'regress-one'; PREPARE TRANSACTION 'regress_sub1';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
CREATE TABLE pxtest3(fff int); CREATE TABLE pxtest3(fff int);
@ -197,7 +197,7 @@ BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
1 1
(1 row) (1 row)
PREPARE TRANSACTION 'regress-two'; PREPARE TRANSACTION 'regress_sub2';
ERROR: prepared transactions are disabled ERROR: prepared transactions are disabled
HINT: Set max_prepared_transactions to a nonzero value. HINT: Set max_prepared_transactions to a nonzero value.
-- No such cursor -- No such cursor
@ -209,7 +209,7 @@ ERROR: relation "pxtest2" does not exist
LINE 1: SELECT * FROM pxtest2; LINE 1: SELECT * FROM pxtest2;
^ ^
-- There should be two prepared transactions -- There should be two prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -221,7 +221,7 @@ rollback;
-- Disconnect, we will continue testing in a different backend -- Disconnect, we will continue testing in a different backend
\c - \c -
-- There should still be two prepared transactions -- There should still be two prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
@ -231,29 +231,29 @@ begin;
lock table pxtest3 in access share mode nowait; lock table pxtest3 in access share mode nowait;
rollback; rollback;
-- Commit table creation -- Commit table creation
COMMIT PREPARED 'regress-one'; COMMIT PREPARED 'regress_sub1';
ERROR: prepared transaction with identifier "regress-one" does not exist ERROR: prepared transaction with identifier "regress_sub1" does not exist
\d pxtest2 \d pxtest2
SELECT * FROM pxtest2; SELECT * FROM pxtest2;
ERROR: relation "pxtest2" does not exist ERROR: relation "pxtest2" does not exist
LINE 1: SELECT * FROM pxtest2; LINE 1: SELECT * FROM pxtest2;
^ ^
-- There should be one prepared transaction -- There should be one prepared transaction
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)
-- Commit table drop -- Commit table drop
COMMIT PREPARED 'regress-two'; COMMIT PREPARED 'regress_sub2';
ERROR: prepared transaction with identifier "regress-two" does not exist ERROR: prepared transaction with identifier "regress_sub2" does not exist
SELECT * FROM pxtest3; SELECT * FROM pxtest3;
fff fff
----- -----
(0 rows) (0 rows)
-- There should be no prepared transactions -- There should be no prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
gid gid
----- -----
(0 rows) (0 rows)

50
src/test/regress/sql/prepared_xacts.sql
Unescape View File

@ -17,30 +17,30 @@ INSERT INTO pxtest1 VALUES ('aaa');
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
UPDATE pxtest1 SET foobar = 'bbb' WHERE foobar = 'aaa'; UPDATE pxtest1 SET foobar = 'bbb' WHERE foobar = 'aaa';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
PREPARE TRANSACTION 'foo1'; PREPARE TRANSACTION 'regress_foo1';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
-- Test pg_prepared_xacts system view -- Test pg_prepared_xacts system view
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- Test ROLLBACK PREPARED -- Test ROLLBACK PREPARED
ROLLBACK PREPARED 'foo1'; ROLLBACK PREPARED 'regress_foo1';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- Test COMMIT PREPARED -- Test COMMIT PREPARED
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
INSERT INTO pxtest1 VALUES ('ddd'); INSERT INTO pxtest1 VALUES ('ddd');
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
PREPARE TRANSACTION 'foo2'; PREPARE TRANSACTION 'regress_foo2';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
COMMIT PREPARED 'foo2'; COMMIT PREPARED 'regress_foo2';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
@ -48,19 +48,19 @@ SELECT * FROM pxtest1;
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
UPDATE pxtest1 SET foobar = 'eee' WHERE foobar = 'ddd'; UPDATE pxtest1 SET foobar = 'eee' WHERE foobar = 'ddd';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
PREPARE TRANSACTION 'foo3'; PREPARE TRANSACTION 'regress_foo3';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
INSERT INTO pxtest1 VALUES ('fff'); INSERT INTO pxtest1 VALUES ('fff');
-- This should fail, because the gid foo3 is already in use -- This should fail, because the gid foo3 is already in use
PREPARE TRANSACTION 'foo3'; PREPARE TRANSACTION 'regress_foo3';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
ROLLBACK PREPARED 'foo3'; ROLLBACK PREPARED 'regress_foo3';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
@ -68,22 +68,22 @@ SELECT * FROM pxtest1;
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
UPDATE pxtest1 SET foobar = 'eee' WHERE foobar = 'ddd'; UPDATE pxtest1 SET foobar = 'eee' WHERE foobar = 'ddd';
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
PREPARE TRANSACTION 'foo4'; PREPARE TRANSACTION 'regress_foo4';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
SELECT * FROM pxtest1; SELECT * FROM pxtest1;
-- This should fail, because the two transactions have a write-skew anomaly -- This should fail, because the two transactions have a write-skew anomaly
INSERT INTO pxtest1 VALUES ('fff'); INSERT INTO pxtest1 VALUES ('fff');
PREPARE TRANSACTION 'foo5'; PREPARE TRANSACTION 'regress_foo5';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
ROLLBACK PREPARED 'foo4'; ROLLBACK PREPARED 'regress_foo4';
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- Clean up -- Clean up
DROP TABLE pxtest1; DROP TABLE pxtest1;
@ -92,7 +92,7 @@ DROP TABLE pxtest1;
BEGIN; BEGIN;
SELECT pg_advisory_lock(1); SELECT pg_advisory_lock(1);
SELECT pg_advisory_xact_lock_shared(1); SELECT pg_advisory_xact_lock_shared(1);
PREPARE TRANSACTION 'foo6'; -- fails PREPARE TRANSACTION 'regress_foo6'; -- fails
-- Test subtransactions -- Test subtransactions
BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE; BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
@ -103,7 +103,7 @@ BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
ROLLBACK TO a; ROLLBACK TO a;
SAVEPOINT b; SAVEPOINT b;
INSERT INTO pxtest2 VALUES (3); INSERT INTO pxtest2 VALUES (3);
PREPARE TRANSACTION 'regress-one'; PREPARE TRANSACTION 'regress_sub1';
CREATE TABLE pxtest3(fff int); CREATE TABLE pxtest3(fff int);
@ -116,7 +116,7 @@ BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
DECLARE foo CURSOR FOR SELECT * FROM pxtest4; DECLARE foo CURSOR FOR SELECT * FROM pxtest4;
-- Fetch 1 tuple, keeping the cursor open -- Fetch 1 tuple, keeping the cursor open
FETCH 1 FROM foo; FETCH 1 FROM foo;
PREPARE TRANSACTION 'regress-two'; PREPARE TRANSACTION 'regress_sub2';
-- No such cursor -- No such cursor
FETCH 1 FROM foo; FETCH 1 FROM foo;
@ -125,7 +125,7 @@ FETCH 1 FROM foo;
SELECT * FROM pxtest2; SELECT * FROM pxtest2;
-- There should be two prepared transactions -- There should be two prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- pxtest3 should be locked because of the pending DROP -- pxtest3 should be locked because of the pending DROP
begin; begin;
@ -136,7 +136,7 @@ rollback;
\c - \c -
-- There should still be two prepared transactions -- There should still be two prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- pxtest3 should still be locked because of the pending DROP -- pxtest3 should still be locked because of the pending DROP
begin; begin;
@ -144,19 +144,19 @@ lock table pxtest3 in access share mode nowait;
rollback; rollback;
-- Commit table creation -- Commit table creation
COMMIT PREPARED 'regress-one'; COMMIT PREPARED 'regress_sub1';
\d pxtest2 \d pxtest2
SELECT * FROM pxtest2; SELECT * FROM pxtest2;
-- There should be one prepared transaction -- There should be one prepared transaction
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- Commit table drop -- Commit table drop
COMMIT PREPARED 'regress-two'; COMMIT PREPARED 'regress_sub2';
SELECT * FROM pxtest3; SELECT * FROM pxtest3;
-- There should be no prepared transactions -- There should be no prepared transactions
SELECT gid FROM pg_prepared_xacts; SELECT gid FROM pg_prepared_xacts WHERE gid ~ '^regress_' ORDER BY gid;
-- Clean up -- Clean up
DROP TABLE pxtest2; DROP TABLE pxtest2;

Write Preview
Loading…
Cancel
Save