open-dsi
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Give up on running with NetBSD/OpenBSD's default semaphore settings.

Browse Source 
This reverts commit 38da053463, which
attempted to preserve our ability to start with only 60 semaphores.

Subsequent changes (particularly 55b454d0e) have put that idea pretty
much permanently out of reach: people wishing to use Postgres v18 on
OpenBSD or NetBSD will have no choice but to increase those platforms'
default values of SEMMNI and SEMMNS.

Hence, revert 38da05346's changes in SEMAS_PER_SET and the minimum
tested value of max_connections.  Adjust a comment from the subsequent
patch 6d0154196, and tweak the wording in runtime.sgml to make it
clear that changing SEMMNI/SEMMNS is no longer even a little bit
optional on these platforms.

Although 38da05346 was later back-patched into v17, leave that branch
alone: it's still capable of starting with 60 semaphores, and there's
no reason to break that.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/E1tuZNv-0037Gs-34@gemulon.postgresql.org
Discussion: https://postgr.es/m/1052019.1745947915@sss.pgh.pa.us
pull/215/head
Tom Lane 8 months ago
parent e974f1c216
commit 810a8b1c80
3 changed files with 17 additions and 24 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 24
      doc/src/sgml/runtime.sgml
  2. 8
      src/backend/port/sysv_sema.c
  3. 9
      src/bin/initdb/initdb.c

24
doc/src/sgml/runtime.sgml
Unescape View File

@ -782,19 +782,19 @@ psql: error: connection to server on socket "/tmp/.s.PGSQL.5432" failed: No such
<row> <row>
<entry><varname>SEMMNI</varname></entry> <entry><varname>SEMMNI</varname></entry>
<entry>Maximum number of semaphore identifiers (i.e., sets)</entry> <entry>Maximum number of semaphore identifiers (i.e., sets)</entry>
<entry>at least <literal>ceil(num_os_semaphores / 19)</literal> plus room for other applications</entry> <entry>at least <literal>ceil(num_os_semaphores / 16)</literal> plus room for other applications</entry>
</row> </row>
<row> <row>
<entry><varname>SEMMNS</varname></entry> <entry><varname>SEMMNS</varname></entry>
<entry>Maximum number of semaphores system-wide</entry> <entry>Maximum number of semaphores system-wide</entry>
<entry><literal>ceil(num_os_semaphores / 19) * 20</literal> plus room for other applications</entry> <entry><literal>ceil(num_os_semaphores / 16) * 17</literal> plus room for other applications</entry>
</row> </row>
<row> <row>
<entry><varname>SEMMSL</varname></entry> <entry><varname>SEMMSL</varname></entry>
<entry>Maximum number of semaphores per set</entry> <entry>Maximum number of semaphores per set</entry>
<entry>at least 20</entry> <entry>at least 17</entry>
</row> </row>
<row> <row>
@ -841,7 +841,7 @@ psql: error: connection to server on socket "/tmp/.s.PGSQL.5432" failed: No such
(<xref linkend="guc-max-connections"/>), allowed autovacuum worker process (<xref linkend="guc-max-connections"/>), allowed autovacuum worker process
(<xref linkend="guc-autovacuum-worker-slots"/>), allowed WAL sender process (<xref linkend="guc-autovacuum-worker-slots"/>), allowed WAL sender process
(<xref linkend="guc-max-wal-senders"/>), allowed background (<xref linkend="guc-max-wal-senders"/>), allowed background
process (<xref linkend="guc-max-worker-processes"/>), etc., in sets of 19. process (<xref linkend="guc-max-worker-processes"/>), etc., in sets of 16.
The runtime-computed parameter <xref linkend="guc-num-os-semaphores"/> The runtime-computed parameter <xref linkend="guc-num-os-semaphores"/>
reports the number of semaphores required. This parameter can be viewed reports the number of semaphores required. This parameter can be viewed
before starting the server with a <command>postgres</command> command like: before starting the server with a <command>postgres</command> command like:
@ -851,17 +851,17 @@ $ <userinput>postgres -D $PGDATA -C num_os_semaphores</userinput>
</para> </para>
<para> <para>
Each set of 19 semaphores will Each set of 16 semaphores will
also contain a 20th semaphore which contains a <quote>magic also contain a 17th semaphore which contains a <quote>magic
number</quote>, to detect collision with semaphore sets used by number</quote>, to detect collision with semaphore sets used by
other applications. The maximum number of semaphores in the system other applications. The maximum number of semaphores in the system
is set by <varname>SEMMNS</varname>, which consequently must be at least is set by <varname>SEMMNS</varname>, which consequently must be at least
as high as <literal>num_os_semaphores</literal> plus one extra for as high as <literal>num_os_semaphores</literal> plus one extra for
each set of 19 required semaphores (see the formula in <xref each set of 16 required semaphores (see the formula in <xref
linkend="sysvipc-parameters"/>). The parameter <varname>SEMMNI</varname> linkend="sysvipc-parameters"/>). The parameter <varname>SEMMNI</varname>
determines the limit on the number of semaphore sets that can determines the limit on the number of semaphore sets that can
exist on the system at one time. Hence this parameter must be at exist on the system at one time. Hence this parameter must be at
least <literal>ceil(num_os_semaphores / 19)</literal>. least <literal>ceil(num_os_semaphores / 16)</literal>.
Lowering the number Lowering the number
of allowed connections is a temporary workaround for failures, of allowed connections is a temporary workaround for failures,
which are usually confusingly worded <quote>No space which are usually confusingly worded <quote>No space
@ -953,10 +953,10 @@ $ <userinput>postgres -D $PGDATA -C num_os_semaphores</userinput>
<para> <para>
The default shared memory settings are usually good enough, unless The default shared memory settings are usually good enough, unless
you have set <literal>shared_memory_type</literal> to <literal>sysv</literal>. you have set <literal>shared_memory_type</literal> to <literal>sysv</literal>.
You will usually want to increase <literal>kern.ipc.semmni</literal> However, you will need to increase <literal>kern.ipc.semmni</literal>
and <literal>kern.ipc.semmns</literal>, and <literal>kern.ipc.semmns</literal>,
as <systemitem class="osname">NetBSD</systemitem>'s default settings as <systemitem class="osname">NetBSD</systemitem>'s default settings
for these are uncomfortably small. for these are unworkably small.
</para> </para>
<para> <para>
@ -987,11 +987,11 @@ $ <userinput>postgres -D $PGDATA -C num_os_semaphores</userinput>
<para> <para>
The default shared memory settings are usually good enough, unless The default shared memory settings are usually good enough, unless
you have set <literal>shared_memory_type</literal> to <literal>sysv</literal>. you have set <literal>shared_memory_type</literal> to <literal>sysv</literal>.
You will usually want to However, you will need to
increase <literal>kern.seminfo.semmni</literal> increase <literal>kern.seminfo.semmni</literal>
and <literal>kern.seminfo.semmns</literal>, and <literal>kern.seminfo.semmns</literal>,
as <systemitem class="osname">OpenBSD</systemitem>'s default settings as <systemitem class="osname">OpenBSD</systemitem>'s default settings
for these are uncomfortably small. for these are unworkably small.
</para> </para>
<para> <para>

8
src/backend/port/sysv_sema.c
Unescape View File

@ -50,14 +50,8 @@ typedef int IpcSemaphoreId; /* semaphore ID returned by semget(2) */
* we allocate. It must be *less than* your kernel's SEMMSL (max semaphores * we allocate. It must be *less than* your kernel's SEMMSL (max semaphores
* per set) parameter, which is often around 25. (Less than, because we * per set) parameter, which is often around 25. (Less than, because we
* allocate one extra sema in each set for identification purposes.) * allocate one extra sema in each set for identification purposes.)
*
* The present value of 19 is chosen with one eye on NetBSD/OpenBSD's default
* SEMMNS setting of 60. Remembering the extra sema per set, this lets us
* allocate three sets with 57 useful semaphores before exceeding that, which
* is enough to run our core regression tests. Users of those systems will
* still want to raise SEMMNS for any sort of production work, though.
*/ */
#define SEMAS_PER_SET 19 #define SEMAS_PER_SET 16
#define IPCProtection (0600) /* access/modify by user only */ #define IPCProtection (0600) /* access/modify by user only */

9
src/bin/initdb/initdb.c
Unescape View File

@ -1128,15 +1128,14 @@ test_config_settings(void)
* for a given max_connections value. Note that it has been carefully * for a given max_connections value. Note that it has been carefully
* crafted to provide specific values for the associated values in * crafted to provide specific values for the associated values in
* trial_conns. We want it to return autovacuum_worker_slots's initial * trial_conns. We want it to return autovacuum_worker_slots's initial
* default value (16) for the maximum value in trial_conns (100), and we * default value (16) for the maximum value in trial_conns[] (100), while
* want it to return close to the minimum value we'd consider (3, which is * it mustn't return less than the default value of autovacuum_max_workers
* the default of autovacuum_max_workers) for the minimum value in * (3) for the minimum value in trial_conns[].
* trial_conns (25).
*/ */
#define AV_SLOTS_FOR_CONNS(nconns) ((nconns) / 6) #define AV_SLOTS_FOR_CONNS(nconns) ((nconns) / 6)
static const int trial_conns[] = { static const int trial_conns[] = {
100, 50, 40, 30, 25 100, 50, 40, 30, 20
}; };
static const int trial_bufs[] = { static const int trial_bufs[] = {
16384, 8192, 4096, 3584, 3072, 2560, 2048, 1536, 16384, 8192, 4096, 3584, 3072, 2560, 2048, 1536,

Write Preview
Loading…
Cancel
Save