open-dsi
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vacuumdb: Fix --missing-stats-only with virtual generated columns.

Browse Source 
Statistics aren't created for virtual generated columns, so
"vacuumdb --missing-stats-only" always chooses to analyze tables
that have them.  To fix, modify vacuumdb's query for retrieving
relations that are missing statistics to exclude those columns.

Oversight in commit edba754f05.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/20250820104226.8ba51e43164cd590b863ce41%40sraoss.co.jp
Backpatch-through: 18
REL_18_STABLE
Nathan Bossart 3 weeks ago
parent 5a26a3e4ee
commit 8c0c868637
2 changed files with 9 additions and 3 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 7
      src/bin/scripts/t/100_vacuumdb.pl
  2. 5
      src/bin/scripts/vacuumdb.c

7
src/bin/scripts/t/100_vacuumdb.pl
Unescape View File

@ -237,9 +237,10 @@ $node->command_fails_like(
qr/cannot vacuum all databases and a specific one at the same time/, qr/cannot vacuum all databases and a specific one at the same time/,
'cannot use option --all and a dbname as argument at the same time'); 'cannot use option --all and a dbname as argument at the same time');
$node->safe_psql('postgres', $node->safe_psql('postgres', q|
'CREATE TABLE regression_vacuumdb_test AS select generate_series(1, 10) a, generate_series(2, 11) b;' CREATE TABLE regression_vacuumdb_test AS select generate_series(1, 10) a, generate_series(2, 11) b;
); ALTER TABLE regression_vacuumdb_test ADD COLUMN c INT GENERATED ALWAYS AS (a + b);
|);
$node->issues_sql_like( $node->issues_sql_like(
[ [
'vacuumdb', '--analyze-only', 'vacuumdb', '--analyze-only',

5
src/bin/scripts/vacuumdb.c
Unescape View File

@ -14,6 +14,7 @@
#include <limits.h> #include <limits.h>
#include "catalog/pg_attribute_d.h"
#include "catalog/pg_class_d.h" #include "catalog/pg_class_d.h"
#include "common.h" #include "common.h"
#include "common/connect.h" #include "common/connect.h"
@ -957,6 +958,8 @@ retrieve_objects(PGconn *conn, vacuumingOptions *vacopts,
" AND a.attnum OPERATOR(pg_catalog.>) 0::pg_catalog.int2\n" " AND a.attnum OPERATOR(pg_catalog.>) 0::pg_catalog.int2\n"
" AND NOT a.attisdropped\n" " AND NOT a.attisdropped\n"
" AND a.attstattarget IS DISTINCT FROM 0::pg_catalog.int2\n" " AND a.attstattarget IS DISTINCT FROM 0::pg_catalog.int2\n"
" AND a.attgenerated OPERATOR(pg_catalog.<>) "
CppAsString2(ATTRIBUTE_GENERATED_VIRTUAL) "\n"
" AND NOT EXISTS (SELECT NULL FROM pg_catalog.pg_statistic s\n" " AND NOT EXISTS (SELECT NULL FROM pg_catalog.pg_statistic s\n"
" WHERE s.starelid OPERATOR(pg_catalog.=) a.attrelid\n" " WHERE s.starelid OPERATOR(pg_catalog.=) a.attrelid\n"
" AND s.staattnum OPERATOR(pg_catalog.=) a.attnum\n" " AND s.staattnum OPERATOR(pg_catalog.=) a.attnum\n"
@ -994,6 +997,8 @@ retrieve_objects(PGconn *conn, vacuumingOptions *vacopts,
" AND a.attnum OPERATOR(pg_catalog.>) 0::pg_catalog.int2\n" " AND a.attnum OPERATOR(pg_catalog.>) 0::pg_catalog.int2\n"
" AND NOT a.attisdropped\n" " AND NOT a.attisdropped\n"
" AND a.attstattarget IS DISTINCT FROM 0::pg_catalog.int2\n" " AND a.attstattarget IS DISTINCT FROM 0::pg_catalog.int2\n"
" AND a.attgenerated OPERATOR(pg_catalog.<>) "
CppAsString2(ATTRIBUTE_GENERATED_VIRTUAL) "\n"
" AND c.relhassubclass\n" " AND c.relhassubclass\n"
" AND NOT p.inherited\n" " AND NOT p.inherited\n"
" AND EXISTS (SELECT NULL FROM pg_catalog.pg_inherits h\n" " AND EXISTS (SELECT NULL FROM pg_catalog.pg_inherits h\n"

Write Preview
Loading…
Cancel
Save