Suppress compiler warning, and not incidentally make the code more

robust.  The previous coding was quite risky because it was testing
conditions different from 'is the array really allocated?'.
REL8_5_ALPHA1_BRANCH
Tom Lane 17 years ago
parent 69a785b8bf
commit a4775a80fd
  1. 6
      src/bin/psql/describe.c

@ -8,7 +8,7 @@
* *
* Copyright (c) 2000-2008, PostgreSQL Global Development Group * Copyright (c) 2000-2008, PostgreSQL Global Development Group
* *
* $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.183 2008/07/18 03:32:52 tgl Exp $ * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.184 2008/07/18 04:20:24 tgl Exp $
*/ */
#include "postgres_fe.h" #include "postgres_fe.h"
@ -1591,14 +1591,14 @@ error_return:
termPQExpBuffer(&title); termPQExpBuffer(&title);
termPQExpBuffer(&tmpbuf); termPQExpBuffer(&tmpbuf);
if (tableinfo.relkind == 'S') if (seq_values)
{ {
for (ptr = seq_values; *ptr; ptr++) for (ptr = seq_values; *ptr; ptr++)
free(*ptr); free(*ptr);
free(seq_values); free(seq_values);
} }
if (show_modifiers) if (modifiers)
{ {
for (ptr = modifiers; *ptr; ptr++) for (ptr = modifiers; *ptr; ptr++)
free(*ptr); free(*ptr);

Loading…
Cancel
Save