Rewrite previous commit's test for TestUpgradeXversion compatibility.

v17 introduced the MAINTAIN ON TABLES privilege.  That changed the
applicable "baseacls" reaching buildACLCommands().  That yielded
spurious TestUpgradeXversion diffs.  Change to use a TYPES privilege.
Types have the same one privilege in all supported versions, so they
avoid the problem.  Per buildfarm.  Back-patch to v13, like that commit.

Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com
Backpatch-through: 13
master
Noah Misch 3 weeks ago
parent b61a5c4bed
commit ad4412480d
  1. 4
      src/test/regress/expected/privileges.out
  2. 4
      src/test/regress/sql/privileges.sql

@ -3155,9 +3155,9 @@ DROP USER regress_priv_user8; -- does not exist
ERROR: role "regress_priv_user8" does not exist ERROR: role "regress_priv_user8" does not exist
-- leave some default ACLs for pg_upgrade's dump-restore test input. -- leave some default ACLs for pg_upgrade's dump-restore test input.
ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
REVOKE INSERT ON TABLES FROM pg_signal_backend; REVOKE USAGE ON TYPES FROM pg_signal_backend;
ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
REVOKE INSERT ON TABLES FROM pg_read_all_settings; REVOKE USAGE ON TYPES FROM pg_read_all_settings;
-- permissions with LOCK TABLE -- permissions with LOCK TABLE
CREATE USER regress_locktable_user; CREATE USER regress_locktable_user;
CREATE TABLE lock_table (a int); CREATE TABLE lock_table (a int);

@ -1865,9 +1865,9 @@ DROP USER regress_priv_user8; -- does not exist
-- leave some default ACLs for pg_upgrade's dump-restore test input. -- leave some default ACLs for pg_upgrade's dump-restore test input.
ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
REVOKE INSERT ON TABLES FROM pg_signal_backend; REVOKE USAGE ON TYPES FROM pg_signal_backend;
ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
REVOKE INSERT ON TABLES FROM pg_read_all_settings; REVOKE USAGE ON TYPES FROM pg_read_all_settings;
-- permissions with LOCK TABLE -- permissions with LOCK TABLE

Loading…
Cancel
Save