Silence warning in non-assert-enabled build

An OID return value was being used only for a (rather pointless) assert.
Silence by removing the variable and the assert.

Per note from Peter Geoghegan
pull/14/head
Alvaro Herrera 11 years ago
parent 3200b15b20
commit bf22d2707a
  1. 4
      src/backend/catalog/pg_conversion.c

@ -50,7 +50,6 @@ ConversionCreate(const char *conname, Oid connamespace,
bool nulls[Natts_pg_conversion];
Datum values[Natts_pg_conversion];
NameData cname;
Oid oid;
ObjectAddress myself,
referenced;
@ -106,8 +105,7 @@ ConversionCreate(const char *conname, Oid connamespace,
tup = heap_form_tuple(tupDesc, values, nulls);
/* insert a new tuple */
oid = simple_heap_insert(rel, tup);
Assert(OidIsValid(oid));
simple_heap_insert(rel, tup);
/* update the index if any */
CatalogUpdateIndexes(rel, tup);

Loading…
Cancel
Save