mirror of https://github.com/postgres/postgres
pgstat_bestart(), used post-authentication to set up a backend entry in the PgBackendStatus array, so as its data becomes visible in pg_stat_activity and related catalogs, has its logic divided into three routines with this commit, called in order at different steps of the backend initialization: * pgstat_bestart_initial() sets up the backend entry with a minimal amount of information, reporting it with a new BackendState called STATE_STARTING while waiting for backend initialization and client authentication to complete. The main benefit that this offers is observability, so as it is possible to monitor the backend activity during authentication. This step happens earlier than in the logic prior to this commit. pgstat_beinit() happens earlier as well, before authentication. * pgstat_bestart_security() reports the SSL/GSS status of the connection, once authentication completes. Auxiliary processes, for example, do not need to call this step, hence it is optional. This step is called after performing authentication, same as previously. * pgstat_bestart_final() reports the user and database IDs, takes the entry out of STATE_STARTING, and reports its application_name. This is called as the last step of the three, once authentication completes. An injection point is added, with a test checking that the "starting" phase of a backend entry is visible in pg_stat_activity. Some follow-up patches are planned to take advantage of this refactoring with more information provided in backend entries during authentication (LDAP hanging was a problem for the author, initially). Author: Jacob Champion <jacob.champion@enterprisedb.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/CAOYmi+=60deN20WDyCoHCiecgivJxr=98s7s7-C8SkXwrCfHXg@mail.gmail.compull/203/head
Michael Paquier
4 months ago
parent
40d3f82744
commit
c76db55c90
@ -0,0 +1,81 @@ |
||||
|
||||
# Copyright (c) 2021-2025, PostgreSQL Global Development Group |
||||
|
||||
# Tests for connection behavior prior to authentication. |
||||
|
||||
use strict; |
||||
use warnings FATAL => 'all'; |
||||
|
||||
use PostgreSQL::Test::Cluster; |
||||
use PostgreSQL::Test::Utils; |
||||
use Time::HiRes qw(usleep); |
||||
use Test::More; |
||||
|
||||
if ($ENV{enable_injection_points} ne 'yes') |
||||
{ |
||||
plan skip_all => 'Injection points not supported by this build'; |
||||
} |
||||
|
||||
my $node = PostgreSQL::Test::Cluster->new('primary'); |
||||
$node->init; |
||||
$node->append_conf( |
||||
'postgresql.conf', q[ |
||||
log_connections = on |
||||
]); |
||||
|
||||
$node->start; |
||||
|
||||
# Check if the extension injection_points is available, as it may be |
||||
# possible that this script is run with installcheck, where the module |
||||
# would not be installed by default. |
||||
if (!$node->check_extension('injection_points')) |
||||
{ |
||||
plan skip_all => 'Extension injection_points not installed'; |
||||
} |
||||
|
||||
$node->safe_psql('postgres', 'CREATE EXTENSION injection_points'); |
||||
|
||||
# Connect to the server and inject a waitpoint. |
||||
my $psql = $node->background_psql('postgres'); |
||||
$psql->query_safe("SELECT injection_points_attach('init-pre-auth', 'wait')"); |
||||
|
||||
# From this point on, all new connections will hang during startup, just before |
||||
# authentication. Use the $psql connection handle for server interaction. |
||||
my $conn = $node->background_psql('postgres', wait => 0); |
||||
|
||||
# Wait for the connection to show up. |
||||
my $pid; |
||||
while (1) |
||||
{ |
||||
$pid = $psql->query( |
||||
"SELECT pid FROM pg_stat_activity WHERE state = 'starting';"); |
||||
last if $pid ne ""; |
||||
|
||||
usleep(100_000); |
||||
} |
||||
|
||||
note "backend $pid is authenticating"; |
||||
ok(1, 'authenticating connections are recorded in pg_stat_activity'); |
||||
|
||||
# Detach the waitpoint and wait for the connection to complete. |
||||
$psql->query_safe("SELECT injection_points_wakeup('init-pre-auth');"); |
||||
$conn->wait_connect(); |
||||
|
||||
# Make sure the pgstat entry is updated eventually. |
||||
while (1) |
||||
{ |
||||
my $state = |
||||
$psql->query("SELECT state FROM pg_stat_activity WHERE pid = $pid;"); |
||||
last if $state eq "idle"; |
||||
|
||||
note "state for backend $pid is '$state'; waiting for 'idle'..."; |
||||
usleep(100_000); |
||||
} |
||||
|
||||
ok(1, 'authenticated connections reach idle state in pg_stat_activity'); |
||||
|
||||
$psql->query_safe("SELECT injection_points_detach('init-pre-auth');"); |
||||
$psql->quit(); |
||||
$conn->quit(); |
||||
|
||||
done_testing(); |
||||
Loading…
Reference in new issue