Fix up recent breakage of headerscheck and cpluspluscheck.

headerscheck and cpluspluscheck should skip the recently-added
cmdtaglist.h header, since (like kwlist.h and some other similarly-
designed headers) it's not meant to be included standalone.

evtcache.h was missing an #include to support its usage of Bitmapset.

typecmds.h was missing an #include to support its usage of ParseState.

The first two of these were evidently oversights in commit 2f9661311.
I didn't track down exactly which change broke typecmds.h, but it
must have been some rearrangement in one of its existing inclusions,
because it's referenced ParseState for quite a long time and there
were not complaints from these checking programs before.
pull/51/head
Tom Lane 6 years ago
parent cb2fd7eac2
commit d0587f52b3
  1. 2
      src/include/commands/typecmds.h
  2. 2
      src/include/tcop/cmdtaglist.h
  3. 1
      src/include/utils/evtcache.h
  4. 1
      src/tools/pginclude/cpluspluscheck
  5. 1
      src/tools/pginclude/headerscheck

@ -16,7 +16,7 @@
#include "access/htup.h"
#include "catalog/dependency.h"
#include "nodes/parsenodes.h"
#include "parser/parse_node.h"
#define DEFAULT_TYPDELIM ','

@ -11,7 +11,7 @@
* Portions Copyright (c) 1996-2020, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* src/backend/tcop/cmdtaglist.h
* src/include/tcop/cmdtaglist.h
*
*----------------------------------------------------------------------
*/

@ -14,6 +14,7 @@
#ifndef EVTCACHE_H
#define EVTCACHE_H
#include "nodes/bitmapset.h"
#include "nodes/pg_list.h"
typedef enum

@ -107,6 +107,7 @@ do
test "$f" = src/interfaces/ecpg/preproc/c_kwlist.h && continue
test "$f" = src/interfaces/ecpg/preproc/ecpg_kwlist.h && continue
test "$f" = src/include/regex/regerrs.h && continue
test "$f" = src/include/tcop/cmdtaglist.h && continue
test "$f" = src/pl/plpgsql/src/plerrcodes.h && continue
test "$f" = src/pl/plpython/spiexceptions.h && continue
test "$f" = src/pl/tcl/pltclerrcodes.h && continue

@ -103,6 +103,7 @@ do
test "$f" = src/interfaces/ecpg/preproc/c_kwlist.h && continue
test "$f" = src/interfaces/ecpg/preproc/ecpg_kwlist.h && continue
test "$f" = src/include/regex/regerrs.h && continue
test "$f" = src/include/tcop/cmdtaglist.h && continue
test "$f" = src/pl/plpgsql/src/plerrcodes.h && continue
test "$f" = src/pl/plpython/spiexceptions.h && continue
test "$f" = src/pl/tcl/pltclerrcodes.h && continue

Loading…
Cancel
Save