open-dsi
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make to_timestamp() and to_date() range-check fields of their input.

Browse Source 
Historically, something like to_date('2009-06-40','YYYY-MM-DD') would
return '2009-07-10' because there was no prohibition on out-of-range
month or day numbers.  This has been widely panned, and it also turns
out that Oracle throws an error in such cases.  Since these functions
are nominally Oracle-compatibility features, let's change that.

There's no particular restriction on year (modulo the fact that the
scanner may not believe that more than 4 digits are year digits,
a matter to be addressed separately if at all).  But we now check month,
day, hour, minute, second, and fractional-second fields, as well as
day-of-year and second-of-day fields if those are used.

Currently, no checks are made on ISO-8601-style week numbers or day
numbers; it's not very clear what the appropriate rules would be there,
and they're probably so little used that it's not worth sweating over.

Artur Zakirov, reviewed by Amul Sul, further adjustments by me

Discussion: <1873520224.1784572.1465833145330.JavaMail.yahoo@mail.yahoo.com>
See-Also: <57786490.9010201@wars-nicht.de>
pull/17/head
Tom Lane 9 years ago
parent 967ed9205b
commit d3cd36a133
4 changed files with 239 additions and 66 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 85
      doc/src/sgml/func.sgml
  2. 94
      src/backend/utils/adt/formatting.c
  3. 96
      src/test/regress/expected/horology.out
  4. 30
      src/test/regress/sql/horology.sql

85
doc/src/sgml/func.sgml
Unescape View File

@ -5832,6 +5832,17 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
</para> </para>
</note> </note>
<tip>
<para>
<function>to_timestamp</function> and <function>to_date</function>
exist to handle input formats that cannot be converted by
simple casting. For most standard date/time formats, simply casting the
source string to the required data type works, and is much easier.
Similarly, <function>to_number</> is unnecessary for standard numeric
representations.
</para>
</tip>
<para> <para>
In a <function>to_char</> output template string, there are certain In a <function>to_char</> output template string, there are certain
patterns that are recognized and replaced with appropriately-formatted patterns that are recognized and replaced with appropriately-formatted
@ -6038,7 +6049,7 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
</row> </row>
<row> <row>
<entry><literal>Q</literal></entry> <entry><literal>Q</literal></entry>
<entry>quarter (ignored by <function>to_date</> and <function>to_timestamp</>)</entry> <entry>quarter</entry>
</row> </row>
<row> <row>
<entry><literal>RM</literal></entry> <entry><literal>RM</literal></entry>
@ -6156,20 +6167,6 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
</para> </para>
</listitem> </listitem>
<listitem>
<para>
<function>to_timestamp</function> and <function>to_date</function>
exist to handle input formats that cannot be converted by
simple casting. These functions interpret input liberally,
with minimal error checking. While they produce valid output,
the conversion can yield unexpected results. For example,
input to these functions is not restricted by normal ranges,
thus <literal>to_date('20096040','YYYYMMDD')</literal> returns
<literal>2014-01-17</literal> rather than causing an error.
Casting does not have this behavior.
</para>
</listitem>
<listitem> <listitem>
<para> <para>
Ordinary text is allowed in <function>to_char</function> Ordinary text is allowed in <function>to_char</function>
@ -6195,7 +6192,8 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
<listitem> <listitem>
<para> <para>
If the year format specification is less than four digits, e.g. In <function>to_timestamp</function> and <function>to_date</function>,
if the year format specification is less than four digits, e.g.
<literal>YYY</>, and the supplied year is less than four digits, <literal>YYY</>, and the supplied year is less than four digits,
the year will be adjusted to be nearest to the year 2020, e.g. the year will be adjusted to be nearest to the year 2020, e.g.
<literal>95</> becomes 1995. <literal>95</> becomes 1995.
@ -6204,8 +6202,9 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
<listitem> <listitem>
<para> <para>
The <literal>YYYY</literal> conversion from string to <type>timestamp</type> or In <function>to_timestamp</function> and <function>to_date</function>,
<type>date</type> has a restriction when processing years with more than 4 digits. You must the <literal>YYYY</literal> conversion has a restriction when
processing years with more than 4 digits. You must
use some non-digit character or template after <literal>YYYY</literal>, use some non-digit character or template after <literal>YYYY</literal>,
otherwise the year is always interpreted as 4 digits. For example otherwise the year is always interpreted as 4 digits. For example
(with the year 20000): (with the year 20000):
@ -6219,12 +6218,12 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
<listitem> <listitem>
<para> <para>
In conversions from string to <type>timestamp</type> or In <function>to_timestamp</function> and <function>to_date</function>,
<type>date</type>, the <literal>CC</literal> (century) field is ignored the <literal>CC</literal> (century) field is accepted but ignored
if there is a <literal>YYY</literal>, <literal>YYYY</literal> or if there is a <literal>YYY</literal>, <literal>YYYY</literal> or
<literal>Y,YYY</literal> field. If <literal>CC</literal> is used with <literal>Y,YYY</literal> field. If <literal>CC</literal> is used with
<literal>YY</literal> or <literal>Y</literal> then the year is computed <literal>YY</literal> or <literal>Y</literal> then the result is
as the year in the specified century. If the century is computed as that year in the specified century. If the century is
specified but the year is not, the first year of the century specified but the year is not, the first year of the century
is assumed. is assumed.
</para> </para>
@ -6232,9 +6231,19 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
<listitem> <listitem>
<para> <para>
An ISO 8601 week-numbering date (as distinct from a Gregorian date) In <function>to_timestamp</function> and <function>to_date</function>,
can be specified to <function>to_timestamp</function> and weekday names or numbers (<literal>DAY</literal>, <literal>D</literal>,
<function>to_date</function> in one of two ways: and related field types) are accepted but are ignored for purposes of
computing the result. The same is true for quarter
(<literal>Q</literal>) fields.
</para>
</listitem>
<listitem>
<para>
In <function>to_timestamp</function> and <function>to_date</function>,
an ISO 8601 week-numbering date (as distinct from a Gregorian date)
can be specified in one of two ways:
<itemizedlist> <itemizedlist>
<listitem> <listitem>
<para> <para>
@ -6276,23 +6285,24 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
<listitem> <listitem>
<para> <para>
In a conversion from string to <type>timestamp</type>, millisecond In <function>to_timestamp</function>, millisecond
(<literal>MS</literal>) or microsecond (<literal>US</literal>) (<literal>MS</literal>) or microsecond (<literal>US</literal>)
values are used as the fields are used as the
seconds digits after the decimal point. For example seconds digits after the decimal point. For example
<literal>to_timestamp('12:3', 'SS:MS')</literal> is not 3 milliseconds, <literal>to_timestamp('12.3', 'SS.MS')</literal> is not 3 milliseconds,
but 300, because the conversion counts it as 12 + 0.3 seconds. but 300, because the conversion treats it as 12 + 0.3 seconds.
This means for the format <literal>SS:MS</literal>, the input values So, for the format <literal>SS.MS</literal>, the input values
<literal>12:3</literal>, <literal>12:30</literal>, and <literal>12:300</literal> specify the <literal>12.3</literal>, <literal>12.30</literal>,
same number of milliseconds. To get three milliseconds, one must use and <literal>12.300</literal> specify the
<literal>12:003</literal>, which the conversion counts as same number of milliseconds. To get three milliseconds, one must write
<literal>12.003</literal>, which the conversion treats as
12 + 0.003 = 12.003 seconds. 12 + 0.003 = 12.003 seconds.
</para> </para>
<para> <para>
Here is a more Here is a more
complex example: complex example:
<literal>to_timestamp('15:12:02.020.001230', 'HH:MI:SS.MS.US')</literal> <literal>to_timestamp('15:12:02.020.001230', 'HH24:MI:SS.MS.US')</literal>
is 15 hours, 12 minutes, and 2 seconds + 20 milliseconds + is 15 hours, 12 minutes, and 2 seconds + 20 milliseconds +
1230 microseconds = 2.021230 seconds. 1230 microseconds = 2.021230 seconds.
</para> </para>
@ -6310,9 +6320,10 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.*)){1,1}');
<listitem> <listitem>
<para> <para>
<function>to_char(interval)</function> formats <literal>HH</> and <function>to_char(interval)</function> formats <literal>HH</> and
<literal>HH12</> as shown on a 12-hour clock, i.e. zero hours <literal>HH12</> as shown on a 12-hour clock, for example zero hours
and 36 hours output as <literal>12</>, while <literal>HH24</> and 36 hours both output as <literal>12</>, while <literal>HH24</>
outputs the full hour value, which can exceed 23 for intervals. outputs the full hour value, which can exceed 23 in
an <type>interval</> value.
</para> </para>
</listitem> </listitem>

94
src/backend/utils/adt/formatting.c
Unescape View File

@ -3553,9 +3553,6 @@ to_date(PG_FUNCTION_ARGS)
* *
* The TmFromChar is then analysed and converted into the final results in * The TmFromChar is then analysed and converted into the final results in
* struct 'tm' and 'fsec'. * struct 'tm' and 'fsec'.
*
* This function does very little error checking, e.g.
* to_timestamp('20096040','YYYYMMDD') works
*/ */
static void static void
do_to_timestamp(text *date_txt, text *fmt, do_to_timestamp(text *date_txt, text *fmt,
@ -3564,30 +3561,35 @@ do_to_timestamp(text *date_txt, text *fmt,
FormatNode *format; FormatNode *format;
TmFromChar tmfc; TmFromChar tmfc;
int fmt_len; int fmt_len;
char *date_str;
int fmask;
date_str = text_to_cstring(date_txt);
ZERO_tmfc(&tmfc); ZERO_tmfc(&tmfc);
ZERO_tm(tm); ZERO_tm(tm);
*fsec = 0; *fsec = 0;
fmask = 0; /* bit mask for ValidateDate() */
fmt_len = VARSIZE_ANY_EXHDR(fmt); fmt_len = VARSIZE_ANY_EXHDR(fmt);
if (fmt_len) if (fmt_len)
{ {
char *fmt_str; char *fmt_str;
char *date_str;
bool incache; bool incache;
fmt_str = text_to_cstring(fmt); fmt_str = text_to_cstring(fmt);
/*
* Allocate new memory if format picture is bigger than static cache
* and not use cache (call parser always)
*/
if (fmt_len > DCH_CACHE_SIZE) if (fmt_len > DCH_CACHE_SIZE)
{ {
format = (FormatNode *) palloc((fmt_len + 1) * sizeof(FormatNode)); /*
* Allocate new memory if format picture is bigger than static
* cache and not use cache (call parser always)
*/
incache = FALSE; incache = FALSE;
format = (FormatNode *) palloc((fmt_len + 1) * sizeof(FormatNode));
parse_format(format, fmt_str, DCH_keywords, parse_format(format, fmt_str, DCH_keywords,
DCH_suff, DCH_index, DCH_TYPE, NULL); DCH_suff, DCH_index, DCH_TYPE, NULL);
@ -3604,33 +3606,27 @@ do_to_timestamp(text *date_txt, text *fmt,
if ((ent = DCH_cache_search(fmt_str)) == NULL) if ((ent = DCH_cache_search(fmt_str)) == NULL)
{ {
ent = DCH_cache_getnew(fmt_str);
/* /*
* Not in the cache, must run parser and save a new * Not in the cache, must run parser and save a new
* format-picture to the cache. * format-picture to the cache.
*/ */
ent = DCH_cache_getnew(fmt_str);
parse_format(ent->format, fmt_str, DCH_keywords, parse_format(ent->format, fmt_str, DCH_keywords,
DCH_suff, DCH_index, DCH_TYPE, NULL); DCH_suff, DCH_index, DCH_TYPE, NULL);
(ent->format + fmt_len)->type = NODE_TYPE_END; /* Paranoia? */ (ent->format + fmt_len)->type = NODE_TYPE_END; /* Paranoia? */
#ifdef DEBUG_TO_FROM_CHAR
/* dump_node(ent->format, fmt_len); */
/* dump_index(DCH_keywords, DCH_index); */
#endif
} }
format = ent->format; format = ent->format;
} }
#ifdef DEBUG_TO_FROM_CHAR #ifdef DEBUG_TO_FROM_CHAR
/* dump_node(format, fmt_len); */ /* dump_node(format, fmt_len); */
/* dump_index(DCH_keywords, DCH_index); */
#endif #endif
date_str = text_to_cstring(date_txt);
DCH_from_char(format, date_str, &tmfc); DCH_from_char(format, date_str, &tmfc);
pfree(date_str);
pfree(fmt_str); pfree(fmt_str);
if (!incache) if (!incache)
pfree(format); pfree(format);
@ -3639,8 +3635,7 @@ do_to_timestamp(text *date_txt, text *fmt,
DEBUG_TMFC(&tmfc); DEBUG_TMFC(&tmfc);
/* /*
* Convert values that user define for FROM_CHAR (to_date/to_timestamp) to * Convert to_date/to_timestamp input fields to standard 'tm'
* standard 'tm'
*/ */
if (tmfc.ssss) if (tmfc.ssss)
{ {
@ -3696,19 +3691,23 @@ do_to_timestamp(text *date_txt, text *fmt,
tm->tm_year = (tmfc.cc + 1) * 100 - tm->tm_year + 1; tm->tm_year = (tmfc.cc + 1) * 100 - tm->tm_year + 1;
} }
else else
{
/* find century year for dates ending in "00" */ /* find century year for dates ending in "00" */
tm->tm_year = tmfc.cc * 100 + ((tmfc.cc >= 0) ? 0 : 1); tm->tm_year = tmfc.cc * 100 + ((tmfc.cc >= 0) ? 0 : 1);
} }
}
else else
/* If a 4-digit year is provided, we use that and ignore CC. */
{ {
/* If a 4-digit year is provided, we use that and ignore CC. */
tm->tm_year = tmfc.year; tm->tm_year = tmfc.year;
if (tmfc.bc && tm->tm_year > 0) if (tmfc.bc && tm->tm_year > 0)
tm->tm_year = -(tm->tm_year - 1); tm->tm_year = -(tm->tm_year - 1);
} }
fmask |= DTK_M(YEAR);
} }
else if (tmfc.cc) /* use first year of century */ else if (tmfc.cc)
{ {
/* use first year of century */
if (tmfc.bc) if (tmfc.bc)
tmfc.cc = -tmfc.cc; tmfc.cc = -tmfc.cc;
if (tmfc.cc >= 0) if (tmfc.cc >= 0)
@ -3717,10 +3716,14 @@ do_to_timestamp(text *date_txt, text *fmt,
else else
/* +1 because year == 599 is 600 BC */ /* +1 because year == 599 is 600 BC */
tm->tm_year = tmfc.cc * 100 + 1; tm->tm_year = tmfc.cc * 100 + 1;
fmask |= DTK_M(YEAR);
} }
if (tmfc.j) if (tmfc.j)
{
j2date(tmfc.j, &tm->tm_year, &tm->tm_mon, &tm->tm_mday); j2date(tmfc.j, &tm->tm_year, &tm->tm_mon, &tm->tm_mday);
fmask |= DTK_DATE_M;
}
if (tmfc.ww) if (tmfc.ww)
{ {
@ -3734,6 +3737,7 @@ do_to_timestamp(text *date_txt, text *fmt,
isoweekdate2date(tmfc.ww, tmfc.d, &tm->tm_year, &tm->tm_mon, &tm->tm_mday); isoweekdate2date(tmfc.ww, tmfc.d, &tm->tm_year, &tm->tm_mon, &tm->tm_mday);
else else
isoweek2date(tmfc.ww, &tm->tm_year, &tm->tm_mon, &tm->tm_mday); isoweek2date(tmfc.ww, &tm->tm_year, &tm->tm_mon, &tm->tm_mday);
fmask |= DTK_DATE_M;
} }
else else
tmfc.ddd = (tmfc.ww - 1) * 7 + 1; tmfc.ddd = (tmfc.ww - 1) * 7 + 1;
@ -3741,14 +3745,16 @@ do_to_timestamp(text *date_txt, text *fmt,
if (tmfc.w) if (tmfc.w)
tmfc.dd = (tmfc.w - 1) * 7 + 1; tmfc.dd = (tmfc.w - 1) * 7 + 1;
if (tmfc.d)
tm->tm_wday = tmfc.d - 1; /* convert to native numbering */
if (tmfc.dd) if (tmfc.dd)
{
tm->tm_mday = tmfc.dd; tm->tm_mday = tmfc.dd;
if (tmfc.ddd) fmask |= DTK_M(DAY);
tm->tm_yday = tmfc.ddd; }
if (tmfc.mm) if (tmfc.mm)
{
tm->tm_mon = tmfc.mm; tm->tm_mon = tmfc.mm;
fmask |= DTK_M(MONTH);
}
if (tmfc.ddd && (tm->tm_mon <= 1 || tm->tm_mday <= 1)) if (tmfc.ddd && (tm->tm_mon <= 1 || tm->tm_mday <= 1))
{ {
@ -3771,6 +3777,7 @@ do_to_timestamp(text *date_txt, text *fmt,
j0 = isoweek2j(tm->tm_year, 1) - 1; j0 = isoweek2j(tm->tm_year, 1) - 1;
j2date(j0 + tmfc.ddd, &tm->tm_year, &tm->tm_mon, &tm->tm_mday); j2date(j0 + tmfc.ddd, &tm->tm_year, &tm->tm_mon, &tm->tm_mday);
fmask |= DTK_DATE_M;
} }
else else
{ {
@ -3785,7 +3792,7 @@ do_to_timestamp(text *date_txt, text *fmt,
for (i = 1; i <= MONTHS_PER_YEAR; i++) for (i = 1; i <= MONTHS_PER_YEAR; i++)
{ {
if (tmfc.ddd < y[i]) if (tmfc.ddd <= y[i])
break; break;
} }
if (tm->tm_mon <= 1) if (tm->tm_mon <= 1)
@ -3793,6 +3800,8 @@ do_to_timestamp(text *date_txt, text *fmt,
if (tm->tm_mday <= 1) if (tm->tm_mday <= 1)
tm->tm_mday = tmfc.ddd - y[i - 1]; tm->tm_mday = tmfc.ddd - y[i - 1];
fmask |= DTK_M(MONTH) | DTK_M(DAY);
} }
} }
@ -3808,7 +3817,38 @@ do_to_timestamp(text *date_txt, text *fmt,
*fsec += (double) tmfc.us / 1000000; *fsec += (double) tmfc.us / 1000000;
#endif #endif
/* Range-check date fields according to bit mask computed above */
if (fmask != 0)
{
/* We already dealt with AD/BC, so pass isjulian = true */
int dterr = ValidateDate(fmask, true, false, false, tm);
if (dterr != 0)
{
/*
* Force the error to be DTERR_FIELD_OVERFLOW even if ValidateDate
* said DTERR_MD_FIELD_OVERFLOW, because we don't want to print an
* irrelevant hint about datestyle.
*/
DateTimeParseError(DTERR_FIELD_OVERFLOW, date_str, "timestamp");
}
}
/* Range-check time fields too */
if (tm->tm_hour < 0 || tm->tm_hour >= HOURS_PER_DAY ||
tm->tm_min < 0 || tm->tm_min >= MINS_PER_HOUR ||
tm->tm_sec < 0 || tm->tm_sec >= SECS_PER_MINUTE ||
#ifdef HAVE_INT64_TIMESTAMP
*fsec < INT64CONST(0) || *fsec >= USECS_PER_SEC
#else
*fsec < 0 || *fsec >= 1
#endif
)
DateTimeParseError(DTERR_FIELD_OVERFLOW, date_str, "timestamp");
DEBUG_TM(tm); DEBUG_TM(tm);
pfree(date_str);
} }

96
src/test/regress/expected/horology.out
Unescape View File

@ -2822,6 +2822,18 @@ SELECT to_timestamp('20000-1116', 'YYYY-MMDD');
Thu Nov 16 00:00:00 20000 PST Thu Nov 16 00:00:00 20000 PST
(1 row) (1 row)
SELECT to_timestamp('1997 AD 11 16', 'YYYY BC MM DD');
to_timestamp
------------------------------
Sun Nov 16 00:00:00 1997 PST
(1 row)
SELECT to_timestamp('1997 BC 11 16', 'YYYY BC MM DD');
to_timestamp
---------------------------------
Tue Nov 16 00:00:00 1997 PST BC
(1 row)
SELECT to_timestamp('9-1116', 'Y-MMDD'); SELECT to_timestamp('9-1116', 'Y-MMDD');
to_timestamp to_timestamp
------------------------------ ------------------------------
@ -2906,6 +2918,18 @@ SELECT to_timestamp(' 20050302', 'YYYYMMDD');
Wed Mar 02 00:00:00 2005 PST Wed Mar 02 00:00:00 2005 PST
(1 row) (1 row)
SELECT to_timestamp('2011-12-18 11:38 AM', 'YYYY-MM-DD HH12:MI PM');
to_timestamp
------------------------------
Sun Dec 18 11:38:00 2011 PST
(1 row)
SELECT to_timestamp('2011-12-18 11:38 PM', 'YYYY-MM-DD HH12:MI PM');
to_timestamp
------------------------------
Sun Dec 18 23:38:00 2011 PST
(1 row)
-- --
-- Check handling of multiple spaces in format and/or input -- Check handling of multiple spaces in format and/or input
-- --
@ -2982,7 +3006,7 @@ SELECT to_date('2011 12 18', 'YYYY MM DD');
(1 row) (1 row)
-- --
-- Check errors for some incorrect usages of to_timestamp() -- Check errors for some incorrect usages of to_timestamp() and to_date()
-- --
-- Mixture of date conventions (ISO week and Gregorian): -- Mixture of date conventions (ISO week and Gregorian):
SELECT to_timestamp('2005527', 'YYYYIWID'); SELECT to_timestamp('2005527', 'YYYYIWID');
@ -3010,6 +3034,76 @@ DETAIL: Value must be an integer.
SELECT to_timestamp('10000000000', 'FMYYYY'); SELECT to_timestamp('10000000000', 'FMYYYY');
ERROR: value for "YYYY" in source string is out of range ERROR: value for "YYYY" in source string is out of range
DETAIL: Value must be in the range -2147483648 to 2147483647. DETAIL: Value must be in the range -2147483648 to 2147483647.
-- Out-of-range and not-quite-out-of-range fields:
SELECT to_timestamp('2016-06-13 25:00:00', 'YYYY-MM-DD HH24:MI:SS');
ERROR: date/time field value out of range: "2016-06-13 25:00:00"
SELECT to_timestamp('2016-06-13 15:60:00', 'YYYY-MM-DD HH24:MI:SS');
ERROR: date/time field value out of range: "2016-06-13 15:60:00"
SELECT to_timestamp('2016-06-13 15:50:60', 'YYYY-MM-DD HH24:MI:SS');
ERROR: date/time field value out of range: "2016-06-13 15:50:60"
SELECT to_timestamp('2016-06-13 15:50:55', 'YYYY-MM-DD HH24:MI:SS'); -- ok
to_timestamp
------------------------------
Mon Jun 13 15:50:55 2016 PDT
(1 row)
SELECT to_timestamp('2016-06-13 15:50:55', 'YYYY-MM-DD HH:MI:SS');
ERROR: hour "15" is invalid for the 12-hour clock
HINT: Use the 24-hour clock, or give an hour between 1 and 12.
SELECT to_timestamp('2016-13-01 15:50:55', 'YYYY-MM-DD HH24:MI:SS');
ERROR: date/time field value out of range: "2016-13-01 15:50:55"
SELECT to_timestamp('2016-02-30 15:50:55', 'YYYY-MM-DD HH24:MI:SS');
ERROR: date/time field value out of range: "2016-02-30 15:50:55"
SELECT to_timestamp('2016-02-29 15:50:55', 'YYYY-MM-DD HH24:MI:SS'); -- ok
to_timestamp
------------------------------
Mon Feb 29 15:50:55 2016 PST
(1 row)
SELECT to_timestamp('2015-02-29 15:50:55', 'YYYY-MM-DD HH24:MI:SS');
ERROR: date/time field value out of range: "2015-02-29 15:50:55"
SELECT to_timestamp('2015-02-11 86000', 'YYYY-MM-DD SSSS'); -- ok
to_timestamp
------------------------------
Wed Feb 11 23:53:20 2015 PST
(1 row)
SELECT to_timestamp('2015-02-11 86400', 'YYYY-MM-DD SSSS');
ERROR: date/time field value out of range: "2015-02-11 86400"
SELECT to_date('2016-13-10', 'YYYY-MM-DD');
ERROR: date/time field value out of range: "2016-13-10"
SELECT to_date('2016-02-30', 'YYYY-MM-DD');
ERROR: date/time field value out of range: "2016-02-30"
SELECT to_date('2016-02-29', 'YYYY-MM-DD'); -- ok
to_date
------------
02-29-2016
(1 row)
SELECT to_date('2015-02-29', 'YYYY-MM-DD');
ERROR: date/time field value out of range: "2015-02-29"
SELECT to_date('2015 365', 'YYYY DDD'); -- ok
to_date
------------
12-31-2015
(1 row)
SELECT to_date('2015 366', 'YYYY DDD');
ERROR: date/time field value out of range: "2015 366"
SELECT to_date('2016 365', 'YYYY DDD'); -- ok
to_date
------------
12-30-2016
(1 row)
SELECT to_date('2016 366', 'YYYY DDD'); -- ok
to_date
------------
12-31-2016
(1 row)
SELECT to_date('2016 367', 'YYYY DDD');
ERROR: date/time field value out of range: "2016 367"
-- --
-- Check behavior with SQL-style fixed-GMT-offset time zone (cf bug #8572) -- Check behavior with SQL-style fixed-GMT-offset time zone (cf bug #8572)
-- --

30
src/test/regress/sql/horology.sql
Unescape View File

@ -412,6 +412,9 @@ SELECT to_timestamp('19971116', 'YYYYMMDD');
SELECT to_timestamp('20000-1116', 'YYYY-MMDD'); SELECT to_timestamp('20000-1116', 'YYYY-MMDD');
SELECT to_timestamp('1997 AD 11 16', 'YYYY BC MM DD');
SELECT to_timestamp('1997 BC 11 16', 'YYYY BC MM DD');
SELECT to_timestamp('9-1116', 'Y-MMDD'); SELECT to_timestamp('9-1116', 'Y-MMDD');
SELECT to_timestamp('95-1116', 'YY-MMDD'); SELECT to_timestamp('95-1116', 'YY-MMDD');
@ -440,6 +443,9 @@ SELECT to_timestamp(' 2005 03 02', 'YYYYMMDD');
SELECT to_timestamp(' 20050302', 'YYYYMMDD'); SELECT to_timestamp(' 20050302', 'YYYYMMDD');
SELECT to_timestamp('2011-12-18 11:38 AM', 'YYYY-MM-DD HH12:MI PM');
SELECT to_timestamp('2011-12-18 11:38 PM', 'YYYY-MM-DD HH12:MI PM');
-- --
-- Check handling of multiple spaces in format and/or input -- Check handling of multiple spaces in format and/or input
-- --
@ -461,7 +467,7 @@ SELECT to_date('2011 12 18', 'YYYY MM DD');
SELECT to_date('2011 12 18', 'YYYY MM DD'); SELECT to_date('2011 12 18', 'YYYY MM DD');
-- --
-- Check errors for some incorrect usages of to_timestamp() -- Check errors for some incorrect usages of to_timestamp() and to_date()
-- --
-- Mixture of date conventions (ISO week and Gregorian): -- Mixture of date conventions (ISO week and Gregorian):
@ -482,6 +488,28 @@ SELECT to_timestamp('199711xy', 'YYYYMMDD');
-- Input that doesn't fit in an int: -- Input that doesn't fit in an int:
SELECT to_timestamp('10000000000', 'FMYYYY'); SELECT to_timestamp('10000000000', 'FMYYYY');
-- Out-of-range and not-quite-out-of-range fields:
SELECT to_timestamp('2016-06-13 25:00:00', 'YYYY-MM-DD HH24:MI:SS');
SELECT to_timestamp('2016-06-13 15:60:00', 'YYYY-MM-DD HH24:MI:SS');
SELECT to_timestamp('2016-06-13 15:50:60', 'YYYY-MM-DD HH24:MI:SS');
SELECT to_timestamp('2016-06-13 15:50:55', 'YYYY-MM-DD HH24:MI:SS'); -- ok
SELECT to_timestamp('2016-06-13 15:50:55', 'YYYY-MM-DD HH:MI:SS');
SELECT to_timestamp('2016-13-01 15:50:55', 'YYYY-MM-DD HH24:MI:SS');
SELECT to_timestamp('2016-02-30 15:50:55', 'YYYY-MM-DD HH24:MI:SS');
SELECT to_timestamp('2016-02-29 15:50:55', 'YYYY-MM-DD HH24:MI:SS'); -- ok
SELECT to_timestamp('2015-02-29 15:50:55', 'YYYY-MM-DD HH24:MI:SS');
SELECT to_timestamp('2015-02-11 86000', 'YYYY-MM-DD SSSS'); -- ok
SELECT to_timestamp('2015-02-11 86400', 'YYYY-MM-DD SSSS');
SELECT to_date('2016-13-10', 'YYYY-MM-DD');
SELECT to_date('2016-02-30', 'YYYY-MM-DD');
SELECT to_date('2016-02-29', 'YYYY-MM-DD'); -- ok
SELECT to_date('2015-02-29', 'YYYY-MM-DD');
SELECT to_date('2015 365', 'YYYY DDD'); -- ok
SELECT to_date('2015 366', 'YYYY DDD');
SELECT to_date('2016 365', 'YYYY DDD'); -- ok
SELECT to_date('2016 366', 'YYYY DDD'); -- ok
SELECT to_date('2016 367', 'YYYY DDD');
-- --
-- Check behavior with SQL-style fixed-GMT-offset time zone (cf bug #8572) -- Check behavior with SQL-style fixed-GMT-offset time zone (cf bug #8572)
-- --

Write Preview
Loading…
Cancel
Save