Fix C comment typo and redundant test

pull/12/head^2
Kevin Grittner 10 years ago
parent 6b1a213bbd
commit e65953be4f
  1. 7
      src/backend/utils/time/snapmgr.c

@ -1659,7 +1659,7 @@ TransactionIdLimitedForOldSnapshots(TransactionId recentXmin,
* This is not an assertion because we avoid the spinlock for * This is not an assertion because we avoid the spinlock for
* performance, leaving open the possibility that xlimit could advance * performance, leaving open the possibility that xlimit could advance
* and be more current; but it seems prudent to apply this limit. It * and be more current; but it seems prudent to apply this limit. It
* might make pruning a tiny bit less agressive than it could be, but * might make pruning a tiny bit less aggressive than it could be, but
* protects against data loss bugs. * protects against data loss bugs.
*/ */
if (TransactionIdIsNormal(latest_xmin) if (TransactionIdIsNormal(latest_xmin)
@ -1681,9 +1681,8 @@ MaintainOldSnapshotTimeMapping(int64 whenTaken, TransactionId xmin)
{ {
int64 ts; int64 ts;
/* Fast exit when old_snapshot_threshold is not used. */ /* Never call this function when old snapshot checking is disabled. */
if (old_snapshot_threshold < 0) Assert(old_snapshot_threshold >= 0);
return;
/* Keep track of the latest xmin seen by any process. */ /* Keep track of the latest xmin seen by any process. */
SpinLockAcquire(&oldSnapshotControl->mutex_latest_xmin); SpinLockAcquire(&oldSnapshotControl->mutex_latest_xmin);

Loading…
Cancel
Save