408 Commits (0c67dbcc4e39e160bc5c9d7db3b3f011292d5a85)

Author	SHA1	Message	Date
Tom Lane	09a7cd409e	Rename postgres_fdw's use_remote_explain option to use_remote_estimate. ... The new name was originally my typo, but per discussion it seems like a better name anyway. So make the code match the docs, not vice versa.	13 years ago
Tom Lane	c0c6acdfa0	Fix some planning oversights in postgres_fdw. ... Include eval costs of local conditions in remote-estimate mode, and don't assume the remote eval cost is zero in local-estimate mode. (The best we can do with that at the moment is to assume a seqscan, which may well be wildly pessimistic ... but zero won't do at all.) To get a reasonable local estimate, we need to know the relpages count for the remote rel, so improve the ANALYZE code to fetch that rather than just setting the foreign table's relpages field to zero.	13 years ago
Tom Lane	6da378dbc9	Fix whole-row references in postgres_fdw. ... The optimization to not retrieve unnecessary columns wasn't smart enough. Noted by Thom Brown.	13 years ago
Tom Lane	211e157a51	Change postgres_fdw to show casts as casts, not underlying function calls. ... On reflection this method seems to be exposing an unreasonable amount of implementation detail. It wouldn't matter when talking to a remote server of the identical Postgres version, but it seems likely to make things worse not better if the remote is a different version with different casting infrastructure. Instead adopt ruleutils.c's policy of regurgitating the cast as it was originally specified; including not showing it at all, if it was implicit to start with. (We must do that because for some datatypes explicit and implicit casts have different semantics.)	13 years ago
Tom Lane	5fd386bb31	Get rid of postgres_fdw's assumption that remote type OIDs match ours. ... The only place we depended on that was in sending numeric type OIDs in PQexecParams; but we can replace that usage with explicitly casting each Param symbol in the query string, so that the types are specified to the remote by name not OID. This makes no immediate difference but will be essential if we ever hope to support use of non-builtin types.	13 years ago
Tom Lane	6d06049493	Adjust postgres_fdw's search path handling. ... Set the remote session's search path to exactly "pg_catalog" at session start, then schema-qualify only names that aren't in that schema. This greatly reduces clutter in the generated SQL commands, as seen in the regression test changes. Per discussion. Also, rethink use of FirstNormalObjectId as the "built-in object" cutoff --- FirstBootstrapObjectId is safer, since the former will accept objects in information_schema for instance.	13 years ago
Tom Lane	54a2786835	Need to decorate XactIsoLevel as PGDLLIMPORT for postgres_fdw. ... Per buildfarm.	13 years ago
Tom Lane	d0d75c4022	Add postgres_fdw contrib module. ... There's still a lot of room for improvement, but it basically works, and we need this to be present before we can do anything much with the writable-foreign-tables patch. So let's commit it and get on with testing. Shigeru Hanada, reviewed by KaiGai Kohei and Tom Lane	13 years ago